Re: [Xen-devel] [PATCH] x86: guard more stack pages

2018-03-02 Thread Andrew Cooper
On 02/03/18 12:01, Jan Beulich wrote: > > @@ -16,9 +16,9 @@ > * > * 7 - Primary stack (with a struct cpu_info at the top) > * 6 - Primary stack > - * 5 - Optionally not preset (MEMORY_GUARD) > - * 4 - unused > - * 3 - Syscall trampolines > + * 5 - Optionally not present (MEMORY_GUARD) > + * 4

Re: [Xen-devel] [PATCH] x86: guard more stack pages

2018-03-02 Thread Jan Beulich
>>> On 02.03.18 at 12:51, wrote: > On 02/03/18 11:24, Jan Beulich wrote: >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -5563,10 +5563,11 @@ void memguard_unguard_range(void *p, uns >> >> void memguard_guard_stack(void *p) >> { >> -BUILD_BUG_ON((PRIMARY_STACK_SIZE + PAGE_SIZE)

Re: [Xen-devel] [PATCH] x86: guard more stack pages

2018-03-02 Thread Andrew Cooper
On 02/03/18 11:24, Jan Beulich wrote: > There's no reason to keep the unused pages (of which there are actually > two; respective commentary also gets adjusted) mapped. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -5563,10 +5563,11 @@ void memguard_ungu

[Xen-devel] [PATCH] x86: guard more stack pages

2018-03-02 Thread Jan Beulich
There's no reason to keep the unused pages (of which there are actually two; respective commentary also gets adjusted) mapped. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -5563,10 +5563,11 @@ void memguard_unguard_range(void *p, uns void memguard_guard_stack(