Re: [Xen-devel] [PATCH] x86/mm: Drop {HAP,SHADOW}_ERROR() wrappers

2018-08-30 Thread Jan Beulich
>>> On 30.08.18 at 17:20, wrote: > On 30/08/18 16:15, Jan Beulich wrote: > On 28.08.18 at 20:11, wrote: >>> @@ -2478,9 +2478,7 @@ sh_map_and_validate_gl4e(struct vcpu *v, mfn_t gl4mfn, >>> shadow_l4_index, >>> validate_gl4e); >

Re: [Xen-devel] [PATCH] x86/mm: Drop {HAP,SHADOW}_ERROR() wrappers

2018-08-30 Thread Andrew Cooper
On 30/08/18 16:15, Jan Beulich wrote: On 28.08.18 at 20:11, wrote: >> --- a/xen/arch/x86/mm/hap/hap.c >> +++ b/xen/arch/x86/mm/hap/hap.c >> @@ -304,10 +304,11 @@ static void hap_free_p2m_page(struct domain *d, struct >> page_info *pg) >> /* Should still have no owner and count zero. */

Re: [Xen-devel] [PATCH] x86/mm: Drop {HAP,SHADOW}_ERROR() wrappers

2018-08-30 Thread Jan Beulich
>>> On 28.08.18 at 20:11, wrote: > --- a/xen/arch/x86/mm/hap/hap.c > +++ b/xen/arch/x86/mm/hap/hap.c > @@ -304,10 +304,11 @@ static void hap_free_p2m_page(struct domain *d, struct > page_info *pg) > /* Should still have no owner and count zero. */ > if ( owner || (pg->count_info & PGC_c

Re: [Xen-devel] [PATCH] x86/mm: Drop {HAP,SHADOW}_ERROR() wrappers

2018-08-30 Thread Tim Deegan
At 19:11 +0100 on 28 Aug (1535483514), Andrew Cooper wrote: > Unlike the PRINTK/DEBUG wrappers, these go straight out to the console, rather > than ending up in the debugtrace buffer. > > A number of these users are followed by domain_crash(), and future changes > will want to combine the printk()

Re: [Xen-devel] [PATCH] x86/mm: Drop {HAP,SHADOW}_ERROR() wrappers

2018-08-29 Thread Wei Liu
On Tue, Aug 28, 2018 at 07:11:54PM +0100, Andrew Cooper wrote: > Unlike the PRINTK/DEBUG wrappers, these go straight out to the console, rather > than ending up in the debugtrace buffer. > > A number of these users are followed by domain_crash(), and future changes > will want to combine the print

[Xen-devel] [PATCH] x86/mm: Drop {HAP,SHADOW}_ERROR() wrappers

2018-08-28 Thread Andrew Cooper
Unlike the PRINTK/DEBUG wrappers, these go straight out to the console, rather than ending up in the debugtrace buffer. A number of these users are followed by domain_crash(), and future changes will want to combine the printk() into the domain_crash() call. Expand these wrappers in place, using