Re: [Xen-devel] [PATCH] x86/altp2m: propagate ept.ad changes to all active altp2ms

2018-10-01 Thread George Dunlap
On 09/28/2018 05:19 PM, Razvan Cojocaru wrote: > On 9/28/18 6:55 PM, Jan Beulich wrote: > On 28.09.18 at 17:25, wrote: >>> On 9/28/18 5:52 PM, Jan Beulich wrote: >>> On 28.09.18 at 13:55, wrote: > @@ -1218,34 +1219,67 @@ static void ept_tlb_flush(struct p2m_domain *p2m) > ept

Re: [Xen-devel] [PATCH] x86/altp2m: propagate ept.ad changes to all active altp2ms

2018-09-28 Thread Razvan Cojocaru
On 9/28/18 6:55 PM, Jan Beulich wrote: On 28.09.18 at 17:25, wrote: >> On 9/28/18 5:52 PM, Jan Beulich wrote: >> On 28.09.18 at 13:55, wrote: @@ -1218,34 +1219,67 @@ static void ept_tlb_flush(struct p2m_domain *p2m) ept_sync_domain_mask(p2m, p2m->domain->dirty_cpumask); >>

Re: [Xen-devel] [PATCH] x86/altp2m: propagate ept.ad changes to all active altp2ms

2018-09-28 Thread Jan Beulich
>>> On 28.09.18 at 17:25, wrote: > On 9/28/18 5:52 PM, Jan Beulich wrote: > On 28.09.18 at 13:55, wrote: >>> @@ -1218,34 +1219,67 @@ static void ept_tlb_flush(struct p2m_domain *p2m) >>> ept_sync_domain_mask(p2m, p2m->domain->dirty_cpumask); >>> } >>> >>> +static void ept_set_ad_sync(

Re: [Xen-devel] [PATCH] x86/altp2m: propagate ept.ad changes to all active altp2ms

2018-09-28 Thread Razvan Cojocaru
On 9/28/18 5:52 PM, Jan Beulich wrote: On 28.09.18 at 13:55, wrote: >> @@ -1218,34 +1219,67 @@ static void ept_tlb_flush(struct p2m_domain *p2m) >> ept_sync_domain_mask(p2m, p2m->domain->dirty_cpumask); >> } >> >> +static void ept_set_ad_sync(struct p2m_domain *p2m, int value) > > Ca

Re: [Xen-devel] [PATCH] x86/altp2m: propagate ept.ad changes to all active altp2ms

2018-09-28 Thread Jan Beulich
>>> On 28.09.18 at 13:55, wrote: > @@ -1218,34 +1219,67 @@ static void ept_tlb_flush(struct p2m_domain *p2m) > ept_sync_domain_mask(p2m, p2m->domain->dirty_cpumask); > } > > +static void ept_set_ad_sync(struct p2m_domain *p2m, int value) Can the second parameter be bool please (and the tr

Re: [Xen-devel] [PATCH] x86/altp2m: propagate ept.ad changes to all active altp2ms

2018-09-28 Thread Razvan Cojocaru
On 9/28/18 2:55 PM, Razvan Cojocaru wrote: > This patch is a pre-requisite for fixing the logdirty VGA issue > (display freezes when switching to a new altp2m view early in a > domain's lifetime), but sent separately for easier review. > The new ept_set_ad_sync() function has been added to update a

[Xen-devel] [PATCH] x86/altp2m: propagate ept.ad changes to all active altp2ms

2018-09-28 Thread Razvan Cojocaru
This patch is a pre-requisite for fixing the logdirty VGA issue (display freezes when switching to a new altp2m view early in a domain's lifetime), but sent separately for easier review. The new ept_set_ad_sync() function has been added to update all active altp2ms' ept.ad. New altp2ms will inherit