Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-28 Thread Paul Durrant
o: 'Jan Beulich' > >> Cc: Andrew Cooper ; Julien Grall > >> ; xen-devel > >> Subject: Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between > internal > >> and extern emulation > >> > >> > -Original Message- >

Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-28 Thread Jan Beulich
Julien Grall >> ; xen-devel >> Subject: Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal >> and extern emulation >> >> > -Original Message- >> > From: Jan Beulich [mailto:jbeul...@suse.com] >> > Sent: 28 November 2017 11:26 &g

Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-28 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 28 November 2017 11:31 > To: 'Jan Beulich' > Cc: Andrew Cooper ; Julien Grall > ; xen-devel > Subject: Re: [Xen-devel] [PATCH

Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-28 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 28 November 2017 11:26 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH] x86/HVM: fix interaction between internal and extern > emulation > > >

Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-28 Thread Jan Beulich
>>> On 28.11.17 at 12:06, wrote: > Yes, it appears that mmio_retry is only set when the underlying emulation > returned X86EMUL_OKAY but not all reps were completed. If the underlying > emulation did not return X86EMUL_RETRY then I can't figure out why > vio->io_completion should need to be set

Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-28 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 28 November 2017 11:01 > To: 'Jan Beulich' > Cc: Andrew Cooper ; Julien Grall > ; xen-devel > Subject: Re: [Xen-devel] [PATCH

Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-28 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 28 November 2017 10:40 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH] x86/HVM: fix interaction between internal and extern > emulation > > >

Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-28 Thread Jan Beulich
>>> On 28.11.17 at 11:22, wrote: > It would definitely be good to only reset io_completion when it is clear > that handle_hvm_io_completion() is not going to be called (i.e. for > internally handled I/O) Where would you suggest to do that? These two ... > and perhaps even add ASSERTs in _hvm_e

Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-28 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 28 November 2017 10:17 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH] x86/HVM: fix interaction between internal and extern > emulation > > >

Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-28 Thread Jan Beulich
>>> On 28.11.17 at 11:05, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 28 November 2017 10:02 >> >>> On 28.11.17 at 10:49, wrote: >> >> From: Jan Beulich [mailto:jbeul...@suse.com] >> >> Sent: 27 November 2017 08:29 >> >> handle_hvm_io_completion() is being involved in resuming

Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-28 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 28 November 2017 10:02 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH] x86/HVM: fix interaction between internal and extern > emulation > > >

Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-28 Thread Jan Beulich
>>> On 28.11.17 at 10:49, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 27 November 2017 08:29 >> To: xen-devel >> Cc: Julien Grall ; Andrew Cooper >> ; Paul Durrant >> Subject: [PATCH] x86/HVM: fix interaction between internal and extern >> emula

Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-28 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 27 November 2017 08:29 > To: xen-devel > Cc: Julien Grall ; Andrew Cooper > ; Paul Durrant > Subject: [PATCH] x86/HVM: fix interaction between internal and extern > emulation > > handle_hvm_io_completion() is bei

Re: [Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-27 Thread Andrew Cooper
On 27/11/17 08:28, Jan Beulich wrote: > handle_hvm_io_completion() is being involved in resuming from requests > sent to a device model only, while re-invocation of internally handled > I/O which couldn't be handled in one go simply re-starts the affected > instruction. When an internally handled s

[Xen-devel] [PATCH] x86/HVM: fix interaction between internal and extern emulation

2017-11-27 Thread Jan Beulich
handle_hvm_io_completion() is being involved in resuming from requests sent to a device model only, while re-invocation of internally handled I/O which couldn't be handled in one go simply re-starts the affected instruction. When an internally handled split request is being followed by one sent to