Re: [Xen-devel] [PATCH] vhpet: check that the set interrupt route is valid

2018-05-14 Thread Jan Beulich
>>> On 10.05.18 at 11:08, wrote: > @@ -304,6 +313,30 @@ static inline uint64_t hpet_fixup_reg( > return new; > } > > +static void timer_sanitize_int(HPETState *h, unsigned int tn) "int" as sort of a suffix here might be misleading (could be viewed as some sort of integer as well) - how ab

[Xen-devel] [PATCH] vhpet: check that the set interrupt route is valid

2018-05-10 Thread Roger Pau Monne
The value written by the guest must be valid according to the mask provided in the interrupt routing capabilities register. If the interrupt is not valid set it to the first valid IRQ in the capabilities field if the timer is enabled, else just clear the field. Also refuse to start any timer that