Re: [Xen-devel] [PATCH] tools: libxenstat: fix format string overflow

2018-02-16 Thread Dario Faggioli
On Fri, 2018-02-16 at 17:58 +, Wei Liu wrote: > On Fri, Feb 16, 2018 at 06:55:08PM +0100, Dario Faggioli wrote: > > On Fri, 2018-02-16 at 17:44 +, Wei Liu wrote: > > > > > Right! And what do I do if it fails, 'continue' the while(), I > > guess? > > > > Looking at the error message again

Re: [Xen-devel] [PATCH] tools: libxenstat: fix format string overflow

2018-02-16 Thread Wei Liu
On Fri, Feb 16, 2018 at 06:55:08PM +0100, Dario Faggioli wrote: > On Fri, 2018-02-16 at 17:44 +, Wei Liu wrote: > > On Fri, Feb 16, 2018 at 06:36:51PM +0100, Dario Faggioli wrote: > > > > > > --- a/tools/xenstat/libxenstat/src/xenstat_linux.c > > > +++ b/tools/xenstat/libxenstat/src/xenstat_li

Re: [Xen-devel] [PATCH] tools: libxenstat: fix format string overflow

2018-02-16 Thread Dario Faggioli
On Fri, 2018-02-16 at 17:44 +, Wei Liu wrote: > On Fri, Feb 16, 2018 at 06:36:51PM +0100, Dario Faggioli wrote: > > > > --- a/tools/xenstat/libxenstat/src/xenstat_linux.c > > +++ b/tools/xenstat/libxenstat/src/xenstat_linux.c > > @@ -69,18 +69,20 @@ void getBridge(char *excludeName, char *resu

Re: [Xen-devel] [PATCH] tools: libxenstat: fix format string overflow

2018-02-16 Thread Dario Faggioli
On Fri, 2018-02-16 at 17:44 +, Wei Liu wrote: > On Fri, Feb 16, 2018 at 06:36:51PM +0100, Dario Faggioli wrote: > > > > --- a/tools/xenstat/libxenstat/src/xenstat_linux.c > > +++ b/tools/xenstat/libxenstat/src/xenstat_linux.c > > @@ -69,18 +69,20 @@ void getBridge(char *excludeName, char *resu

Re: [Xen-devel] [PATCH] tools: libxenstat: fix format string overflow

2018-02-16 Thread Wei Liu
On Fri, Feb 16, 2018 at 05:44:05PM +, Wei Liu wrote: > On Fri, Feb 16, 2018 at 06:36:51PM +0100, Dario Faggioli wrote: > > With gcc 7.3.0, the build fails like this: > > > > src/xenstat_linux.c: In function ‘getBridge’ > > src/xenstat_linux.c:78:34: warning: ‘%s’ directive writing up to 255 by

Re: [Xen-devel] [PATCH] tools: libxenstat: fix format string overflow

2018-02-16 Thread Wei Liu
On Fri, Feb 16, 2018 at 06:36:51PM +0100, Dario Faggioli wrote: > With gcc 7.3.0, the build fails like this: > > src/xenstat_linux.c: In function ‘getBridge’ > src/xenstat_linux.c:78:34: warning: ‘%s’ directive writing up to 255 bytes > into a region of size 241 [-Wformat-overflow=] > sprint

Re: [Xen-devel] [PATCH] tools: libxenstat: fix format string overflow

2018-02-16 Thread Andrew Cooper
On 16/02/18 17:36, Dario Faggioli wrote: > With gcc 7.3.0, the build fails like this: > > src/xenstat_linux.c: In function ‘getBridge’ > src/xenstat_linux.c:78:34: warning: ‘%s’ directive writing up to 255 bytes > into a region of size 241 [-Wformat-overflow=] > sprintf(tmp, "/sys/class/net/%

[Xen-devel] [PATCH] tools: libxenstat: fix format string overflow

2018-02-16 Thread Dario Faggioli
With gcc 7.3.0, the build fails like this: src/xenstat_linux.c: In function ‘getBridge’ src/xenstat_linux.c:78:34: warning: ‘%s’ directive writing up to 255 bytes into a region of size 241 [-Wformat-overflow=] sprintf(tmp, "/sys/class/net/%s/bridge", de->d_name);