Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-08 Thread Jan Beulich
On 08.10.2019 16:16, Roger Pau Monné wrote: > On Tue, Oct 08, 2019 at 03:32:25PM +0200, Jan Beulich wrote: >> On 08.10.2019 15:14, Roger Pau Monné wrote: >>> On Tue, Oct 08, 2019 at 01:28:49PM +0200, Jan Beulich wrote: On 08.10.2019 13:09, Roger Pau Monné wrote: > Given that as you corr

Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-08 Thread Roger Pau Monné
On Tue, Oct 08, 2019 at 03:32:25PM +0200, Jan Beulich wrote: > On 08.10.2019 15:14, Roger Pau Monné wrote: > > On Tue, Oct 08, 2019 at 01:28:49PM +0200, Jan Beulich wrote: > >> On 08.10.2019 13:09, Roger Pau Monné wrote: > >>> Given that as you correctly point out maskall is unset after device >

Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-08 Thread Jan Beulich
On 08.10.2019 15:14, Roger Pau Monné wrote: > On Tue, Oct 08, 2019 at 01:28:49PM +0200, Jan Beulich wrote: >> On 08.10.2019 13:09, Roger Pau Monné wrote: >>> Given that as you correctly point out maskall is unset after device >>> reset, I feel that option 4 is the best one since it matches the st

Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-08 Thread Roger Pau Monné
On Tue, Oct 08, 2019 at 01:28:49PM +0200, Jan Beulich wrote: > On 08.10.2019 13:09, Roger Pau Monné wrote: > > Given that as you correctly point out maskall is unset after device > > reset, I feel that option 4 is the best one since it matches the state > > of the hardware after reset. > > Right,

Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-08 Thread Jan Beulich
On 08.10.2019 13:09, Roger Pau Monné wrote: > On Tue, Oct 08, 2019 at 11:42:23AM +0200, Jan Beulich wrote: >> On 08.10.2019 11:23, Roger Pau Monné wrote: >>> On Wed, Oct 02, 2019 at 03:33:43PM +0200, Jan Beulich wrote: On 02.10.2019 12:49, Roger Pau Monne wrote: > The current implementat

Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-08 Thread Roger Pau Monné
On Tue, Oct 08, 2019 at 11:42:23AM +0200, Jan Beulich wrote: > On 08.10.2019 11:23, Roger Pau Monné wrote: > > On Wed, Oct 02, 2019 at 03:33:43PM +0200, Jan Beulich wrote: > >> On 02.10.2019 12:49, Roger Pau Monne wrote: > >>> The current implementation of host_maskall makes it sticky across > >>>

Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-08 Thread Jan Beulich
On 08.10.2019 11:23, Roger Pau Monné wrote: > On Wed, Oct 02, 2019 at 03:33:43PM +0200, Jan Beulich wrote: >> On 02.10.2019 12:49, Roger Pau Monne wrote: >>> The current implementation of host_maskall makes it sticky across >>> assign and deassign calls, which means that once a guest forces Xen to

Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-08 Thread Roger Pau Monné
On Wed, Oct 02, 2019 at 03:33:43PM +0200, Jan Beulich wrote: > On 02.10.2019 12:49, Roger Pau Monne wrote: > > The current implementation of host_maskall makes it sticky across > > assign and deassign calls, which means that once a guest forces Xen to > > set host_maskall the maskall bit is not goi

Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-07 Thread Chao Gao
On Mon, Oct 07, 2019 at 09:38:48AM +0200, Jan Beulich wrote: >On 05.10.2019 01:58, Chao Gao wrote: >> On Wed, Oct 02, 2019 at 12:49:35PM +0200, Roger Pau Monne wrote: >>> The current implementation of host_maskall makes it sticky across >>> assign and deassign calls, which means that once a guest f

Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-07 Thread Jan Beulich
On 05.10.2019 01:58, Chao Gao wrote: > On Wed, Oct 02, 2019 at 12:49:35PM +0200, Roger Pau Monne wrote: >> The current implementation of host_maskall makes it sticky across >> assign and deassign calls, which means that once a guest forces Xen to >> set host_maskall the maskall bit is not going to

Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-04 Thread Chao Gao
On Wed, Oct 02, 2019 at 12:49:35PM +0200, Roger Pau Monne wrote: >The current implementation of host_maskall makes it sticky across >assign and deassign calls, which means that once a guest forces Xen to >set host_maskall the maskall bit is not going to be cleared until a >call to PHYSDEVOP_prepare

Re: [Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-02 Thread Jan Beulich
On 02.10.2019 12:49, Roger Pau Monne wrote: > The current implementation of host_maskall makes it sticky across > assign and deassign calls, which means that once a guest forces Xen to > set host_maskall the maskall bit is not going to be cleared until a > call to PHYSDEVOP_prepare_msix is performe

[Xen-devel] [PATCH] pci: clear host_maskall field on assign

2019-10-02 Thread Roger Pau Monne
The current implementation of host_maskall makes it sticky across assign and deassign calls, which means that once a guest forces Xen to set host_maskall the maskall bit is not going to be cleared until a call to PHYSDEVOP_prepare_msix is performed. Such call however shouldn't be part of the normal