Re: [Xen-devel] [PATCH] libxl: fix build on rather old systems

2019-01-11 Thread Ian Jackson
Juergen Gross writes ("Re: [PATCH] libxl: fix build on rather old systems"): > On 11/01/2019 11:09, Jan Beulich wrote: > > CLONE_NEWIPC has been introduced in Linux 2.6.19 only (and into glibc > > at around that time as well). Cope with it being undefined as well as > > with the underlying kernel n

Re: [Xen-devel] [PATCH] libxl: fix build on rather old systems

2019-01-11 Thread Juergen Gross
On 11/01/2019 11:09, Jan Beulich wrote: > CLONE_NEWIPC has been introduced in Linux 2.6.19 only (and into glibc > at around that time as well). Cope with it being undefined as well as > with the underlying kernel not knowing of it. > > Signed-off-by: Jan Beulich Release-acked-by: Juergen Gross

Re: [Xen-devel] [PATCH] libxl: fix build on rather old systems

2019-01-11 Thread Jan Beulich
>>> On 11.01.19 at 13:06, wrote: >> On Jan 11, 2019, at 9:18 PM, Wei Liu wrote: >> On Fri, Jan 11, 2019 at 03:09:35AM -0700, Jan Beulich wrote: >>> CLONE_NEWIPC has been introduced in Linux 2.6.19 only (and into glibc >>> at around that time as well). Cope with it being undefined as well as >>> w

Re: [Xen-devel] [PATCH] libxl: fix build on rather old systems

2019-01-11 Thread Wei Liu
On Fri, Jan 11, 2019 at 03:09:35AM -0700, Jan Beulich wrote: > CLONE_NEWIPC has been introduced in Linux 2.6.19 only (and into glibc > at around that time as well). Cope with it being undefined as well as > with the underlying kernel not knowing of it. > > Signed-off-by: Jan Beulich Acked-by: We

Re: [Xen-devel] [PATCH] libxl: fix build on rather old systems

2019-01-11 Thread Wei Liu
On Fri, Jan 11, 2019 at 12:06:59PM +, George Dunlap wrote: > > > > On Jan 11, 2019, at 9:18 PM, Wei Liu wrote: > > > > On Fri, Jan 11, 2019 at 03:09:35AM -0700, Jan Beulich wrote: > >> CLONE_NEWIPC has been introduced in Linux 2.6.19 only (and into glibc > >> at around that time as well). C

Re: [Xen-devel] [PATCH] libxl: fix build on rather old systems

2019-01-11 Thread George Dunlap
> On Jan 11, 2019, at 9:18 PM, Wei Liu wrote: > > On Fri, Jan 11, 2019 at 03:09:35AM -0700, Jan Beulich wrote: >> CLONE_NEWIPC has been introduced in Linux 2.6.19 only (and into glibc >> at around that time as well). Cope with it being undefined as well as >> with the underlying kernel not know

Re: [Xen-devel] [PATCH] libxl: fix build on rather old systems

2019-01-11 Thread Wei Liu
On Fri, Jan 11, 2019 at 04:24:35AM -0700, Jan Beulich wrote: [...] > > > >> +#endif > >> +r = unshare(CLONE_NEWIPC); > >> +if (r) { > >> +if (r && errno != EINVAL) { > >> +LOGE(ERROR, "libxl: IPC namespace unshare failed"); > >> +return ERROR_FAIL; > >> +

Re: [Xen-devel] [PATCH] libxl: fix build on rather old systems

2019-01-11 Thread Jan Beulich
>>> On 11.01.19 at 12:18, wrote: > On Fri, Jan 11, 2019 at 03:09:35AM -0700, Jan Beulich wrote: >> CLONE_NEWIPC has been introduced in Linux 2.6.19 only (and into glibc >> at around that time as well). Cope with it being undefined as well as >> with the underlying kernel not knowing of it. >> >>

Re: [Xen-devel] [PATCH] libxl: fix build on rather old systems

2019-01-11 Thread Wei Liu
On Fri, Jan 11, 2019 at 03:09:35AM -0700, Jan Beulich wrote: > CLONE_NEWIPC has been introduced in Linux 2.6.19 only (and into glibc > at around that time as well). Cope with it being undefined as well as > with the underlying kernel not knowing of it. > > Signed-off-by: Jan Beulich > --- > Consi

[Xen-devel] [PATCH] libxl: fix build on rather old systems

2019-01-11 Thread Jan Beulich
CLONE_NEWIPC has been introduced in Linux 2.6.19 only (and into glibc at around that time as well). Cope with it being undefined as well as with the underlying kernel not knowing of it. Signed-off-by: Jan Beulich --- Considering how old "old" here really means, I could understand if this was reje