Andre,
Could you please comment on the patch and below.
On 20.11.18 13:09, Andrii Anisov wrote:
Hello Andre,
I'm going to change "gic_raise_guest_irq()" function interface.
Could you please comment my understanding of vgic-v3-its.c code below? So that
I could fix it alongside the function i
Hello Andre,
I'm going to change "gic_raise_guest_irq()" function interface.
Could you please comment my understanding of vgic-v3-its.c code below?
So that I could fix it alongside the function interface change.
On 16.11.18 18:45, Andrii Anisov wrote:
diff --git a/xen/arch/arm/vgic-v3-its.c
On 19.11.18 15:54, Julien Grall wrote:
You didn't get my point. You removed a parameter without explaining
why it is fine.
It is a pure optimization. If you look through the code, you can see
that callers of these functions already have a correspondent `struct
pending_irq` pointer. But they
Sorry for the formatting.
On Mon, 19 Nov 2018, 12:04 Andrii Anisov, wrote:
> Hello Julien,
>
>
> On 16.11.18 19:27, Julien Grall wrote:
> >> if ( !list_empty(&p->inflight) &&
> >>!test_bit(GIC_IRQ_GUEST_VISIBLE, &p->status) )
> >> -gic_raise_guest_irq(v, p->
Hello Julien,
On 16.11.18 19:27, Julien Grall wrote:
if ( !list_empty(&p->inflight) &&
!test_bit(GIC_IRQ_GUEST_VISIBLE, &p->status) )
- gic_raise_guest_irq(v, p->irq, p->lpi_priority);
+ gic_raise_guest_irq(v, p);
The interface is not behaving th
Hi Andrii,
On 16/11/2018 16:45, Andrii Anisov wrote:
From: Andrii Anisov
Avoid excessive conversions between pending_irq and irq number/priority.
This simlifies functions interface and reduces under locks code size.
Signed-off-by: Andrii Anisov
---
xen/arch/arm/gic-vgic.c| 10 +++--
From: Andrii Anisov
Avoid excessive conversions between pending_irq and irq number/priority.
This simlifies functions interface and reduces under locks code size.
Signed-off-by: Andrii Anisov
---
xen/arch/arm/gic-vgic.c| 10 +++---
xen/arch/arm/vgic-v3-its.c | 2 +-
xen/arch/arm/vgic.
