Re: [Xen-devel] [PATCH] fix uninitialized variable error in do_poll()

2018-10-05 Thread Jan Beulich
>>> On 05.10.18 at 13:43, wrote: > On 05/10/18 12:25, Wei Liu wrote: >> On Fri, Oct 05, 2018 at 05:22:29AM -0600, Jan Beulich wrote: >> On 05.10.18 at 12:28, wrote: On Fri, Oct 05, 2018 at 04:12:10AM -0600, Jan Beulich wrote: > Now that CONFIG_HVM can (and should) be turned off for t

Re: [Xen-devel] [PATCH] fix uninitialized variable error in do_poll()

2018-10-05 Thread Andrew Cooper
On 05/10/18 12:25, Wei Liu wrote: > On Fri, Oct 05, 2018 at 05:22:29AM -0600, Jan Beulich wrote: > On 05.10.18 at 12:28, wrote: >>> On Fri, Oct 05, 2018 at 04:12:10AM -0600, Jan Beulich wrote: Now that CONFIG_HVM can (and should) be turned off for the shim, gcc 8.2 apparently is no l

Re: [Xen-devel] [PATCH] fix uninitialized variable error in do_poll()

2018-10-05 Thread Wei Liu
On Fri, Oct 05, 2018 at 05:22:29AM -0600, Jan Beulich wrote: > >>> On 05.10.18 at 12:28, wrote: > > On Fri, Oct 05, 2018 at 04:12:10AM -0600, Jan Beulich wrote: > >> Now that CONFIG_HVM can (and should) be turned off for the shim, gcc 8.2 > >> apparently is no longer sure that "port" is indeed ini

Re: [Xen-devel] [PATCH] fix uninitialized variable error in do_poll()

2018-10-05 Thread Jan Beulich
>>> On 05.10.18 at 12:28, wrote: > On Fri, Oct 05, 2018 at 04:12:10AM -0600, Jan Beulich wrote: >> Now that CONFIG_HVM can (and should) be turned off for the shim, gcc 8.2 >> apparently is no longer sure that "port" is indeed initialized at >> >> if ( sched_poll->nr_ports == 1 ) >> v-

Re: [Xen-devel] [PATCH] fix uninitialized variable error in do_poll()

2018-10-05 Thread Wei Liu
On Fri, Oct 05, 2018 at 04:12:10AM -0600, Jan Beulich wrote: > Now that CONFIG_HVM can (and should) be turned off for the shim, gcc 8.2 > apparently is no longer sure that "port" is indeed initialized at > > if ( sched_poll->nr_ports == 1 ) > v->poll_evtchn = port; > > It doesn't look

[Xen-devel] [PATCH] fix uninitialized variable error in do_poll()

2018-10-05 Thread Jan Beulich
Now that CONFIG_HVM can (and should) be turned off for the shim, gcc 8.2 apparently is no longer sure that "port" is indeed initialized at if ( sched_poll->nr_ports == 1 ) v->poll_evtchn = port; It doesn't look to be impossible for the compiler to prove it is not, but we also can't re