Re: [Xen-devel] [PATCH] fix potential null dereference

2018-01-18 Thread Stefano Stabellini
On Thu, 18 Jan 2018, Andrew Cooper wrote: > On 18/01/2018 22:11, Stefano Stabellini wrote: > > On Tue, 16 Jan 2018, Jan Beulich wrote: > > On 15.01.18 at 19:51, wrote: > >>> On Mon, 15 Jan 2018, Jan Beulich wrote: > >>> On 13.01.18 at 07:21, wrote: > > On 01/12/2018 11:40 PM, Stefano

Re: [Xen-devel] [PATCH] fix potential null dereference

2018-01-18 Thread Andrew Cooper
On 18/01/2018 22:11, Stefano Stabellini wrote: > On Tue, 16 Jan 2018, Jan Beulich wrote: > On 15.01.18 at 19:51, wrote: >>> On Mon, 15 Jan 2018, Jan Beulich wrote: >>> On 13.01.18 at 07:21, wrote: > On 01/12/2018 11:40 PM, Stefano Stabellini wrote: >> handles can theoretically be

Re: [Xen-devel] [PATCH] fix potential null dereference

2018-01-18 Thread Stefano Stabellini
On Tue, 16 Jan 2018, Jan Beulich wrote: > >>> On 15.01.18 at 19:51, wrote: > > On Mon, 15 Jan 2018, Jan Beulich wrote: > >> >>> On 13.01.18 at 07:21, wrote: > >> > On 01/12/2018 11:40 PM, Stefano Stabellini wrote: > >> >> handles can theoretically be NULL, check for it explicitly before > >> >> d

Re: [Xen-devel] [PATCH] fix potential null dereference

2018-01-15 Thread Jan Beulich
>>> On 15.01.18 at 19:51, wrote: > On Mon, 15 Jan 2018, Jan Beulich wrote: >> >>> On 13.01.18 at 07:21, wrote: >> > On 01/12/2018 11:40 PM, Stefano Stabellini wrote: >> >> handles can theoretically be NULL, check for it explicitly before >> >> dereferencing it. >> > >> > I doubt handles could be

Re: [Xen-devel] [PATCH] fix potential null dereference

2018-01-15 Thread Julien Grall
Hi Stefano, On 15 Jan 2018 19:51, "Stefano Stabellini" wrote: On Mon, 15 Jan 2018, Jan Beulich wrote: > >>> On 13.01.18 at 07:21, wrote: > > On 01/12/2018 11:40 PM, Stefano Stabellini wrote: > >> handles can theoretically be NULL, check for it explicitly before > >> dereferencing it. > > > > I

Re: [Xen-devel] [PATCH] fix potential null dereference

2018-01-15 Thread Stefano Stabellini
On Mon, 15 Jan 2018, Jan Beulich wrote: > >>> On 13.01.18 at 07:21, wrote: > > On 01/12/2018 11:40 PM, Stefano Stabellini wrote: > >> handles can theoretically be NULL, check for it explicitly before > >> dereferencing it. > > > > I doubt handles could be NULL if LocateHandle succeed. This seems

Re: [Xen-devel] [PATCH] fix potential null dereference

2018-01-15 Thread Jan Beulich
>>> On 13.01.18 at 07:21, wrote: > On 01/12/2018 11:40 PM, Stefano Stabellini wrote: >> handles can theoretically be NULL, check for it explicitly before >> dereferencing it. > > I doubt handles could be NULL if LocateHandle succeed. This seems to be > confirmed by the spec (Page 208 in UEFI spe

Re: [Xen-devel] [PATCH] fix potential null dereference

2018-01-12 Thread Julien Grall
(CC the REST maintainers) On 01/12/2018 11:40 PM, Stefano Stabellini wrote: handles can theoretically be NULL, check for it explicitly before dereferencing it. I doubt handles could be NULL if LocateHandle succeed. This seems to be confirmed by the spec (Page 208 in UEFI spec 2.7). So I am

[Xen-devel] [PATCH] fix potential null dereference

2018-01-12 Thread Stefano Stabellini
handles can theoretically be NULL, check for it explicitly before dereferencing it. CID: 1381838 Signed-off-by: Stefano Stabellini diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 469bf98..431fe2e 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -729,7 +729,7 @@