Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

2019-12-09 Thread Jan Beulich
On 09.12.2019 15:06, George Dunlap wrote: > On 12/6/19 4:42 PM, Jan Beulich wrote: >> On 06.12.2019 17:20, Julien Grall wrote: >>> Hi, >>> >>> On 06/12/2019 16:06, Jan Beulich wrote: On 06.12.2019 15:46, Julien Grall wrote: > On 05/12/2019 16:50, Jan Beulich wrote: >> On 05.12.2019 17:

Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

2019-12-09 Thread George Dunlap
On 12/6/19 4:42 PM, Jan Beulich wrote: > On 06.12.2019 17:20, Julien Grall wrote: >> Hi, >> >> On 06/12/2019 16:06, Jan Beulich wrote: >>> On 06.12.2019 15:46, Julien Grall wrote: On 05/12/2019 16:50, Jan Beulich wrote: > On 05.12.2019 17:27, Julien Grall wrote: >> On 05/12/2019 15:33,

Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

2019-12-06 Thread Julien Grall
Hi Jan, On 06/12/2019 16:42, Jan Beulich wrote: On 06.12.2019 17:20, Julien Grall wrote: Hi, On 06/12/2019 16:06, Jan Beulich wrote: On 06.12.2019 15:46, Julien Grall wrote: On 05/12/2019 16:50, Jan Beulich wrote: On 05.12.2019 17:27, Julien Grall wrote: On 05/12/2019 15:33, Jan Beulich wr

Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

2019-12-06 Thread Jan Beulich
On 06.12.2019 17:20, Julien Grall wrote: > Hi, > > On 06/12/2019 16:06, Jan Beulich wrote: >> On 06.12.2019 15:46, Julien Grall wrote: >>> On 05/12/2019 16:50, Jan Beulich wrote: On 05.12.2019 17:27, Julien Grall wrote: > On 05/12/2019 15:33, Jan Beulich wrote: >> +/* >> + * Strin

Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

2019-12-06 Thread Julien Grall
Hi, On 06/12/2019 16:06, Jan Beulich wrote: On 06.12.2019 15:46, Julien Grall wrote: On 05/12/2019 16:50, Jan Beulich wrote: On 05.12.2019 17:27, Julien Grall wrote: On 05/12/2019 15:33, Jan Beulich wrote: +/* + * String comparison functions mostly matching strcmp() / strncmp(), + * except t

Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

2019-12-06 Thread Jan Beulich
On 06.12.2019 15:46, Julien Grall wrote: > On 05/12/2019 16:50, Jan Beulich wrote: >> On 05.12.2019 17:27, Julien Grall wrote: >>> On 05/12/2019 15:33, Jan Beulich wrote: +/* + * String comparison functions mostly matching strcmp() / strncmp(), + * except that they treat '-' and '_'

Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

2019-12-06 Thread George Dunlap
On 12/6/19 2:46 PM, Julien Grall wrote: > Hi Jan, > > On 05/12/2019 16:50, Jan Beulich wrote: >> On 05.12.2019 17:27, Julien Grall wrote: >>> On 05/12/2019 15:33, Jan Beulich wrote: --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -23,6 +23,49 @@ enum system_state system_state

Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

2019-12-06 Thread Julien Grall
Hi Jan, On 05/12/2019 16:50, Jan Beulich wrote: On 05.12.2019 17:27, Julien Grall wrote: On 05/12/2019 15:33, Jan Beulich wrote: --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -23,6 +23,49 @@ enum system_state system_state = SYS_STA xen_commandline_t saved_cmdline; static const c

Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

2019-12-05 Thread Jan Beulich
On 05.12.2019 17:27, Julien Grall wrote: > On 05/12/2019 15:33, Jan Beulich wrote: >> --- a/xen/common/kernel.c >> +++ b/xen/common/kernel.c >> @@ -23,6 +23,49 @@ enum system_state system_state = SYS_STA >> xen_commandline_t saved_cmdline; >> static const char __initconst opt_builtin_cmdline[]

Re: [Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

2019-12-05 Thread Julien Grall
Hi, On 05/12/2019 15:33, Jan Beulich wrote: In order to avoid permanently having to ask that no new command line options using underscores be introduced (albeit I'm likely to still make remarks), and in order to also allow extending the use of hyphens to pre-existing ones, introduce custom compa

[Xen-devel] [PATCH] cmdline: treat hyphens and underscores the same

2019-12-05 Thread Jan Beulich
In order to avoid permanently having to ask that no new command line options using underscores be introduced (albeit I'm likely to still make remarks), and in order to also allow extending the use of hyphens to pre-existing ones, introduce custom comparison functions treating both characters as mat