Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 27 November 2018 15:50 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenproject.org> > Subject: RE: [Xen-devel] [PATCH] amd-iommu: remove page

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Jan Beulich
ect.org> >> Subject: Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code >> >> >>> On 26.11.18 at 18:30, wrote: >> > The page merging logic makes use of bits 1-8 and bit 63 of a PTE, which >> used >> > to be specified as ignored. However,

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Jan Beulich
ect.org> >> Subject: Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code >> >> >>> On 26.11.18 at 18:30, wrote: >> > The page merging logic makes use of bits 1-8 and bit 63 of a PTE, which >> used >> > to be specified as ignored. However,

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Jan Beulich
>>> On 27.11.18 at 15:19, wrote: > On 27/11/2018 13:06, Jan Beulich wrote: > On 26.11.18 at 18:30, wrote: >>> The page merging logic makes use of bits 1-8 and bit 63 of a PTE, which used >>> to be specified as ignored. However, bits 5 and 6 are now specified as >>> 'accessed' and 'dirty' bits

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 27 November 2018 14:19 > To: Jan Beulich ; Paul Durrant > > Cc: xen-devel ; Brian Woods > ; Suravee Suthikulpanit > > Subject: Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code > > On 27

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 27 November 2018 13:07 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenproject.org> > Subject: Re: [Xen-devel] [PATCH] amd-iommu: remove page

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Andrew Cooper
On 27/11/2018 13:06, Jan Beulich wrote: On 26.11.18 at 18:30, wrote: >> The page merging logic makes use of bits 1-8 and bit 63 of a PTE, which used >> to be specified as ignored. However, bits 5 and 6 are now specified as >> 'accessed' and 'dirty' bits and their use only remains safe as long

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 27 November 2018 13:02 > To: Paul Durrant > Cc: Brian Woods ; Suravee Suthikulpanit > ; xen-devel de...@lists.xenproject.org> > Subject: Re: [Xen-devel] [PATCH] amd-iommu: remove page

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Jan Beulich
>>> On 26.11.18 at 18:30, wrote: > The page merging logic makes use of bits 1-8 and bit 63 of a PTE, which used > to be specified as ignored. However, bits 5 and 6 are now specified as > 'accessed' and 'dirty' bits and their use only remains safe as long as > the DTE 'Host Access Dirty' bits remai

Re: [Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-27 Thread Jan Beulich
>>> On 26.11.18 at 18:30, wrote: > The page merging logic makes use of bits 1-8 and bit 63 of a PTE, which used > to be specified as ignored. However, bits 5 and 6 are now specified as > 'accessed' and 'dirty' bits and their use only remains safe as long as > the DTE 'Host Access Dirty' bits remai

[Xen-devel] [PATCH] amd-iommu: remove page merging code

2018-11-26 Thread Paul Durrant
The page merging logic makes use of bits 1-8 and bit 63 of a PTE, which used to be specified as ignored. However, bits 5 and 6 are now specified as 'accessed' and 'dirty' bits and their use only remains safe as long as the DTE 'Host Access Dirty' bits remain clear. The code is also of dubious benef