Re: [XEN v8 1/5] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64

2023-06-16 Thread Julien Grall
On 16/06/2023 08:59, Michal Orzel wrote: Hi Julien, On 15/06/2023 22:32, Julien Grall wrote: Hi Michal, I notice you posted some comments but didn't add a Acked-by/Reviewed-by. Can you indicate if you are happy with the patch so long your comments are addressed? If so, are you OK if I de

Re: [XEN v8 1/5] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64

2023-06-16 Thread Julien Grall
Hi, On 15/06/2023 09:05, Michal Orzel wrote: /* * Restrict "p2m_ipa_bits" if needed. As P2M table is always configured * with IPA bits == PA bits, compare against "pabits". @@ -2291,6 +2299,7 @@ void __init setup_virt_paging(void) */ if ( system_cpuinfo.mm64.vmid

Re: [XEN v8 1/5] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64

2023-06-16 Thread Michal Orzel
Hi Julien, On 15/06/2023 22:32, Julien Grall wrote: > > > Hi Michal, > > I notice you posted some comments but didn't add a Acked-by/Reviewed-by. > Can you indicate if you are happy with the patch so long your comments > are addressed? > > If so, are you OK if I deal with them on commit? I tho

Re: [XEN v8 1/5] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64

2023-06-15 Thread Julien Grall
Hi Michal, I notice you posted some comments but didn't add a Acked-by/Reviewed-by. Can you indicate if you are happy with the patch so long your comments are addressed? If so, are you OK if I deal with them on commit? Cheers, -- Julien Grall

Re: [XEN v8 1/5] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64

2023-06-15 Thread Ayan Kumar Halder
On 15/06/2023 10:40, Julien Grall wrote: Hi Ayan, Hi Julien, On 15/06/2023 10:29, Ayan Kumar Halder wrote: On 15/06/2023 09:05, Michal Orzel wrote: Hi Ayan, Hi Michal, On 02/06/2023 14:07, Ayan Kumar Halder wrote: Restructure the code so that one can use pa_range_info[] table for bo

Re: [XEN v8 1/5] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64

2023-06-15 Thread Julien Grall
Hi Ayan, On 15/06/2023 10:29, Ayan Kumar Halder wrote: On 15/06/2023 09:05, Michal Orzel wrote: Hi Ayan, Hi Michal, On 02/06/2023 14:07, Ayan Kumar Halder wrote: Restructure the code so that one can use pa_range_info[] table for both ARM_32 as well as ARM_64. I grepped for ARM_{32,64} in

Re: [XEN v8 1/5] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64

2023-06-15 Thread Ayan Kumar Halder
On 15/06/2023 09:05, Michal Orzel wrote: Hi Ayan, Hi Michal, On 02/06/2023 14:07, Ayan Kumar Halder wrote: Restructure the code so that one can use pa_range_info[] table for both ARM_32 as well as ARM_64. I grepped for ARM_{32,64} in our code base and could not find any use in source fil

Re: [XEN v8 1/5] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64

2023-06-15 Thread Michal Orzel
Hi Ayan, On 02/06/2023 14:07, Ayan Kumar Halder wrote: > > > Restructure the code so that one can use pa_range_info[] table for both > ARM_32 as well as ARM_64. I grepped for ARM_{32,64} in our code base and could not find any use in source files except for things introduced by this commit. Whi

[XEN v8 1/5] xen/arm: p2m: Use the pa_range_info table to support ARM_32 and ARM_64

2023-06-02 Thread Ayan Kumar Halder
Restructure the code so that one can use pa_range_info[] table for both ARM_32 as well as ARM_64. Also, removed the hardcoding for P2M_ROOT_ORDER and P2M_ROOT_LEVEL as p2m_root_order can be obtained from the pa_range_info[].root_order and p2m_root_level can be obtained from pa_range_info[].sl0. R