Re: [XEN PATCH v3 07/12] x86/hvm: address violations of MISRA C Rule 16.3

2024-07-15 Thread Federico Serafini
On 13/07/24 01:25, Stefano Stabellini wrote: On Tue, 2 Jul 2024, Federico Serafini wrote: On 01/07/24 10:47, Jan Beulich wrote: On 26.06.2024 11:28, Federico Serafini wrote: @@ -2798,11 +2800,12 @@ void hvm_emulate_one_vm_event(enum emul_kind kind, unsigned int trapnr, hvio->mmio_in

Re: [XEN PATCH v3 07/12] x86/hvm: address violations of MISRA C Rule 16.3

2024-07-12 Thread Stefano Stabellini
On Tue, 2 Jul 2024, Federico Serafini wrote: > On 01/07/24 10:47, Jan Beulich wrote: > > On 26.06.2024 11:28, Federico Serafini wrote: > > > @@ -2798,11 +2800,12 @@ void hvm_emulate_one_vm_event(enum emul_kind kind, > > > unsigned int trapnr, > > > hvio->mmio_insn_bytes = sizeof(hvio->mmi

Re: [XEN PATCH v3 07/12] x86/hvm: address violations of MISRA C Rule 16.3

2024-07-02 Thread Federico Serafini
On 01/07/24 10:47, Jan Beulich wrote: On 26.06.2024 11:28, Federico Serafini wrote: @@ -2798,11 +2800,12 @@ void hvm_emulate_one_vm_event(enum emul_kind kind, unsigned int trapnr, hvio->mmio_insn_bytes = sizeof(hvio->mmio_insn); memcpy(hvio->mmio_insn, curr->arch.vm_event->e

Re: [XEN PATCH v3 07/12] x86/hvm: address violations of MISRA C Rule 16.3

2024-07-01 Thread Jan Beulich
On 26.06.2024 11:28, Federico Serafini wrote: > @@ -2798,11 +2800,12 @@ void hvm_emulate_one_vm_event(enum emul_kind kind, > unsigned int trapnr, > hvio->mmio_insn_bytes = sizeof(hvio->mmio_insn); > memcpy(hvio->mmio_insn, curr->arch.vm_event->emul.insn.data, > hv

Re: [XEN PATCH v3 07/12] x86/hvm: address violations of MISRA C Rule 16.3

2024-06-26 Thread Stefano Stabellini
On Wed, 26 Jun 2024, Federico Serafini wrote: > MISRA C Rule 16.3 states that "An unconditional `break' statement shall > terminate every switch-clause". > > Add pseudo keyword fallthrough or missing break statement > to address violations of the rule. > > As a defensive measure, return -EOPNOTSU

[XEN PATCH v3 07/12] x86/hvm: address violations of MISRA C Rule 16.3

2024-06-26 Thread Federico Serafini
MISRA C Rule 16.3 states that "An unconditional `break' statement shall terminate every switch-clause". Add pseudo keyword fallthrough or missing break statement to address violations of the rule. As a defensive measure, return -EOPNOTSUPP in case an unreachable return statement is reached. Sign