Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-23 Thread Nicola Vetrini
On 2023-11-23 12:36, Jan Beulich wrote: On 23.11.2023 12:30, Nicola Vetrini wrote: I guess this one as well should remain as is. Can you confirm? void asmlinkage __stdcall cmdline_parse_early(const char *cmdline, early_boot_opts_t *ebo) Indeed,

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-23 Thread Jan Beulich
On 23.11.2023 12:30, Nicola Vetrini wrote: > I guess this one as well should remain as is. Can you confirm? > > void asmlinkage __stdcall cmdline_parse_early(const char *cmdline, >early_boot_opts_t *ebo) > Indeed, I simply overlooked it. Jan

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-23 Thread Nicola Vetrini
I guess this one as well should remain as is. Can you confirm? void asmlinkage __stdcall cmdline_parse_early(const char *cmdline, early_boot_opts_t *ebo) -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-23 Thread Julien Grall
Hi Nicola, On 23/11/2023 10:40, Nicola Vetrini wrote: On 2023-11-23 11:26, Julien Grall wrote: Hi Nicola, On 23/11/2023 09:25, Nicola Vetrini wrote: On 2023-11-23 09:57, Jan Beulich wrote: On 16.11.2023 10:08, Nicola Vetrini wrote: The comment-based justifications for MISRA C:2012 Rule 8.4 a

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-23 Thread Nicola Vetrini
On 2023-11-23 11:26, Julien Grall wrote: Hi Nicola, On 23/11/2023 09:25, Nicola Vetrini wrote: On 2023-11-23 09:57, Jan Beulich wrote: On 16.11.2023 10:08, Nicola Vetrini wrote: The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced by the asmlinkage pseudo-attribute, for th

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-23 Thread Jan Beulich
On 23.11.2023 11:26, Julien Grall wrote: > Another possibility would be to deviate __stdcall like we do for > asmlinkage (I will let Jan confirm if this is desirable). With this > approach, there is less ambiguity when to use either of them. Attributes changing calling convention may be a sign o

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-23 Thread Julien Grall
Hi Nicola, On 23/11/2023 09:25, Nicola Vetrini wrote: On 2023-11-23 09:57, Jan Beulich wrote: On 16.11.2023 10:08, Nicola Vetrini wrote: The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced by the asmlinkage pseudo-attribute, for the sake of uniformity. Add missing 'xen/com

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-23 Thread Nicola Vetrini
On 2023-11-23 09:57, Jan Beulich wrote: On 16.11.2023 10:08, Nicola Vetrini wrote: The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced by the asmlinkage pseudo-attribute, for the sake of uniformity. Add missing 'xen/compiler.h' #include-s where needed. The text in docs/mis

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-23 Thread Jan Beulich
On 16.11.2023 10:08, Nicola Vetrini wrote: > The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced > by the asmlinkage pseudo-attribute, for the sake of uniformity. > > Add missing 'xen/compiler.h' #include-s where needed. > > The text in docs/misra/deviations.rst and docs/misra

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-21 Thread Nicola Vetrini
On 2023-11-21 11:18, Jan Beulich wrote: On 21.11.2023 10:46, Nicola Vetrini wrote: On 2023-11-21 10:16, Jan Beulich wrote: On 16.11.2023 10:08, Nicola Vetrini wrote: The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced by the asmlinkage pseudo-attribute, for the sake of unif

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-21 Thread Jan Beulich
On 21.11.2023 10:46, Nicola Vetrini wrote: > On 2023-11-21 10:16, Jan Beulich wrote: >> On 16.11.2023 10:08, Nicola Vetrini wrote: >>> The comment-based justifications for MISRA C:2012 Rule 8.4 are >>> replaced >>> by the asmlinkage pseudo-attribute, for the sake of uniformity. >>> >>> Add missing

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-21 Thread Nicola Vetrini
On 2023-11-21 10:16, Jan Beulich wrote: On 16.11.2023 10:08, Nicola Vetrini wrote: The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced by the asmlinkage pseudo-attribute, for the sake of uniformity. Add missing 'xen/compiler.h' #include-s where needed. The text in docs/mis

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-21 Thread Jan Beulich
On 16.11.2023 10:08, Nicola Vetrini wrote: > The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced > by the asmlinkage pseudo-attribute, for the sake of uniformity. > > Add missing 'xen/compiler.h' #include-s where needed. > > The text in docs/misra/deviations.rst and docs/misra

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-21 Thread Nicola Vetrini
On 2023-11-20 11:27, Julien Grall wrote: Hi Nicola, On 20/11/2023 08:39, Nicola Vetrini wrote: On 2023-11-17 20:15, Julien Grall wrote: Hi Nicola, On 16/11/2023 09:15, Nicola Vetrini wrote: On 2023-11-16 10:08, Nicola Vetrini wrote: The comment-based justifications for MISRA C:2012 Rule 8.4

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-20 Thread Julien Grall
Hi Nicola, On 20/11/2023 08:39, Nicola Vetrini wrote: On 2023-11-17 20:15, Julien Grall wrote: Hi Nicola, On 16/11/2023 09:15, Nicola Vetrini wrote: On 2023-11-16 10:08, Nicola Vetrini wrote: The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced by the asmlinkage pseudo-att

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-20 Thread Julien Grall
Hi Stefano, On 18/11/2023 02:47, Stefano Stabellini wrote: On Fri, 17 Nov 2023, Julien Grall wrote: On 16/11/2023 09:15, Nicola Vetrini wrote: On 2023-11-16 10:08, Nicola Vetrini wrote: The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced by the asmlinkage pseudo-attribute,

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-20 Thread Jan Beulich
On 20.11.2023 09:39, Nicola Vetrini wrote: > I do have a folder with all my in-flight patches. Please note that this > big backlog has partly been the result of patches being acked, but not > committed. Which in turn is a result of there having been too many patches while the tree was closed. Ye

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-20 Thread Nicola Vetrini
On 2023-11-17 20:15, Julien Grall wrote: Hi Nicola, On 16/11/2023 09:15, Nicola Vetrini wrote: On 2023-11-16 10:08, Nicola Vetrini wrote: The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced by the asmlinkage pseudo-attribute, for the sake of uniformity. Add missing 'xen/c

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-17 Thread Stefano Stabellini
On Fri, 17 Nov 2023, Julien Grall wrote: > On 16/11/2023 09:15, Nicola Vetrini wrote: > > On 2023-11-16 10:08, Nicola Vetrini wrote: > > > The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced > > > by the asmlinkage pseudo-attribute, for the sake of uniformity. > > > > > > Add m

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-17 Thread Julien Grall
Hi Nicola, On 16/11/2023 09:15, Nicola Vetrini wrote: On 2023-11-16 10:08, Nicola Vetrini wrote: The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced by the asmlinkage pseudo-attribute, for the sake of uniformity. Add missing 'xen/compiler.h' #include-s where needed. The te

Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-16 Thread Nicola Vetrini
On 2023-11-16 10:08, Nicola Vetrini wrote: The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced by the asmlinkage pseudo-attribute, for the sake of uniformity. Add missing 'xen/compiler.h' #include-s where needed. The text in docs/misra/deviations.rst and docs/misra/safe.json

[XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-16 Thread Nicola Vetrini
The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced by the asmlinkage pseudo-attribute, for the sake of uniformity. Add missing 'xen/compiler.h' #include-s where needed. The text in docs/misra/deviations.rst and docs/misra/safe.json is modified to reflect this change. Signed-