Re: [XEN PATCH v2 3/3] xen: address violations of MISRA C:2012 Rule 13.1

2023-12-03 Thread Jan Beulich
On 02.12.2023 04:22, Stefano Stabellini wrote: > On Mon, 27 Nov 2023, Jan Beulich wrote: >> On 24.11.2023 18:29, Simone Ballarin wrote: >>> Rule 13.1: Initializer lists shall not contain persistent side effects >>> >>> The assignment operation in: >>> >>> .irq = rc = uart->irq, >>> >>> is a persist

Re: [XEN PATCH v2 3/3] xen: address violations of MISRA C:2012 Rule 13.1

2023-12-01 Thread Stefano Stabellini
On Mon, 27 Nov 2023, Jan Beulich wrote: > On 24.11.2023 18:29, Simone Ballarin wrote: > > Rule 13.1: Initializer lists shall not contain persistent side effects > > > > The assignment operation in: > > > > .irq = rc = uart->irq, > > > > is a persistent side effect in a struct initializer list. >

Re: [XEN PATCH v2 3/3] xen: address violations of MISRA C:2012 Rule 13.1

2023-11-27 Thread Jan Beulich
On 24.11.2023 18:29, Simone Ballarin wrote: > Rule 13.1: Initializer lists shall not contain persistent side effects > > The assignment operation in: > > .irq = rc = uart->irq, > > is a persistent side effect in a struct initializer list. > > This patch avoids rc assignment and directly uses ua

[XEN PATCH v2 3/3] xen: address violations of MISRA C:2012 Rule 13.1

2023-11-24 Thread Simone Ballarin
Rule 13.1: Initializer lists shall not contain persistent side effects The assignment operation in: .irq = rc = uart->irq, is a persistent side effect in a struct initializer list. This patch avoids rc assignment and directly uses uart->irq in the following if statement. No functional changes.