Re: [XEN PATCH v2] x86: make function declarations consistent with definitions

2023-07-13 Thread Jan Beulich
On 13.07.2023 15:43, Federico Serafini wrote: > > > On 04/07/23 16:51, Jan Beulich wrote: >> On top of my earlier remark (when this was part of a series): >> >>> --- a/xen/arch/x86/cpu/mcheck/x86_mca.h >>> +++ b/xen/arch/x86/cpu/mcheck/x86_mca.h >>> @@ -113,7 +113,7 @@ static inline int mcabanks_

Re: [XEN PATCH v2] x86: make function declarations consistent with definitions

2023-07-13 Thread Federico Serafini
On 04/07/23 16:51, Jan Beulich wrote: On top of my earlier remark (when this was part of a series): --- a/xen/arch/x86/cpu/mcheck/x86_mca.h +++ b/xen/arch/x86/cpu/mcheck/x86_mca.h @@ -113,7 +113,7 @@ static inline int mcabanks_test(int bit, struct mca_banks* banks) return test_bit(bit

Re: [XEN PATCH v2] x86: make function declarations consistent with definitions

2023-07-09 Thread Jan Beulich
On 07.07.2023 23:28, Stefano Stabellini wrote: > On Fri, 7 Jul 2023, Jan Beulich wrote: >> On 07.07.2023 00:29, Stefano Stabellini wrote: >>> On Thu, 6 Jul 2023, Jan Beulich wrote: On 06.07.2023 01:22, Stefano Stabellini wrote: > On Tue, 4 Jul 2023, Jan Beulich wrote: >> On 04.07.2023

Re: [XEN PATCH v2] x86: make function declarations consistent with definitions

2023-07-07 Thread Stefano Stabellini
On Fri, 7 Jul 2023, Jan Beulich wrote: > On 07.07.2023 00:29, Stefano Stabellini wrote: > > On Thu, 6 Jul 2023, Jan Beulich wrote: > >> On 06.07.2023 01:22, Stefano Stabellini wrote: > >>> On Tue, 4 Jul 2023, Jan Beulich wrote: > On 04.07.2023 12:23, Federico Serafini wrote: > > Change mec

Re: [XEN PATCH v2] x86: make function declarations consistent with definitions

2023-07-06 Thread Jan Beulich
On 07.07.2023 00:29, Stefano Stabellini wrote: > On Thu, 6 Jul 2023, Jan Beulich wrote: >> On 06.07.2023 01:22, Stefano Stabellini wrote: >>> On Tue, 4 Jul 2023, Jan Beulich wrote: On 04.07.2023 12:23, Federico Serafini wrote: > Change mechanically the parameter names and types of function

Re: [XEN PATCH v2] x86: make function declarations consistent with definitions

2023-07-06 Thread Stefano Stabellini
On Thu, 6 Jul 2023, Jan Beulich wrote: > On 06.07.2023 01:22, Stefano Stabellini wrote: > > On Tue, 4 Jul 2023, Jan Beulich wrote: > >> On 04.07.2023 12:23, Federico Serafini wrote: > >>> Change mechanically the parameter names and types of function > >>> declarations to be consistent with the ones

Re: [XEN PATCH v2] x86: make function declarations consistent with definitions

2023-07-05 Thread Jan Beulich
On 06.07.2023 01:22, Stefano Stabellini wrote: > On Tue, 4 Jul 2023, Jan Beulich wrote: >> On 04.07.2023 12:23, Federico Serafini wrote: >>> Change mechanically the parameter names and types of function >>> declarations to be consistent with the ones used in the corresponding >>> definitions so as

Re: [XEN PATCH v2] x86: make function declarations consistent with definitions

2023-07-05 Thread Stefano Stabellini
On Tue, 4 Jul 2023, Jan Beulich wrote: > On 04.07.2023 12:23, Federico Serafini wrote: > > Change mechanically the parameter names and types of function > > declarations to be consistent with the ones used in the corresponding > > definitions so as to fix violations of MISRA C:2012 Rule 8.3 ("All >

Re: [XEN PATCH v2] x86: make function declarations consistent with definitions

2023-07-04 Thread Jan Beulich
On 04.07.2023 12:23, Federico Serafini wrote: > Change mechanically the parameter names and types of function > declarations to be consistent with the ones used in the corresponding > definitions so as to fix violations of MISRA C:2012 Rule 8.3 ("All > declarations of an object or function shall us

[XEN PATCH v2] x86: make function declarations consistent with definitions

2023-07-04 Thread Federico Serafini
Change mechanically the parameter names and types of function declarations to be consistent with the ones used in the corresponding definitions so as to fix violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers") and MISRA C:201