Re: [XEN PATCH v2] x86/hvm: Use constants for x86 modes

2024-12-18 Thread Andrew Cooper
On 18/12/2024 3:54 pm, Andrew Cooper wrote: > On 02/12/2024 9:49 am, Teddy Astie wrote: >> diff --git a/xen/arch/x86/include/asm/hvm/hvm.h >> b/xen/arch/x86/include/asm/hvm/hvm.h >> index 02de18c7d4..dbc37e8b75 100644 >> --- a/xen/arch/x86/include/asm/hvm/hvm.h >> +++ b/xen/arch/x86/include/asm/hv

Re: [XEN PATCH v2] x86/hvm: Use constants for x86 modes

2024-12-18 Thread Andrew Cooper
On 18/12/2024 3:54 pm, Andrew Cooper wrote: > On 02/12/2024 9:49 am, Teddy Astie wrote: >> diff --git a/xen/arch/x86/include/asm/hvm/hvm.h >> b/xen/arch/x86/include/asm/hvm/hvm.h >> index 02de18c7d4..dbc37e8b75 100644 >> --- a/xen/arch/x86/include/asm/hvm/hvm.h >> +++ b/xen/arch/x86/include/asm/hv

Re: [XEN PATCH v2] x86/hvm: Use constants for x86 modes

2024-12-18 Thread Andrew Cooper
On 02/12/2024 9:49 am, Teddy Astie wrote: > diff --git a/xen/arch/x86/include/asm/hvm/hvm.h > b/xen/arch/x86/include/asm/hvm/hvm.h > index 02de18c7d4..dbc37e8b75 100644 > --- a/xen/arch/x86/include/asm/hvm/hvm.h > +++ b/xen/arch/x86/include/asm/hvm/hvm.h > @@ -26,6 +26,12 @@ extern bool opt_hvm_fe

Re: [XEN PATCH v2] x86/hvm: Use constants for x86 modes

2024-12-05 Thread Teddy Astie
Hello, Le 04/12/2024 à 14:01, Andrew Cooper a écrit : > On 02/12/2024 9:49 am, Teddy Astie wrote: >> In many places of x86 HVM code, constants integer are used to indicate in >> what mode is >> running the CPU (real, vm86, 16-bits, 32-bits, 64-bits). However, these >> constants are >> are writte

Re: [XEN PATCH v2] x86/hvm: Use constants for x86 modes

2024-12-04 Thread Andrew Cooper
On 02/12/2024 9:49 am, Teddy Astie wrote: > In many places of x86 HVM code, constants integer are used to indicate in > what mode is > running the CPU (real, vm86, 16-bits, 32-bits, 64-bits). However, these > constants are > are written directly as integer which hides the actual meaning of these

Re: [XEN PATCH v2] x86/hvm: Use constants for x86 modes

2024-12-04 Thread Jan Beulich
On 02.12.2024 10:49, Teddy Astie wrote: > In many places of x86 HVM code, constants integer are used to indicate in > what mode is > running the CPU (real, vm86, 16-bits, 32-bits, 64-bits). However, these > constants are > are written directly as integer which hides the actual meaning of these mo

[XEN PATCH v2] x86/hvm: Use constants for x86 modes

2024-12-02 Thread Teddy Astie
In many places of x86 HVM code, constants integer are used to indicate in what mode is running the CPU (real, vm86, 16-bits, 32-bits, 64-bits). However, these constants are are written directly as integer which hides the actual meaning of these modes. This patch introduces X86_MODE_* macros and