Re: [XEN PATCH v2] build: Fix x86 out-of-tree build without EFI

2022-08-17 Thread Jan Beulich
On 17.08.2022 16:12, Anthony PERARD wrote: > On Wed, Aug 17, 2022 at 12:38:36PM +0200, Jan Beulich wrote: >> On 17.08.2022 11:15, Anthony PERARD wrote: >>> --- a/xen/common/efi/efi-common.mk >>> +++ b/xen/common/efi/efi-common.mk >>> @@ -9,9 +9,9 @@ CFLAGS-y += -iquote $(srcdir) >>> # e.g.: It tra

Re: [XEN PATCH v2] build: Fix x86 out-of-tree build without EFI

2022-08-17 Thread Bertrand Marquis
Hi Anthony, > On 17 Aug 2022, at 10:15, Anthony PERARD wrote: > > We can't have a source file with the same name that exist in both the > common code and in the arch specific code for efi/. This can lead to > comfusion in make and it can pick up the wrong source file. This issue > lead to a fail

Re: [XEN PATCH v2] build: Fix x86 out-of-tree build without EFI

2022-08-17 Thread Anthony PERARD
On Wed, Aug 17, 2022 at 12:38:36PM +0200, Jan Beulich wrote: > On 17.08.2022 11:15, Anthony PERARD wrote: > > --- a/xen/common/efi/efi-common.mk > > +++ b/xen/common/efi/efi-common.mk > > @@ -9,9 +9,9 @@ CFLAGS-y += -iquote $(srcdir) > > # e.g.: It transforms "dir/foo/bar" into successively > > #

Re: [XEN PATCH v2] build: Fix x86 out-of-tree build without EFI

2022-08-17 Thread Andrew Cooper
On 17/08/2022 12:02, Andrew Cooper wrote: > On 17/08/2022 10:15, Anthony PERARD wrote: >> We can't have a source file with the same name that exist in both the >> common code and in the arch specific code for efi/. This can lead to >> comfusion in make and it can pick up the wrong source file. This

Re: [XEN PATCH v2] build: Fix x86 out-of-tree build without EFI

2022-08-17 Thread Andrew Cooper
On 17/08/2022 10:15, Anthony PERARD wrote: > We can't have a source file with the same name that exist in both the > common code and in the arch specific code for efi/. This can lead to > comfusion in make and it can pick up the wrong source file. This issue > lead to a failure to build a pv-shim f

Re: [XEN PATCH v2] build: Fix x86 out-of-tree build without EFI

2022-08-17 Thread Jan Beulich
On 17.08.2022 11:15, Anthony PERARD wrote: > --- a/xen/common/efi/efi-common.mk > +++ b/xen/common/efi/efi-common.mk > @@ -9,9 +9,9 @@ CFLAGS-y += -iquote $(srcdir) > # e.g.: It transforms "dir/foo/bar" into successively > # "dir foo bar", ".. .. ..", "../../.." > $(obj)/%.c: $(srctree)/co

[XEN PATCH v2] build: Fix x86 out-of-tree build without EFI

2022-08-17 Thread Anthony PERARD
We can't have a source file with the same name that exist in both the common code and in the arch specific code for efi/. This can lead to comfusion in make and it can pick up the wrong source file. This issue lead to a failure to build a pv-shim for x86 out-of-tree, as this is one example of an x8