Re: [XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen

2023-01-02 Thread Julien Grall
Hi, On 29/12/2022 08:45, Oleksii wrote: Totally agree then. I missed that there is .bss.*. Actually I reworked a little bit xen.lds.S. As a basis I took xen.lds.S from ARM and removed all arch specific sections. So xen.lds.S contains stuff which isn't used for now (for example, *(.data.scheduler

Re: [XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen

2022-12-29 Thread Oleksii
On Wed, 2022-12-28 at 18:56 +, Andrew Cooper wrote: > On 23/12/2022 11:16 am, Oleksii Kurochko wrote: > > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > > index 942e4ffbc1..893dd19ea6 100644 > > --- a/xen/arch/riscv/Makefile > > +++ b/xen/arch/riscv/Makefile > > @@ -1,2 +1,32

Re: [XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen

2022-12-29 Thread Oleksii
On Wed, 2022-12-28 at 22:22 +, Julien Grall wrote: > > > On Mon, 26 Dec 2022 at 12:14, Oleksii > wrote: > > > > > > > +/* > > > > + * PAGE_SIZE is defined in <{asm,xen}/page-*.h> but to > > > > + * remove unnecessary headers for minimal > > > > + * build headers it will be better to set PAG

Re: [XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen

2022-12-29 Thread Oleksii
On Wed, 2022-12-28 at 19:01 +, Andrew Cooper wrote: > On 28/12/2022 4:51 am, Alistair Francis wrote: > > On Mon, Dec 26, 2022 at 9:14 PM Oleksii > > wrote: > > > On Fri, 2022-12-23 at 13:50 +, Julien Grall wrote: > > > > On 23/12/2022 11:16, Oleksii Kurochko wrote: > > > > > + . = ALIGN(P

Re: [XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen

2022-12-28 Thread Julien Grall
On Mon, 26 Dec 2022 at 12:14, Oleksii wrote: > > > > > +/* > > > + * PAGE_SIZE is defined in <{asm,xen}/page-*.h> but to > > > + * remove unnecessary headers for minimal > > > + * build headers it will be better to set PAGE_SIZE > > > + * explicitly. > > > > TBH, I think this is a shortcut that i

Re: [XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen

2022-12-28 Thread Andrew Cooper
On 28/12/2022 4:51 am, Alistair Francis wrote: > On Mon, Dec 26, 2022 at 9:14 PM Oleksii wrote: >> On Fri, 2022-12-23 at 13:50 +, Julien Grall wrote: >>> On 23/12/2022 11:16, Oleksii Kurochko wrote: + . = ALIGN(PAGE_SIZE); + .bss : { + __bss_start = .; + *(.bs

Re: [XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen

2022-12-28 Thread Andrew Cooper
On 23/12/2022 11:16 am, Oleksii Kurochko wrote: > diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile > index 942e4ffbc1..893dd19ea6 100644 > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -1,2 +1,32 @@ > +obj-$(CONFIG_RISCV_64) += riscv64/ > + > +$(TARGET): $(TARGET)

Re: [XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen

2022-12-28 Thread Oleksii
Alistair, Thanks for your comments! On Wed, 2022-12-28 at 14:51 +1000, Alistair Francis wrote: > On Mon, Dec 26, 2022 at 9:14 PM Oleksii > wrote: > > > > Hi Julien, > > > > Thanks for your comments. > > > > On Fri, 2022-12-23 at 13:50 +, Julien Grall wrote: > > > Hi Oleksii, > > > > > >

Re: [XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen

2022-12-27 Thread Alistair Francis
On Mon, Dec 26, 2022 at 9:14 PM Oleksii wrote: > > Hi Julien, > > Thanks for your comments. > > On Fri, 2022-12-23 at 13:50 +, Julien Grall wrote: > > Hi Oleksii, > > > > + Anthony for the Makefile changes. > > > > On 23/12/2022 11:16, Oleksii Kurochko wrote: > > > The patch provides a minimal

Re: [XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen

2022-12-26 Thread Oleksii
Hi Julien, Thanks for your comments. On Fri, 2022-12-23 at 13:50 +, Julien Grall wrote: > Hi Oleksii, > > + Anthony for the Makefile changes. > > On 23/12/2022 11:16, Oleksii Kurochko wrote: > > The patch provides a minimal amount of changes to start > > build and run minimal Xen binary at

Re: [XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen

2022-12-23 Thread Julien Grall
Hi Oleksii, + Anthony for the Makefile changes. On 23/12/2022 11:16, Oleksii Kurochko wrote: The patch provides a minimal amount of changes to start build and run minimal Xen binary at GitLab CI&CD that will allow continuous checking of the build status of RISC-V Xen. RISC-V Xen can be built b

[XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen

2022-12-23 Thread Oleksii Kurochko
The patch provides a minimal amount of changes to start build and run minimal Xen binary at GitLab CI&CD that will allow continuous checking of the build status of RISC-V Xen. RISC-V Xen can be built by the following instructions: $ CONTAINER=riscv64 ./automation/scripts/containerize \ ma