Re: [XEN PATCH 12/13] xen/x86: fixed violations of MISRA C:2012 Rule 7.2

2023-06-21 Thread Stefano Stabellini
On Wed, 21 Jun 2023, Jan Beulich wrote: > First of all - please trim replies. > > On 20.06.2023 23:23, Stefano Stabellini wrote: > > On Tue, 20 Jun 2023, Simone Ballarin wrote: > >> --- a/xen/arch/x86/percpu.c > >> +++ b/xen/arch/x86/percpu.c > >> @@ -12,7 +12,7 @@ unsigned long __per_cpu_offset[N

Re: [XEN PATCH 12/13] xen/x86: fixed violations of MISRA C:2012 Rule 7.2

2023-06-21 Thread Jan Beulich
First of all - please trim replies. On 20.06.2023 23:23, Stefano Stabellini wrote: > On Tue, 20 Jun 2023, Simone Ballarin wrote: >> --- a/xen/arch/x86/percpu.c >> +++ b/xen/arch/x86/percpu.c >> @@ -12,7 +12,7 @@ unsigned long __per_cpu_offset[NR_CPUS]; >> * possible #PF at (NULL + a little) whic

Re: [XEN PATCH 12/13] xen/x86: fixed violations of MISRA C:2012 Rule 7.2

2023-06-20 Thread Stefano Stabellini
On Tue, 20 Jun 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline > states: > "A "u" or "U" suffix shall be applied to all integer constants that are > represented in an unsigned type". > > I propose to use "U"

Re: [XEN PATCH 12/13] xen/x86: fixed violations of MISRA C:2012 Rule 7.2

2023-06-20 Thread Jan Beulich
On 20.06.2023 12:35, Simone Ballarin wrote: > --- a/xen/arch/x86/apic.c > +++ b/xen/arch/x86/apic.c > @@ -1211,7 +1211,7 @@ static void __init calibrate_APIC_clock(void) > * Setup the APIC counter to maximum. There is no way the lapic > * can underflow in the 100ms detection time frame.

[XEN PATCH 12/13] xen/x86: fixed violations of MISRA C:2012 Rule 7.2

2023-06-20 Thread Simone Ballarin
From: Gianluca Luparini The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline states: "A "u" or "U" suffix shall be applied to all integer constants that are represented in an unsigned type". I propose to use "U" as a suffix to explicitly state when an integer constant i