Re: [XEN PATCH 11/11] x86/mm: Add assertion to address MISRA C:2012 Rule 2.1

2023-08-03 Thread Jan Beulich
On 03.08.2023 11:30, Nicola Vetrini wrote: > On 03/08/2023 11:20, Jan Beulich wrote: >> On 02.08.2023 16:38, Nicola Vetrini wrote: >>> --- a/xen/arch/x86/mm/p2m-pod.c >>> +++ b/xen/arch/x86/mm/p2m-pod.c >>> @@ -1045,6 +1045,7 @@ p2m_pod_zero_check(struct p2m_domain *p2m, const >>> gfn_t *gfns, uns

Re: [XEN PATCH 11/11] x86/mm: Add assertion to address MISRA C:2012 Rule 2.1

2023-08-03 Thread Nicola Vetrini
On 03/08/2023 11:20, Jan Beulich wrote: On 02.08.2023 16:38, Nicola Vetrini wrote: --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -4879,6 +4879,7 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) return subarch_memory_op(cmd, arg); } +ASSERT_UNR

Re: [XEN PATCH 11/11] x86/mm: Add assertion to address MISRA C:2012 Rule 2.1

2023-08-03 Thread Jan Beulich
On 02.08.2023 16:38, Nicola Vetrini wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -4879,6 +4879,7 @@ long arch_memory_op(unsigned long cmd, > XEN_GUEST_HANDLE_PARAM(void) arg) > return subarch_memory_op(cmd, arg); > } > > +ASSERT_UNREACHABLE(); > return 0

[XEN PATCH 11/11] x86/mm: Add assertion to address MISRA C:2012 Rule 2.1

2023-08-02 Thread Nicola Vetrini
The ASSERT_UNREACHABLE() assertion is added before a definitely unreachable return statement to address MISRA C:2012 Rule 2.1, because the explicit return from a non-void function is a defensive coding measure, and thus intended to be unreachable. No functional changes. Signed-off-by: Nicola Vetr