Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-18 Thread Nicola Vetrini
Jan has a point: I think we should record all our deviations and unique ways to interpret the rules under docs/misra. And the Eclair configuration should reflect that. It is not a good idea to only keep the information in the Eclair config because, even if it is now upstream in xen.git, it is

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-16 Thread Stefano Stabellini
On Wed, 16 Aug 2023, Jan Beulich wrote: > On 16.08.2023 12:47, Nicola Vetrini wrote: > > On 16/08/2023 12:31, Jan Beulich wrote: > >> On 16.08.2023 12:01, Nicola Vetrini wrote: > >>> On 08/08/2023 11:03, Nicola Vetrini wrote: > On 04/08/2023 08:42, Jan Beulich wrote: > > On 04.08.2023 01:5

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-16 Thread Jan Beulich
On 16.08.2023 15:43, Nicola Vetrini wrote: > On 16/08/2023 13:23, Jan Beulich wrote: >> On 16.08.2023 12:47, Nicola Vetrini wrote: >>> On 16/08/2023 12:31, Jan Beulich wrote: On 16.08.2023 12:01, Nicola Vetrini wrote: > On 08/08/2023 11:03, Nicola Vetrini wrote: >> On 04/08/2023 08:42,

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-16 Thread Nicola Vetrini
On 16/08/2023 13:23, Jan Beulich wrote: On 16.08.2023 12:47, Nicola Vetrini wrote: On 16/08/2023 12:31, Jan Beulich wrote: On 16.08.2023 12:01, Nicola Vetrini wrote: On 08/08/2023 11:03, Nicola Vetrini wrote: On 04/08/2023 08:42, Jan Beulich wrote: On 04.08.2023 01:50, Stefano Stabellini wro

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-16 Thread Jan Beulich
On 16.08.2023 12:47, Nicola Vetrini wrote: > On 16/08/2023 12:31, Jan Beulich wrote: >> On 16.08.2023 12:01, Nicola Vetrini wrote: >>> On 08/08/2023 11:03, Nicola Vetrini wrote: On 04/08/2023 08:42, Jan Beulich wrote: > On 04.08.2023 01:50, Stefano Stabellini wrote: >> On Thu, 3 Aug 20

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-16 Thread Jan Beulich
On 16.08.2023 12:01, Nicola Vetrini wrote: > Hi, > > On 08/08/2023 11:03, Nicola Vetrini wrote: >> On 04/08/2023 08:42, Jan Beulich wrote: >>> On 04.08.2023 01:50, Stefano Stabellini wrote: On Thu, 3 Aug 2023, Jan Beulich wrote: > On 02.08.2023 16:38, Nicola Vetrini wrote: >> Rule 2.1

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-16 Thread Nicola Vetrini
On 16/08/2023 12:31, Jan Beulich wrote: On 16.08.2023 12:01, Nicola Vetrini wrote: Hi, On 08/08/2023 11:03, Nicola Vetrini wrote: On 04/08/2023 08:42, Jan Beulich wrote: On 04.08.2023 01:50, Stefano Stabellini wrote: On Thu, 3 Aug 2023, Jan Beulich wrote: On 02.08.2023 16:38, Nicola Vetrini

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-16 Thread Nicola Vetrini
Hi, On 08/08/2023 11:03, Nicola Vetrini wrote: On 04/08/2023 08:42, Jan Beulich wrote: On 04.08.2023 01:50, Stefano Stabellini wrote: On Thu, 3 Aug 2023, Jan Beulich wrote: On 02.08.2023 16:38, Nicola Vetrini wrote: Rule 2.1 states: "A project shall not contain unreachable code". The functi

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-08 Thread Nicola Vetrini
On 04/08/2023 08:42, Jan Beulich wrote: On 04.08.2023 01:50, Stefano Stabellini wrote: On Thu, 3 Aug 2023, Jan Beulich wrote: On 02.08.2023 16:38, Nicola Vetrini wrote: Rule 2.1 states: "A project shall not contain unreachable code". The functions - machine_halt - maybe_reboot - machine_resta

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-03 Thread Jan Beulich
On 04.08.2023 01:50, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Jan Beulich wrote: >> On 02.08.2023 16:38, Nicola Vetrini wrote: >>> Rule 2.1 states: "A project shall not contain unreachable code". >>> >>> The functions >>> - machine_halt >>> - maybe_reboot >>> - machine_restart >>> are not su

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-03 Thread Stefano Stabellini
On Thu, 3 Aug 2023, Jan Beulich wrote: > On 02.08.2023 16:38, Nicola Vetrini wrote: > > Rule 2.1 states: "A project shall not contain unreachable code". > > > > The functions > > - machine_halt > > - maybe_reboot > > - machine_restart > > are not supposed to return, hence the following break state

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-03 Thread Jan Beulich
On 02.08.2023 16:38, Nicola Vetrini wrote: > Rule 2.1 states: "A project shall not contain unreachable code". > > The functions > - machine_halt > - maybe_reboot > - machine_restart > are not supposed to return, hence the following break statement > is marked as intentionally unreachable with the

[XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-02 Thread Nicola Vetrini
Rule 2.1 states: "A project shall not contain unreachable code". The functions - machine_halt - maybe_reboot - machine_restart are not supposed to return, hence the following break statement is marked as intentionally unreachable with the ASSERT_UNREACHABLE() macro to justify the violation of the