Re: [XEN PATCH 02/15] build: rework asm-offsets.* build step to use kbuild

2023-05-25 Thread Anthony PERARD
On Wed, May 24, 2023 at 04:09:39PM +0200, Jan Beulich wrote: > On 23.05.2023 18:37, Anthony PERARD wrote: > > Use $(if_changed_dep, ) macro to generate "asm-offsets.s" and remove > > the use of $(move-if-changes,). That mean that "asm-offset.s" will be > > changed even when the output doesn't chang

Re: [XEN PATCH 02/15] build: rework asm-offsets.* build step to use kbuild

2023-05-24 Thread Jan Beulich
On 23.05.2023 18:37, Anthony PERARD wrote: > Use $(if_changed_dep, ) macro to generate "asm-offsets.s" and remove > the use of $(move-if-changes,). That mean that "asm-offset.s" will be > changed even when the output doesn't change. > > But "asm-offsets.s" is only used to generated "asm-offsets.h"

Re: [XEN PATCH 02/15] build: rework asm-offsets.* build step to use kbuild

2023-05-24 Thread Luca Fancellu
> On 24 May 2023, at 09:01, Jan Beulich wrote: > > On 24.05.2023 09:39, Luca Fancellu wrote: >>> On 23 May 2023, at 17:37, Anthony PERARD wrote: >>> Instead of having a special $(cmd_asm-offsets.s) command, we could >>> probably reuse $(cmd_cc_s_c) from Rules.mk, but that would mean that >>> a

Re: [XEN PATCH 02/15] build: rework asm-offsets.* build step to use kbuild

2023-05-24 Thread Jan Beulich
On 24.05.2023 09:39, Luca Fancellu wrote: >> On 23 May 2023, at 17:37, Anthony PERARD wrote: >> Instead of having a special $(cmd_asm-offsets.s) command, we could >> probably reuse $(cmd_cc_s_c) from Rules.mk, but that would mean that >> an hypothetical additional flags "-flto" in CFLAGS would not

Re: [XEN PATCH 02/15] build: rework asm-offsets.* build step to use kbuild

2023-05-24 Thread Luca Fancellu
> On 23 May 2023, at 17:37, Anthony PERARD wrote: > > Use $(if_changed_dep, ) macro to generate "asm-offsets.s" and remove > the use of $(move-if-changes,). That mean that "asm-offset.s" will be > changed even when the output doesn't change. > > But "asm-offsets.s" is only used to generated "a

[XEN PATCH 02/15] build: rework asm-offsets.* build step to use kbuild

2023-05-23 Thread Anthony PERARD
Use $(if_changed_dep, ) macro to generate "asm-offsets.s" and remove the use of $(move-if-changes,). That mean that "asm-offset.s" will be changed even when the output doesn't change. But "asm-offsets.s" is only used to generated "asm-offsets.h". So instead of regenerating "asm-offsets.h" every ti