Re: [XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-28 Thread Nicola Vetrini
On 2024-02-26 11:51, Jan Beulich wrote: On 23.02.2024 08:58, Nicola Vetrini wrote: On 2024-02-19 16:14, Nicola Vetrini wrote: The cache clearing and invalidation helpers in x86 and Arm didn't comply with MISRA C Rule 17.7: "The value returned by a function having non-void return type shall be u

Re: [XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-26 Thread Stefano Stabellini
On Sat, 24 Feb 2024, Nicola Vetrini wrote: > Hi Stefano, > > On 2024-02-24 00:05, Stefano Stabellini wrote: > > On Fri, 23 Feb 2024, Nicola Vetrini wrote: > > > On 2024-02-19 16:14, Nicola Vetrini wrote: > > > > The cache clearing and invalidation helpers in x86 and Arm didn't > > > > comply with

Re: [XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-26 Thread Jan Beulich
On 23.02.2024 08:58, Nicola Vetrini wrote: > On 2024-02-19 16:14, Nicola Vetrini wrote: >> The cache clearing and invalidation helpers in x86 and Arm didn't >> comply with MISRA C Rule 17.7: "The value returned by a function >> having non-void return type shall be used". On Arm they >> were always

Re: [XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-24 Thread Nicola Vetrini
Hi Stefano, On 2024-02-24 00:05, Stefano Stabellini wrote: On Fri, 23 Feb 2024, Nicola Vetrini wrote: On 2024-02-19 16:14, Nicola Vetrini wrote: > The cache clearing and invalidation helpers in x86 and Arm didn't > comply with MISRA C Rule 17.7: "The value returned by a function > having non-vo

Re: [XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-23 Thread Stefano Stabellini
On Fri, 23 Feb 2024, Nicola Vetrini wrote: > On 2024-02-19 16:14, Nicola Vetrini wrote: > > The cache clearing and invalidation helpers in x86 and Arm didn't > > comply with MISRA C Rule 17.7: "The value returned by a function > > having non-void return type shall be used". On Arm they > > were alw

Re: [XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-22 Thread Nicola Vetrini
On 2024-02-19 16:14, Nicola Vetrini wrote: The cache clearing and invalidation helpers in x86 and Arm didn't comply with MISRA C Rule 17.7: "The value returned by a function having non-void return type shall be used". On Arm they were always returning 0, while some in x86 returned -EOPNOTSUPP and

Re: [XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-22 Thread Jan Beulich
On 22.02.2024 15:43, Nicola Vetrini wrote: >>> In passing it should be noted that the header ordering in >>> x86/alternative.c is not the one usually prescribed, so that may be >>> taken care of as well. >> >> I'm afraid I don't understand this remark. >> > > I just meant to say that this > > #in

Re: [XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-22 Thread Nicola Vetrini
--- a/xen/arch/arm/include/asm/page.h +++ b/xen/arch/arm/include/asm/page.h @@ -123,6 +123,7 @@ #ifndef __ASSEMBLY__ +#include This is a no-go, imo (also on x86): Adding this include here effectively means that nearly every CU will have a dependency on that header, no matter that most

Re: [XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-22 Thread Jan Beulich
On 21.02.2024 16:46, Nicola Vetrini wrote: > On 2024-02-21 13:08, Nicola Vetrini wrote: >> On 2024-02-20 09:14, Nicola Vetrini wrote: >>> On 2024-02-20 08:45, Jan Beulich wrote: On 19.02.2024 16:14, Nicola Vetrini wrote: > The cache clearing and invalidation helpers in x86 and Arm didn't >

Re: [XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-21 Thread Nicola Vetrini
On 2024-02-21 13:08, Nicola Vetrini wrote: On 2024-02-20 09:14, Nicola Vetrini wrote: On 2024-02-20 08:45, Jan Beulich wrote: On 19.02.2024 16:14, Nicola Vetrini wrote: The cache clearing and invalidation helpers in x86 and Arm didn't comply with MISRA C Rule 17.7: "The value returned by a fun

Re: [XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-21 Thread Nicola Vetrini
On 2024-02-20 09:14, Nicola Vetrini wrote: On 2024-02-20 08:45, Jan Beulich wrote: On 19.02.2024 16:14, Nicola Vetrini wrote: The cache clearing and invalidation helpers in x86 and Arm didn't comply with MISRA C Rule 17.7: "The value returned by a function having non-void return type shall be u

Re: [XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-20 Thread Nicola Vetrini
On 2024-02-20 08:45, Jan Beulich wrote: On 19.02.2024 16:14, Nicola Vetrini wrote: The cache clearing and invalidation helpers in x86 and Arm didn't comply with MISRA C Rule 17.7: "The value returned by a function having non-void return type shall be used". On Arm they were always returning 0, w

Re: [XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-19 Thread Jan Beulich
On 19.02.2024 16:14, Nicola Vetrini wrote: > The cache clearing and invalidation helpers in x86 and Arm didn't > comply with MISRA C Rule 17.7: "The value returned by a function > having non-void return type shall be used". On Arm they > were always returning 0, while some in x86 returned -EOPNOTSU

[XEN PATCH] xen: cache clearing and invalidation helpers refactoring

2024-02-19 Thread Nicola Vetrini
The cache clearing and invalidation helpers in x86 and Arm didn't comply with MISRA C Rule 17.7: "The value returned by a function having non-void return type shall be used". On Arm they were always returning 0, while some in x86 returned -EOPNOTSUPP and in common/grant_table the return value is sa