Re: [XEN PATCH] xen/set_{c,p}x_pminfo: address violations od MISRA C:2012 Rule 8.3

2023-10-27 Thread Federico Serafini
On 27/10/23 15:57, Jan Beulich wrote: On 26.10.2023 14:09, Federico Serafini wrote: --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -457,14 +457,14 @@ static void print_PPC(unsigned int platform_limit) printk("\t_PPC: %d\n", platform_limit); } -int set_px_pm

Re: [XEN PATCH] xen/set_{c,p}x_pminfo: address violations od MISRA C:2012 Rule 8.3

2023-10-27 Thread Jan Beulich
On 26.10.2023 14:09, Federico Serafini wrote: > --- a/xen/drivers/cpufreq/cpufreq.c > +++ b/xen/drivers/cpufreq/cpufreq.c > @@ -457,14 +457,14 @@ static void print_PPC(unsigned int platform_limit) > printk("\t_PPC: %d\n", platform_limit); > } > > -int set_px_pminfo(uint32_t acpi_id, struct

Re: [XEN PATCH] xen/set_{c,p}x_pminfo: address violations od MISRA C:2012 Rule 8.3

2023-10-27 Thread Federico Serafini
On 27/10/23 09:07, Jan Beulich wrote: On 27.10.2023 01:00, Stefano Stabellini wrote: On Thu, 26 Oct 2023, Federico Serafini wrote: @@ -675,16 +673,16 @@ static int __init cpufreq_cmdline_parse(const char *s, const char *e) static int cf_check cpu_callback( struct notifier_block *nfb

Re: [XEN PATCH] xen/set_{c,p}x_pminfo: address violations od MISRA C:2012 Rule 8.3

2023-10-27 Thread Jan Beulich
On 27.10.2023 01:00, Stefano Stabellini wrote: > On Thu, 26 Oct 2023, Federico Serafini wrote: >> @@ -675,16 +673,16 @@ static int __init cpufreq_cmdline_parse(const char *s, >> const char *e) >> static int cf_check cpu_callback( >> struct notifier_block *nfb, unsigned long action, void *hcp

Re: [XEN PATCH] xen/set_{c,p}x_pminfo: address violations od MISRA C:2012 Rule 8.3

2023-10-26 Thread Stefano Stabellini
On Thu, 26 Oct 2023, Federico Serafini wrote: > Make function definitions and declarations consistent. > No functional change. > > Signed-off-by: Federico Serafini Great job at taking the opportunity to improve the code style with this patch. Only one comment below. > --- > xen/arch/x86/x86_6

[XEN PATCH] xen/set_{c,p}x_pminfo: address violations od MISRA C:2012 Rule 8.3

2023-10-26 Thread Federico Serafini
Make function definitions and declarations consistent. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/x86_64/cpu_idle.c | 5 ++-- xen/arch/x86/x86_64/cpufreq.c | 6 ++-- xen/drivers/cpufreq/cpufreq.c | 52 -- xen/include/xen/pmstat.h