Re: [XEN PATCH] build: Fix x86 build without EFI

2022-08-18 Thread Jan Beulich
On 18.08.2022 19:42, Julien Grall wrote: > On 16/08/2022 17:29, Jan Beulich wrote: >> On 16.08.2022 17:43, Anthony PERARD wrote: >>> On Tue, Aug 16, 2022 at 03:02:10PM +0200, Jan Beulich wrote: On 16.08.2022 12:30, Anthony PERARD wrote: > We can't have a source file with the same name that

Re: [XEN PATCH] build: Fix x86 build without EFI

2022-08-18 Thread Julien Grall
Hi Jan, On 16/08/2022 17:29, Jan Beulich wrote: On 16.08.2022 17:43, Anthony PERARD wrote: On Tue, Aug 16, 2022 at 03:02:10PM +0200, Jan Beulich wrote: On 16.08.2022 12:30, Anthony PERARD wrote: We can't have a source file with the same name that exist in both the common code and in the arch

Re: [XEN PATCH] build: Fix x86 build without EFI

2022-08-16 Thread Jan Beulich
On 16.08.2022 17:43, Anthony PERARD wrote: > On Tue, Aug 16, 2022 at 03:02:10PM +0200, Jan Beulich wrote: >> On 16.08.2022 12:30, Anthony PERARD wrote: >>> We can't have a source file with the same name that exist in both the >>> common code and in the arch specific code for efi/. This can lead to

Re: [XEN PATCH] build: Fix x86 build without EFI

2022-08-16 Thread Andrew Cooper
On 16/08/2022 11:30, Anthony Perard wrote: > We can't have a source file with the same name that exist in both the > common code and in the arch specific code for efi/. This can lead to > comfusion in make and it can pick up the wrong source file. This issue > lead to a failure to build a pv-shim f

Re: [XEN PATCH] build: Fix x86 build without EFI

2022-08-16 Thread Anthony PERARD
On Tue, Aug 16, 2022 at 03:02:10PM +0200, Jan Beulich wrote: > On 16.08.2022 12:30, Anthony PERARD wrote: > > We can't have a source file with the same name that exist in both the > > common code and in the arch specific code for efi/. This can lead to > > comfusion in make and it can pick up the w

Re: [XEN PATCH] build: Fix x86 build without EFI

2022-08-16 Thread Anthony PERARD
On Tue, Aug 16, 2022 at 12:01:40PM +0100, Julien Grall wrote: > > xen/common/efi/{stub.c => common_stub.c} | 6 ++ > > I haven't looked at the rest of the patch. However, I think you also want to > update .gitignore to excluse arch/*/efi/common_stub.c. > > Also, I am thinking to drop my patc

Re: [XEN PATCH] build: Fix x86 build without EFI

2022-08-16 Thread Jan Beulich
On 16.08.2022 12:30, Anthony PERARD wrote: > We can't have a source file with the same name that exist in both the > common code and in the arch specific code for efi/. This can lead to > comfusion in make and it can pick up the wrong source file. This issue > lead to a failure to build a pv-shim f

Re: [XEN PATCH] build: Fix x86 build without EFI

2022-08-16 Thread Julien Grall
Hi Anthony, On 16/08/2022 11:30, Anthony PERARD wrote: We can't have a source file with the same name that exist in both the common code and in the arch specific code for efi/. This can lead to comfusion in make and it can pick up the wrong source file. This issue Typo: s/comfusion/confusion/

[XEN PATCH] build: Fix x86 build without EFI

2022-08-16 Thread Anthony PERARD
We can't have a source file with the same name that exist in both the common code and in the arch specific code for efi/. This can lead to comfusion in make and it can pick up the wrong source file. This issue lead to a failure to build a pv-shim for x86 out-of-tree, as this is one example of an x8