Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-10 Thread Chen, Jiqian
On 2024/1/11 04:09, Stewart Hildebrand wrote: > On 1/5/24 02:09, Jiqian Chen wrote: >> diff --git a/xen/common/domctl.c b/xen/common/domctl.c >> index f5a71ee5f78d..eeb975bd0194 100644 >> --- a/xen/common/domctl.c >> +++ b/xen/common/domctl.c >> @@ -653,12 +653,20 @@ long do_domctl(XEN_GUEST_HANDLE

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-10 Thread Stewart Hildebrand
On 1/5/24 02:09, Jiqian Chen wrote: > diff --git a/xen/common/domctl.c b/xen/common/domctl.c > index f5a71ee5f78d..eeb975bd0194 100644 > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -653,12 +653,20 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) > u_domctl) > unsigned

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-10 Thread Chen, Jiqian
Thank Jan and Roger, I may know how to add a new hypercall XEN_DOMCTL_gsi_permission, I will implement it in next version. On 2024/1/9 18:46, Jan Beulich wrote: > On 09.01.2024 11:16, Chen, Jiqian wrote: >> On 2024/1/9 17:38, Jan Beulich wrote: >>> On 09.01.2024 09:18, Chen, Jiqian wrote: A

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-09 Thread Jan Beulich
On 09.01.2024 11:16, Chen, Jiqian wrote: > On 2024/1/9 17:38, Jan Beulich wrote: >> On 09.01.2024 09:18, Chen, Jiqian wrote: >>> A new hypercall using for granting gsi? If so, how does the caller know to >>> call which hypercall to grant permission, XEN_DOMCTL_irq_permission or that >>> new hyper

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-09 Thread Roger Pau Monné
On Tue, Jan 09, 2024 at 10:16:26AM +, Chen, Jiqian wrote: > On 2024/1/9 17:38, Jan Beulich wrote: > > On 09.01.2024 09:18, Chen, Jiqian wrote: > >> On 2024/1/8 23:05, Roger Pau Monné wrote: > >>> On Mon, Jan 08, 2024 at 09:55:26AM +0100, Jan Beulich wrote: > On 06.01.2024 02:08, Stefano St

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-09 Thread Chen, Jiqian
On 2024/1/9 17:38, Jan Beulich wrote: > On 09.01.2024 09:18, Chen, Jiqian wrote: >> On 2024/1/8 23:05, Roger Pau Monné wrote: >>> On Mon, Jan 08, 2024 at 09:55:26AM +0100, Jan Beulich wrote: On 06.01.2024 02:08, Stefano Stabellini wrote: > On Fri, 5 Jan 2024, Jiqian Chen wrote: >> ---

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-09 Thread Jan Beulich
On 09.01.2024 09:18, Chen, Jiqian wrote: > On 2024/1/8 23:05, Roger Pau Monné wrote: >> On Mon, Jan 08, 2024 at 09:55:26AM +0100, Jan Beulich wrote: >>> On 06.01.2024 02:08, Stefano Stabellini wrote: On Fri, 5 Jan 2024, Jiqian Chen wrote: > --- a/tools/libs/light/libxl_pci.c > +++ b/to

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-09 Thread Chen, Jiqian
On 2024/1/8 23:05, Roger Pau Monné wrote: > On Mon, Jan 08, 2024 at 09:55:26AM +0100, Jan Beulich wrote: >> On 06.01.2024 02:08, Stefano Stabellini wrote: >>> On Fri, 5 Jan 2024, Jiqian Chen wrote: --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -1418,6 +1418

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-08 Thread Roger Pau Monné
On Mon, Jan 08, 2024 at 09:55:26AM +0100, Jan Beulich wrote: > On 06.01.2024 02:08, Stefano Stabellini wrote: > > On Fri, 5 Jan 2024, Jiqian Chen wrote: > >> --- a/tools/libs/light/libxl_pci.c > >> +++ b/tools/libs/light/libxl_pci.c > >> @@ -1418,6 +1418,7 @@ static void pci_add_dm_done(libxl__egc

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-08 Thread Jan Beulich
On 06.01.2024 02:08, Stefano Stabellini wrote: > On Fri, 5 Jan 2024, Jiqian Chen wrote: >> --- a/tools/libs/light/libxl_pci.c >> +++ b/tools/libs/light/libxl_pci.c >> @@ -1418,6 +1418,7 @@ static void pci_add_dm_done(libxl__egc *egc, >> unsigned long long start, end, flags, size; >> int i

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-07 Thread Chen, Jiqian
On 2024/1/6 09:08, Stefano Stabellini wrote: > On Fri, 5 Jan 2024, Jiqian Chen wrote: >> Some type of domain don't have PIRQ, like PVH, current >> implementation is not suitable for those domain. >> >> When passthrough a device to guest on PVH dom0, this >> pci_add_dm_done->XEN_DOMCTL_irq_permissio

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-05 Thread Stefano Stabellini
On Fri, 5 Jan 2024, Stefano Stabellini wrote: > On Fri, 5 Jan 2024, Jiqian Chen wrote: > > Some type of domain don't have PIRQ, like PVH, current > > implementation is not suitable for those domain. > > > > When passthrough a device to guest on PVH dom0, this > > pci_add_dm_done->XEN_DOMCTL_irq_pe

Re: [RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-05 Thread Stefano Stabellini
On Fri, 5 Jan 2024, Jiqian Chen wrote: > Some type of domain don't have PIRQ, like PVH, current > implementation is not suitable for those domain. > > When passthrough a device to guest on PVH dom0, this > pci_add_dm_done->XEN_DOMCTL_irq_permission will failed > at domain_pirq_to_irq. > > So, cha

[RFC XEN PATCH v4 4/5] domctl: Use gsi to grant/revoke irq permission

2024-01-04 Thread Jiqian Chen
Some type of domain don't have PIRQ, like PVH, current implementation is not suitable for those domain. When passthrough a device to guest on PVH dom0, this pci_add_dm_done->XEN_DOMCTL_irq_permission will failed at domain_pirq_to_irq. So, change it to use gsi to grant/revoke irq permission. And c