Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-30 Thread Roger Pau Monné
On Thu, Nov 30, 2023 at 06:32:00AM +, Chen, Jiqian wrote: > > On 2023/11/28 22:17, Roger Pau Monné wrote: > > On Fri, Nov 24, 2023 at 06:41:35PM +0800, Jiqian Chen wrote: > >> If we run Xen with PVH dom0 and hvm domU, hvm will map a pirq for > >> a passthrough device by using gsi, see xen_pt_r

Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-30 Thread Chen, Jiqian
On 2023/11/30 17:00, Jan Beulich wrote: > On 30.11.2023 07:44, Chen, Jiqian wrote: >> On 2023/11/28 23:14, Jan Beulich wrote: >>> On 24.11.2023 11:41, Jiqian Chen wrote: --- a/xen/arch/x86/hvm/hypercall.c +++ b/xen/arch/x86/hvm/hypercall.c @@ -74,6 +74,8 @@ long hvm_physdev_op(int cm

Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-30 Thread Jan Beulich
On 30.11.2023 07:44, Chen, Jiqian wrote: > On 2023/11/28 23:14, Jan Beulich wrote: >> On 24.11.2023 11:41, Jiqian Chen wrote: >>> --- a/xen/arch/x86/hvm/hypercall.c >>> +++ b/xen/arch/x86/hvm/hypercall.c >>> @@ -74,6 +74,8 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) >>> arg) >>>

Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-30 Thread Chen, Jiqian
Hi Jan Beulich, On 2023/11/30 14:44, Chen, Jiqian wrote: > > On 2023/11/28 23:14, Jan Beulich wrote: >> On 24.11.2023 11:41, Jiqian Chen wrote: >>> --- a/xen/arch/x86/hvm/hypercall.c >>> +++ b/xen/arch/x86/hvm/hypercall.c >>> @@ -74,6 +74,8 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(v

Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-29 Thread Chen, Jiqian
On 2023/11/28 23:14, Jan Beulich wrote: > On 24.11.2023 11:41, Jiqian Chen wrote: >> --- a/xen/arch/x86/hvm/hypercall.c >> +++ b/xen/arch/x86/hvm/hypercall.c >> @@ -74,6 +74,8 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) >> arg) >> { >> case PHYSDEVOP_map_pirq: >> c

Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-29 Thread Chen, Jiqian
On 2023/11/28 22:17, Roger Pau Monné wrote: > On Fri, Nov 24, 2023 at 06:41:35PM +0800, Jiqian Chen wrote: >> If we run Xen with PVH dom0 and hvm domU, hvm will map a pirq for >> a passthrough device by using gsi, see xen_pt_realize->xc_physdev_map_pirq >> and pci_add_dm_done->xc_physdev_map_pirq.

Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-28 Thread Jan Beulich
On 24.11.2023 11:41, Jiqian Chen wrote: > --- a/xen/arch/x86/hvm/hypercall.c > +++ b/xen/arch/x86/hvm/hypercall.c > @@ -74,6 +74,8 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) > arg) > { > case PHYSDEVOP_map_pirq: > case PHYSDEVOP_unmap_pirq: > +if (is_hardwa

Re: [RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-28 Thread Roger Pau Monné
On Fri, Nov 24, 2023 at 06:41:35PM +0800, Jiqian Chen wrote: > If we run Xen with PVH dom0 and hvm domU, hvm will map a pirq for > a passthrough device by using gsi, see xen_pt_realize->xc_physdev_map_pirq > and pci_add_dm_done->xc_physdev_map_pirq. Then xc_physdev_map_pirq will > call into Xen, bu

[RFC XEN PATCH v2 2/3] x86/pvh: Open PHYSDEVOP_map_pirq for PVH dom0

2023-11-24 Thread Jiqian Chen
If we run Xen with PVH dom0 and hvm domU, hvm will map a pirq for a passthrough device by using gsi, see xen_pt_realize->xc_physdev_map_pirq and pci_add_dm_done->xc_physdev_map_pirq. Then xc_physdev_map_pirq will call into Xen, but in hvm_physdev_op, PHYSDEVOP_map_pirq is not allowed because currd