Re: [RFC XEN PATCH v12 6/7] tools: Add new function to get gsi from dev

2024-08-01 Thread Chen, Jiqian
On 2024/8/1 21:01, Roger Pau Monné wrote: > On Mon, Jul 08, 2024 at 07:41:23PM +0800, Jiqian Chen wrote: >> When passthrough a device to domU, QEMU and xl tools use its gsi >> number to do pirq mapping, see QEMU code >> xen_pt_realize->xc_physdev_map_pirq, and xl code >> pci_add_dm_done->xc_physdev

Re: [RFC XEN PATCH v12 6/7] tools: Add new function to get gsi from dev

2024-08-01 Thread Roger Pau Monné
On Mon, Jul 08, 2024 at 07:41:23PM +0800, Jiqian Chen wrote: > When passthrough a device to domU, QEMU and xl tools use its gsi > number to do pirq mapping, see QEMU code > xen_pt_realize->xc_physdev_map_pirq, and xl code > pci_add_dm_done->xc_physdev_map_pirq, but the gsi number is got > from file

Re: [RFC XEN PATCH v12 6/7] tools: Add new function to get gsi from dev

2024-07-29 Thread Anthony PERARD
On Tue, Jul 09, 2024 at 03:35:57AM +, Chen, Jiqian wrote: > On 2024/7/8 21:27, Anthony PERARD wrote: > > You could reuse the already opened fd from libxencall: > > xencall_fd(xch->xcall) > Do I need to check it this fd<0? No, it should be good to use. Cheers, -- Anthony Perard | Vates

Re: [RFC XEN PATCH v12 6/7] tools: Add new function to get gsi from dev

2024-07-08 Thread Chen, Jiqian
On 2024/7/8 21:27, Anthony PERARD wrote: > On Mon, Jul 08, 2024 at 07:41:23PM +0800, Jiqian Chen wrote: >> diff --git a/tools/libs/ctrl/xc_physdev.c b/tools/libs/ctrl/xc_physdev.c >> index e9fcd755fa62..54edb0f3c0dc 100644 >> --- a/tools/libs/ctrl/xc_physdev.c >> +++ b/tools/libs/ctrl/xc_physdev.c

Re: [RFC XEN PATCH v12 6/7] tools: Add new function to get gsi from dev

2024-07-08 Thread Anthony PERARD
On Mon, Jul 08, 2024 at 07:41:23PM +0800, Jiqian Chen wrote: > diff --git a/tools/libs/ctrl/xc_physdev.c b/tools/libs/ctrl/xc_physdev.c > index e9fcd755fa62..54edb0f3c0dc 100644 > --- a/tools/libs/ctrl/xc_physdev.c > +++ b/tools/libs/ctrl/xc_physdev.c > @@ -111,3 +111,38 @@ int xc_physdev_unmap_pir

[RFC XEN PATCH v12 6/7] tools: Add new function to get gsi from dev

2024-07-08 Thread Jiqian Chen
When passthrough a device to domU, QEMU and xl tools use its gsi number to do pirq mapping, see QEMU code xen_pt_realize->xc_physdev_map_pirq, and xl code pci_add_dm_done->xc_physdev_map_pirq, but the gsi number is got from file /sys/bus/pci/devices//irq, that is wrong, because irq is not equal wit