Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-23 Thread Huang Rui
On Fri, Mar 24, 2023 at 12:23:39AM +0800, Roger Pau Monné wrote: > On Thu, Mar 23, 2023 at 09:34:40PM +0800, Huang Rui wrote: > > On Thu, Mar 23, 2023 at 06:43:53PM +0800, Roger Pau Monné wrote: > > > On Wed, Mar 22, 2023 at 01:48:30PM +0100, Jan Beulich wrote: > > > > On 22.03.2023 13:33, Huang Ru

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-23 Thread Roger Pau Monné
On Thu, Mar 23, 2023 at 09:34:40PM +0800, Huang Rui wrote: > On Thu, Mar 23, 2023 at 06:43:53PM +0800, Roger Pau Monné wrote: > > On Wed, Mar 22, 2023 at 01:48:30PM +0100, Jan Beulich wrote: > > > On 22.03.2023 13:33, Huang Rui wrote: > > > > I traced that while we do pci-assignable-add, we will fo

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-23 Thread Jan Beulich
On 23.03.2023 11:26, Huang Rui wrote: > On Wed, Mar 22, 2023 at 08:48:30PM +0800, Jan Beulich wrote: >> On 22.03.2023 13:33, Huang Rui wrote: >>> I traced that while we do pci-assignable-add, we will follow below trace to >>> bind the passthrough device. >>> >>> pciassignable_add()->libxl_device_pc

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-23 Thread Huang Rui
On Thu, Mar 23, 2023 at 06:43:53PM +0800, Roger Pau Monné wrote: > On Wed, Mar 22, 2023 at 01:48:30PM +0100, Jan Beulich wrote: > > On 22.03.2023 13:33, Huang Rui wrote: > > > I traced that while we do pci-assignable-add, we will follow below trace > > > to > > > bind the passthrough device. > > >

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-23 Thread Roger Pau Monné
On Wed, Mar 22, 2023 at 01:48:30PM +0100, Jan Beulich wrote: > On 22.03.2023 13:33, Huang Rui wrote: > > I traced that while we do pci-assignable-add, we will follow below trace to > > bind the passthrough device. > > > > pciassignable_add()->libxl_device_pci_assignable_add()->libxl__device_pci_as

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-23 Thread Huang Rui
On Wed, Mar 22, 2023 at 08:48:30PM +0800, Jan Beulich wrote: > On 22.03.2023 13:33, Huang Rui wrote: > > I traced that while we do pci-assignable-add, we will follow below trace to > > bind the passthrough device. > > > > pciassignable_add()->libxl_device_pci_assignable_add()->libxl__device_pci_as

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-22 Thread Jan Beulich
On 22.03.2023 13:33, Huang Rui wrote: > I traced that while we do pci-assignable-add, we will follow below trace to > bind the passthrough device. > > pciassignable_add()->libxl_device_pci_assignable_add()->libxl__device_pci_assignable_add()->pciback_dev_assign() > > Then kernel xen-pciback drive

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-22 Thread Huang Rui
On Wed, Mar 22, 2023 at 05:34:41PM +0800, Roger Pau Monné wrote: > On Wed, Mar 22, 2023 at 03:28:58PM +0800, Huang Rui wrote: > > On Tue, Mar 21, 2023 at 09:03:58PM +0800, Huang Rui wrote: > > > On Tue, Mar 21, 2023 at 08:27:21PM +0800, Jan Beulich wrote: > > > > On 21.03.2023 12:49, Huang Rui wrot

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-22 Thread Roger Pau Monné
On Wed, Mar 22, 2023 at 03:28:58PM +0800, Huang Rui wrote: > On Tue, Mar 21, 2023 at 09:03:58PM +0800, Huang Rui wrote: > > On Tue, Mar 21, 2023 at 08:27:21PM +0800, Jan Beulich wrote: > > > On 21.03.2023 12:49, Huang Rui wrote: > > > > Thanks, but we found if dom0 is PV domain, the passthrough dev

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-22 Thread Jan Beulich
On 22.03.2023 08:28, Huang Rui wrote: > On Tue, Mar 21, 2023 at 09:03:58PM +0800, Huang Rui wrote: >> On Tue, Mar 21, 2023 at 08:27:21PM +0800, Jan Beulich wrote: >>> On 21.03.2023 12:49, Huang Rui wrote: Thanks, but we found if dom0 is PV domain, the passthrough device will access this f

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-22 Thread Huang Rui
On Tue, Mar 21, 2023 at 09:03:58PM +0800, Huang Rui wrote: > On Tue, Mar 21, 2023 at 08:27:21PM +0800, Jan Beulich wrote: > > On 21.03.2023 12:49, Huang Rui wrote: > > > Thanks, but we found if dom0 is PV domain, the passthrough device will > > > access this function to write the real bar. > > > >

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-21 Thread Huang Rui
On Tue, Mar 21, 2023 at 08:27:21PM +0800, Jan Beulich wrote: > On 21.03.2023 12:49, Huang Rui wrote: > > Thanks, but we found if dom0 is PV domain, the passthrough device will > > access this function to write the real bar. > > Can you please be quite a bit more detailed about this? The specific c

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-21 Thread Huang Rui
On Tue, Mar 21, 2023 at 08:20:53PM +0800, Roger Pau Monné wrote: > On Tue, Mar 21, 2023 at 07:49:26PM +0800, Huang Rui wrote: > > On Tue, Mar 21, 2023 at 06:20:03PM +0800, Jan Beulich wrote: > > > On 21.03.2023 11:14, Huang Rui wrote: > > > > On Tue, Mar 21, 2023 at 05:41:57PM +0800, Jan Beulich wr

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-21 Thread Jan Beulich
On 21.03.2023 12:49, Huang Rui wrote: > Thanks, but we found if dom0 is PV domain, the passthrough device will > access this function to write the real bar. Can you please be quite a bit more detailed about this? The specific code paths taken (in upstream software) to result in such would of of in

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-21 Thread Jan Beulich
On 21.03.2023 13:20, Roger Pau Monné wrote: > On Tue, Mar 21, 2023 at 07:49:26PM +0800, Huang Rui wrote: >> On Tue, Mar 21, 2023 at 06:20:03PM +0800, Jan Beulich wrote: >>> On 21.03.2023 11:14, Huang Rui wrote: On Tue, Mar 21, 2023 at 05:41:57PM +0800, Jan Beulich wrote: > On 21.03.2023 10

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-21 Thread Roger Pau Monné
On Tue, Mar 21, 2023 at 07:49:26PM +0800, Huang Rui wrote: > On Tue, Mar 21, 2023 at 06:20:03PM +0800, Jan Beulich wrote: > > On 21.03.2023 11:14, Huang Rui wrote: > > > On Tue, Mar 21, 2023 at 05:41:57PM +0800, Jan Beulich wrote: > > >> On 21.03.2023 10:36, Huang Rui wrote: > > >>> On Wed, Mar 15,

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-21 Thread Huang Rui
On Tue, Mar 21, 2023 at 06:20:03PM +0800, Jan Beulich wrote: > On 21.03.2023 11:14, Huang Rui wrote: > > On Tue, Mar 21, 2023 at 05:41:57PM +0800, Jan Beulich wrote: > >> On 21.03.2023 10:36, Huang Rui wrote: > >>> On Wed, Mar 15, 2023 at 12:02:35AM +0800, Jan Beulich wrote: > On 12.03.2023 08

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-21 Thread Jan Beulich
On 21.03.2023 11:14, Huang Rui wrote: > On Tue, Mar 21, 2023 at 05:41:57PM +0800, Jan Beulich wrote: >> On 21.03.2023 10:36, Huang Rui wrote: >>> On Wed, Mar 15, 2023 at 12:02:35AM +0800, Jan Beulich wrote: On 12.03.2023 08:54, Huang Rui wrote: > --- a/xen/drivers/vpci/header.c > +++ b

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-21 Thread Huang Rui
On Tue, Mar 21, 2023 at 05:41:57PM +0800, Jan Beulich wrote: > On 21.03.2023 10:36, Huang Rui wrote: > > On Wed, Mar 15, 2023 at 12:02:35AM +0800, Jan Beulich wrote: > >> On 12.03.2023 08:54, Huang Rui wrote: > >>> --- a/xen/drivers/vpci/header.c > >>> +++ b/xen/drivers/vpci/header.c > >>> @@ -392,

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-21 Thread Jan Beulich
On 21.03.2023 10:36, Huang Rui wrote: > On Wed, Mar 15, 2023 at 12:02:35AM +0800, Jan Beulich wrote: >> On 12.03.2023 08:54, Huang Rui wrote: >>> --- a/xen/drivers/vpci/header.c >>> +++ b/xen/drivers/vpci/header.c >>> @@ -392,7 +392,7 @@ static void cf_check bar_write( >>> * Xen only cares wh

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-21 Thread Huang Rui
Hi Jan, On Wed, Mar 15, 2023 at 12:02:35AM +0800, Jan Beulich wrote: > On 12.03.2023 08:54, Huang Rui wrote: > > From: Chen Jiqian > > > > When dom0 is PVH and we want to passthrough gpu to guest, > > we should allow BAR writes even through BAR is mapped. If > > not, the value of BARs are not in

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-14 Thread Stefano Stabellini
On Mon, 13 Mar 2023, Christian König wrote: > Am 13.03.23 um 08:23 schrieb Christian König: > > Am 12.03.23 um 08:54 schrieb Huang Rui: > > > From: Chen Jiqian > > > > > > When dom0 is PVH and we want to passthrough gpu to guest, > > > we should allow BAR writes even through BAR is mapped. If > >

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-14 Thread Jan Beulich
On 12.03.2023 08:54, Huang Rui wrote: > From: Chen Jiqian > > When dom0 is PVH and we want to passthrough gpu to guest, > we should allow BAR writes even through BAR is mapped. If > not, the value of BARs are not initialized when guest firstly > start. >From this it doesn't become clear why a GP

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-13 Thread Huang Rui
On Mon, Mar 13, 2023 at 03:26:09PM +0800, Koenig, Christian wrote: > Am 13.03.23 um 08:23 schrieb Christian König: > > > > > > Am 12.03.23 um 08:54 schrieb Huang Rui: > >> From: Chen Jiqian > >> > >> When dom0 is PVH and we want to passthrough gpu to guest, > >> we should allow BAR writes even thr

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-13 Thread Jan Beulich
On 13.03.2023 08:26, Christian König wrote: > Am 13.03.23 um 08:23 schrieb Christian König: >> Am 12.03.23 um 08:54 schrieb Huang Rui: >>> --- a/xen/drivers/vpci/header.c >>> +++ b/xen/drivers/vpci/header.c >>> @@ -392,7 +392,7 @@ static void cf_check bar_write( >>>    * Xen only cares whether

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-13 Thread Christian König
Am 13.03.23 um 08:23 schrieb Christian König: Am 12.03.23 um 08:54 schrieb Huang Rui: From: Chen Jiqian When dom0 is PVH and we want to passthrough gpu to guest, we should allow BAR writes even through BAR is mapped. If not, the value of BARs are not initialized when guest firstly start. Si

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-13 Thread Christian König
Am 12.03.23 um 08:54 schrieb Huang Rui: From: Chen Jiqian When dom0 is PVH and we want to passthrough gpu to guest, we should allow BAR writes even through BAR is mapped. If not, the value of BARs are not initialized when guest firstly start. Signed-off-by: Chen Jiqian Signed-off-by: Huang

[RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-11 Thread Huang Rui
From: Chen Jiqian When dom0 is PVH and we want to passthrough gpu to guest, we should allow BAR writes even through BAR is mapped. If not, the value of BARs are not initialized when guest firstly start. Signed-off-by: Chen Jiqian Signed-off-by: Huang Rui --- xen/drivers/vpci/header.c | 2 +-