Re: [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-12-09 Thread Stefano Stabellini
On Thu, 25 Nov 2021, Julien Grall wrote: > For the record, I actually considered whether it is worth to fully implement > an M2P on Arm. We technically have space in the struct page_info for that. > However, I don't see it necessary in other place of Xen, so I would prefer to > keep the space free

Re: [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-12-01 Thread Oleksandr
On 01.12.21 18:22, Julien Grall wrote: On 29/11/2021 15:58, Oleksandr wrote: Hi Julien Hi, Hi Julien [snip] ! Please note, there is still unresolved locking question here for which I failed to find a suitable solution. So, it is still an RFC ! According to the internal

Re: [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-12-01 Thread Oleksandr
On 01.12.21 18:32, Julien Grall wrote: Hi Oleksandr, Hi Julien On 26/11/2021 13:51, Oleksandr wrote: On 25.11.21 21:04, Julien Grall wrote:   { +    mfn_t mfn = lpae_get_mfn(pte); +   ASSERT(p2m_is_valid(pte));     /* @@ -731,11 +733,22 @@ static void p2m_put_l3_page(const lpae

Re: [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-12-01 Thread Julien Grall
Hi Oleksandr, On 26/11/2021 13:51, Oleksandr wrote: On 25.11.21 21:04, Julien Grall wrote:   { +    mfn_t mfn = lpae_get_mfn(pte); +   ASSERT(p2m_is_valid(pte));     /* @@ -731,11 +733,22 @@ static void p2m_put_l3_page(const lpae_t pte)    */   if ( p2m_is_foreign(pte.p2m.type)

Re: [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-12-01 Thread Julien Grall
On 29/11/2021 15:58, Oleksandr wrote: Hi Julien Hi, [snip] ! Please note, there is still unresolved locking question here for which I failed to find a suitable solution. So, it is still an RFC ! According to the internal conversation: Now the GFN field in the struct page_info i

Re: [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-11-29 Thread Oleksandr
Hi Julien [snip] ! Please note, there is still unresolved locking question here for which I failed to find a suitable solution. So, it is still an RFC ! According to the internal conversation: Now the GFN field in the struct page_info is accessed from gnttab_set_frame_gfn() in the gra

Re: [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-11-26 Thread Oleksandr
On 25.11.21 21:04, Julien Grall wrote: Hi Oleksandr, Apologies for the late answer. I was waiting for XSA-387 to go out before commenting. Hi Julien, I got it, no problem On 23/09/2021 20:32, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Rework Arm implementation to stor

Re: [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-11-25 Thread Julien Grall
Hi Oleksandr, Apologies for the late answer. I was waiting for XSA-387 to go out before commenting. On 23/09/2021 20:32, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Rework Arm implementation to store grant table frame GFN in struct page_info directly instead of keeping it in stan

Re: [future abi] [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-10-14 Thread Oleksandr
Hello, all. The potential issue on Arm (which might happen when remapping grant-table frame) is still present, it hasn't disappeared. Some effort was put in trying to fix that by current patch. Although I have addressed (I hope) all review comments received for this patch, I realize this pat

Re: [future abi] [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-09-24 Thread Julien Grall
Hi Roger, On 24/09/2021 21:10, Roger Pau Monné wrote: On Fri, Sep 24, 2021 at 07:52:24PM +0500, Julien Grall wrote: Hi Roger, On 24/09/2021 13:41, Roger Pau Monné wrote: On Thu, Sep 23, 2021 at 09:59:26PM +0100, Andrew Cooper wrote: On 23/09/2021 20:32, Oleksandr Tyshchenko wrote: Suggested

Re: [future abi] [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-09-24 Thread Roger Pau Monné
On Fri, Sep 24, 2021 at 07:52:24PM +0500, Julien Grall wrote: > Hi Roger, > > On 24/09/2021 13:41, Roger Pau Monné wrote: > > On Thu, Sep 23, 2021 at 09:59:26PM +0100, Andrew Cooper wrote: > > > On 23/09/2021 20:32, Oleksandr Tyshchenko wrote: > > > > Suggested-by: Julien Grall > > > > Signed-off

Re: [future abi] [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-09-24 Thread Julien Grall
Hi Roger, On 24/09/2021 13:41, Roger Pau Monné wrote: On Thu, Sep 23, 2021 at 09:59:26PM +0100, Andrew Cooper wrote: On 23/09/2021 20:32, Oleksandr Tyshchenko wrote: Suggested-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- You can find the related discussions at: https://lore.kerne

Re: [future abi] [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-09-24 Thread Roger Pau Monné
On Thu, Sep 23, 2021 at 09:59:26PM +0100, Andrew Cooper wrote: > On 23/09/2021 20:32, Oleksandr Tyshchenko wrote: > > Suggested-by: Julien Grall > > Signed-off-by: Oleksandr Tyshchenko > > --- > > You can find the related discussions at: > > https://lore.kernel.org/xen-devel/93d0df14-2c8a-c2e3-8c

Re: [future abi] [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-09-23 Thread Oleksandr
On 23.09.21 23:59, Andrew Cooper wrote: Hi Andrew. On 23/09/2021 20:32, Oleksandr Tyshchenko wrote: Suggested-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- You can find the related discussions at: https://lore.kernel.org/xen-devel/93d0df14-2c8a-c2e3-8c51-544121901...@xen.org/ ht

Re: [future abi] [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-09-23 Thread Andrew Cooper
On 23/09/2021 20:32, Oleksandr Tyshchenko wrote: > Suggested-by: Julien Grall > Signed-off-by: Oleksandr Tyshchenko > --- > You can find the related discussions at: > https://lore.kernel.org/xen-devel/93d0df14-2c8a-c2e3-8c51-544121901...@xen.org/ > https://lore.kernel.org/xen-devel/1628890077-125

[RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on Arm

2021-09-23 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko Rework Arm implementation to store grant table frame GFN in struct page_info directly instead of keeping it in standalone status/shared arrays. To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the space to hold 52-bit/28-bit + extra bit value respectively. In order to