Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-21 Thread Stefano Stabellini
On Tue, 21 Nov 2023, Stewart Hildebrand wrote: > On 11/17/23 03:11, Oleksandr Tyshchenko wrote: > > > > > > On 17.11.23 05:31, Stewart Hildebrand wrote: > > > > Hello Stewart > > > > [answering only for virtio-pci bits as for vPCI I am only familiar with > > code responsible for trapping confi

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-21 Thread Stewart Hildebrand
On 11/17/23 03:11, Oleksandr Tyshchenko wrote: > > > On 17.11.23 05:31, Stewart Hildebrand wrote: > > Hello Stewart > > [answering only for virtio-pci bits as for vPCI I am only familiar with > code responsible for trapping config space accesses] > > [snip] > >>> >>> >>> Let me start by sayi

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-17 Thread Julien Grall
Hi Sergiy, On 17/11/2023 13:19, Sergiy Kibrik wrote: + */ +#define GUEST_VIRTIO_PCI_ECAM_BASE  xen_mk_ullong(0x3300) +#define GUEST_VIRTIO_PCI_TOTAL_ECAM_SIZE    xen_mk_ullong(0x0100) +#define GUEST_VIRTIO_PCI_HOST_ECAM_SIZE xen_mk_ullong(0x0020) + +/* 64 MB is reserved f

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-17 Thread Sergiy Kibrik
hi Julien, Oleksandr, [..] This patch series only covers use-cases where the device emulator handles the *entire* PCI Host bridge and PCI (virtio-pci) devices behind it (i.e. Qemu). Also this patch series doesn't touch vPCI/PCI pass-through resources, handling, accounting, nothing. I unders

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-17 Thread Oleksandr Tyshchenko
On 17.11.23 05:31, Stewart Hildebrand wrote: Hello Stewart [answering only for virtio-pci bits as for vPCI I am only familiar with code responsible for trapping config space accesses] [snip] >> >> >> Let me start by saying that if we can get away with it, I think that a >> single PCI Root Co

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-16 Thread Stewart Hildebrand
On 11/15/23 18:28, Stefano Stabellini wrote: > + Stewart, Vikram > > On Wed, 15 Nov 2023, Oleksandr Tyshchenko wrote: >> On 15.11.23 14:33, Julien Grall wrote: >>> Thanks for adding support for virtio-pci in Xen. I have some questions. >>> >>> On 15/11/2023 11:26, Sergiy Kibrik wrote: From: O

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-16 Thread Volodymyr Babchuk
Hi Stefano, Stefano Stabellini writes: > On Thu, 16 Nov 2023, Volodymyr Babchuk wrote: >> Hi Stefano, >> >> Stefano Stabellini writes: >> >> > + Stewart, Vikram >> > >> > On Wed, 15 Nov 2023, Oleksandr Tyshchenko wrote: >> >> On 15.11.23 14:33, Julien Grall wrote: >> >> > Thanks for adding

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-16 Thread Stefano Stabellini
On Thu, 16 Nov 2023, Volodymyr Babchuk wrote: > Hi Stefano, > > Stefano Stabellini writes: > > > + Stewart, Vikram > > > > On Wed, 15 Nov 2023, Oleksandr Tyshchenko wrote: > >> On 15.11.23 14:33, Julien Grall wrote: > >> > Thanks for adding support for virtio-pci in Xen. I have some questions. >

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-16 Thread Julien Grall
Hi Volodymyr, On 16/11/2023 16:53, Volodymyr Babchuk wrote: Julien Grall writes: On 16/11/2023 15:26, Stewart Hildebrand wrote: On 11/16/23 10:12, Julien Grall wrote: Hi Volodymyr, On 16/11/2023 15:07, Volodymyr Babchuk wrote: With my vPCI patch series in place, hypervisor itself assigns B

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-16 Thread Volodymyr Babchuk
Hi Julien, Julien Grall writes: > On 16/11/2023 15:26, Stewart Hildebrand wrote: >> On 11/16/23 10:12, Julien Grall wrote: >>> Hi Volodymyr, >>> >>> On 16/11/2023 15:07, Volodymyr Babchuk wrote: With my vPCI patch series in place, hypervisor itself assigns BDFs for passed-through dev

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-16 Thread Julien Grall
On 16/11/2023 15:26, Stewart Hildebrand wrote: On 11/16/23 10:12, Julien Grall wrote: Hi Volodymyr, On 16/11/2023 15:07, Volodymyr Babchuk wrote: With my vPCI patch series in place, hypervisor itself assigns BDFs for passed-through devices. Toolstack needs to get this information to know wh

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-16 Thread Stewart Hildebrand
On 11/16/23 10:12, Julien Grall wrote: > Hi Volodymyr, > > On 16/11/2023 15:07, Volodymyr Babchuk wrote: >> With my vPCI patch series in place, hypervisor itself assigns BDFs for >> passed-through devices. Toolstack needs to get this information to know >> which BDFs are free and can be used by vi

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-16 Thread Volodymyr Babchuk
Hi Stefano, Stefano Stabellini writes: > + Stewart, Vikram > > On Wed, 15 Nov 2023, Oleksandr Tyshchenko wrote: >> On 15.11.23 14:33, Julien Grall wrote: >> > Thanks for adding support for virtio-pci in Xen. I have some questions. >> > >> > On 15/11/2023 11:26, Sergiy Kibrik wrote: >> >> From

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-16 Thread Julien Grall
Hi Volodymyr, On 16/11/2023 15:07, Volodymyr Babchuk wrote: With my vPCI patch series in place, hypervisor itself assigns BDFs for passed-through devices. Toolstack needs to get this information to know which BDFs are free and can be used by virtio-pci. It sounds a bit odd to let the hyperviso

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Stefano Stabellini
+ Stewart, Vikram On Wed, 15 Nov 2023, Oleksandr Tyshchenko wrote: > On 15.11.23 14:33, Julien Grall wrote: > > Thanks for adding support for virtio-pci in Xen. I have some questions. > > > > On 15/11/2023 11:26, Sergiy Kibrik wrote: > >> From: Oleksandr Tyshchenko > >> > >> In order to enable m

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Julien Grall
Hi Oleksandr, On 15/11/2023 19:38, Oleksandr Tyshchenko wrote: The ioreq.c code was always meant to be generic and is always for every emulated MMIO. So you want to limit any change in it. Checking the MMIO region belongs to the hostbridge and doing the translation is IMHO not a good idea to do

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Oleksandr Tyshchenko
On 15.11.23 20:33, Julien Grall wrote: > Hi Oleksandr, Hello Julien > > On 15/11/2023 18:14, Oleksandr Tyshchenko wrote: >> On 15.11.23 19:31, Julien Grall wrote: >>> On 15/11/2023 16:51, Oleksandr Tyshchenko wrote: On 15.11.23 14:33, Julien Grall wrote: > Thanks for adding support f

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Julien Grall
Hi Oleksandr, On 15/11/2023 18:14, Oleksandr Tyshchenko wrote: On 15.11.23 19:31, Julien Grall wrote: On 15/11/2023 16:51, Oleksandr Tyshchenko wrote: On 15.11.23 14:33, Julien Grall wrote: Thanks for adding support for virtio-pci in Xen. I have some questions. On 15/11/2023 11:26, Sergiy Ki

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Oleksandr Tyshchenko
On 15.11.23 19:31, Julien Grall wrote: > Hi Oleksandr, Hello Julien > > On 15/11/2023 16:51, Oleksandr Tyshchenko wrote: >> >> >> On 15.11.23 14:33, Julien Grall wrote: >>> Hi, >> >> >> Hello Julien >> >> Let me please try to explain some bits. >> >> >>> >>> Thanks for adding support for virt

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Julien Grall
Hi Oleksandr, On 15/11/2023 16:51, Oleksandr Tyshchenko wrote: On 15.11.23 14:33, Julien Grall wrote: Hi, Hello Julien Let me please try to explain some bits. Thanks for adding support for virtio-pci in Xen. I have some questions. On 15/11/2023 11:26, Sergiy Kibrik wrote: From: Olek

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Oleksandr Tyshchenko
On 15.11.23 14:33, Julien Grall wrote: > Hi, Hello Julien Let me please try to explain some bits. > > Thanks for adding support for virtio-pci in Xen. I have some questions. > > On 15/11/2023 11:26, Sergiy Kibrik wrote: >> From: Oleksandr Tyshchenko >> >> In order to enable more use-cases

Re: [RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Julien Grall
Hi, Thanks for adding support for virtio-pci in Xen. I have some questions. On 15/11/2023 11:26, Sergiy Kibrik wrote: From: Oleksandr Tyshchenko In order to enable more use-cases such as having multiple device-models (Qemu) running in different backend domains which provide virtio-pci devices

[RFC PATCH 2/6] xen/public: arch-arm: reserve resources for virtio-pci

2023-11-15 Thread Sergiy Kibrik
From: Oleksandr Tyshchenko In order to enable more use-cases such as having multiple device-models (Qemu) running in different backend domains which provide virtio-pci devices for the same guest, we allocate and expose one PCI host bridge for every virtio backend domain for that guest. For that