Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-19 Thread Julien Grall
Hi, On 19/07/2023 09:54, Nicola Vetrini wrote: On 17/07/23 22:45, Julien Grall wrote: On 17/07/2023 21:40, Julien Grall wrote: On 14/07/2023 12:49, Nicola Vetrini wrote: The macro 'testop' expands to a function that declares the local variable 'oldbit', which is written before being set,

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-19 Thread Nicola Vetrini
On 17/07/23 22:45, Julien Grall wrote: On 17/07/2023 21:40, Julien Grall wrote: On 14/07/2023 12:49, Nicola Vetrini wrote: The macro 'testop' expands to a function that declares the local variable 'oldbit', which is written before being set, but is such a way that is not amenable to automa

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-18 Thread Nicola Vetrini
On 17/07/23 17:46, Jan Beulich wrote: On 17.07.2023 17:28, Nicola Vetrini wrote: On 17/07/23 15:59, Jan Beulich wrote: On 14.07.2023 16:20, Luca Fancellu wrote: On 14 Jul 2023, at 12:49, Nicola Vetrini wrote: The macro 'testop' expands to a function that declares the local variable '

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-17 Thread Julien Grall
On 17/07/2023 21:40, Julien Grall wrote: On 14/07/2023 12:49, Nicola Vetrini wrote: The macro 'testop' expands to a function that declares the local variable 'oldbit', which is written before being set, but is such a way that is not amenable to automatic checking. Therefore, a deviation comm

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-17 Thread Julien Grall
Hi, On 14/07/2023 12:49, Nicola Vetrini wrote: The macro 'testop' expands to a function that declares the local variable 'oldbit', which is written before being set, but is such a way that is not amenable to automatic checking. Therefore, a deviation comment, is introduced to document this situ

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-17 Thread Jan Beulich
On 17.07.2023 17:28, Nicola Vetrini wrote: > > > On 17/07/23 15:59, Jan Beulich wrote: >> On 14.07.2023 16:20, Luca Fancellu wrote: >>> >>> On 14 Jul 2023, at 12:49, Nicola Vetrini wrote: The macro 'testop' expands to a function that declares the local variable 'oldbit'

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-17 Thread Nicola Vetrini
On 17/07/23 15:59, Jan Beulich wrote: On 14.07.2023 16:20, Luca Fancellu wrote: On 14 Jul 2023, at 12:49, Nicola Vetrini wrote: The macro 'testop' expands to a function that declares the local variable 'oldbit', which is written before being set, but is such a way that is not amenable to

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-17 Thread Nicola Vetrini
On 17/07/23 16:06, Jan Beulich wrote: On 17.07.2023 14:16, Nicola Vetrini wrote: On 16/07/23 18:50, Julien Grall wrote: On 16/07/2023 10:20, Luca Fancellu wrote: On 14 Jul 2023, at 14:05, Julien Grall wrote: On 14/07/2023 12:49, Nicola Vetrini wrote: The macro 'testop' expands to a functi

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-17 Thread Jan Beulich
On 17.07.2023 14:16, Nicola Vetrini wrote: > On 16/07/23 18:50, Julien Grall wrote: >> On 16/07/2023 10:20, Luca Fancellu wrote: On 14 Jul 2023, at 14:05, Julien Grall wrote: On 14/07/2023 12:49, Nicola Vetrini wrote: > The macro 'testop' expands to a function that declares the local

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-17 Thread Jan Beulich
On 14.07.2023 16:20, Luca Fancellu wrote: > > >> On 14 Jul 2023, at 12:49, Nicola Vetrini wrote: >> >> The macro 'testop' expands to a function that declares the local >> variable 'oldbit', which is written before being set, but is such a >> way that is not amenable to automatic checking. >> >>

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-17 Thread Julien Grall
Hi, On 17/07/2023 13:16, Nicola Vetrini wrote: On 16/07/23 18:50, Julien Grall wrote: Hi, On 16/07/2023 10:20, Luca Fancellu wrote: On 14 Jul 2023, at 14:05, Julien Grall wrote: Hi, On 14/07/2023 12:49, Nicola Vetrini wrote: The macro 'testop' expands to a function that declares the loc

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-17 Thread Nicola Vetrini
On 16/07/23 18:50, Julien Grall wrote: Hi, On 16/07/2023 10:20, Luca Fancellu wrote: On 14 Jul 2023, at 14:05, Julien Grall wrote: Hi, On 14/07/2023 12:49, Nicola Vetrini wrote: The macro 'testop' expands to a function that declares the local variable 'oldbit', which is written before be

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-16 Thread Julien Grall
Hi, On 16/07/2023 10:20, Luca Fancellu wrote: On 14 Jul 2023, at 14:05, Julien Grall wrote: Hi, On 14/07/2023 12:49, Nicola Vetrini wrote: The macro 'testop' expands to a function that declares the local variable 'oldbit', which is written before being set, but is such a way that is not amen

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-16 Thread Luca Fancellu
> On 14 Jul 2023, at 14:05, Julien Grall wrote: > > Hi, > > On 14/07/2023 12:49, Nicola Vetrini wrote: >> The macro 'testop' expands to a function that declares the local >> variable 'oldbit', which is written before being set, but is such a >> way that is not amenable to automatic checking. >

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-14 Thread Nicola Vetrini
On 14/07/23 16:32, Luca Fancellu wrote: On 14 Jul 2023, at 15:20, Luca Fancellu wrote: On 14 Jul 2023, at 12:49, Nicola Vetrini wrote: The macro 'testop' expands to a function that declares the local variable 'oldbit', which is written before being set, but is such a way that is not

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-14 Thread Luca Fancellu
>>> "id": "SAF-2-safe", >>> +"analyser": { >>> +"eclair": "MC3R1.R9.1" >>> +}, >>> +"name": "Rule 9.1: initializer not needed", >>> +"text": "The following local variables are possibly subject to >>> being read before being

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-14 Thread Luca Fancellu
> On 14 Jul 2023, at 15:20, Luca Fancellu wrote: > > > >> On 14 Jul 2023, at 12:49, Nicola Vetrini wrote: >> >> The macro 'testop' expands to a function that declares the local >> variable 'oldbit', which is written before being set, but is such a >> way that is not amenable to automatic ch

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-14 Thread Luca Fancellu
> On 14 Jul 2023, at 12:49, Nicola Vetrini wrote: > > The macro 'testop' expands to a function that declares the local > variable 'oldbit', which is written before being set, but is such a > way that is not amenable to automatic checking. > > Therefore, a deviation comment, is introduced to do

Re: [RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-14 Thread Julien Grall
Hi, On 14/07/2023 12:49, Nicola Vetrini wrote: The macro 'testop' expands to a function that declares the local variable 'oldbit', which is written before being set, but is such a way that is not amenable to automatic checking. The code is pretty straightforward. So I am not entirely sure why

[RFC PATCH 2/4] xen/arm64: bitops: justify uninitialized variable inside a macro

2023-07-14 Thread Nicola Vetrini
The macro 'testop' expands to a function that declares the local variable 'oldbit', which is written before being set, but is such a way that is not amenable to automatic checking. Therefore, a deviation comment, is introduced to document this situation. A similar reasoning applies to macro 'gues