Re: [RFC PATCH] automation: add linker symbol name script

2024-07-24 Thread Jan Beulich
On 24.07.2024 19:48, Lira, Victor M wrote: > On 7/24/2024 12:44 AM, Jan Beulich wrote: >> Nit: In names of new files we prefer - over _. >> +script_name=`basename "$0"` > I have fixed the above comments in v2. > >>> +#!/bin/bash >> Can we rely on bash to be there and at that location? As you using

Re: [RFC PATCH] automation: add linker symbol name script

2024-07-24 Thread Julien Grall
Le mer. 24 juil. 2024 à 21:56, Jason Andryuk a écrit : > > On 2024-07-24 13:48, Lira, Victor M wrote: > > > > On 7/24/2024 12:44 AM, Jan Beulich wrote: > >> Nit: In names of new files we prefer - over _. > >> +script_name=`basename "$0"` > > I have fixed the above comments in v2. > > > >>> +#!/bin

Re: [RFC PATCH] automation: add linker symbol name script

2024-07-24 Thread Jason Andryuk
On 2024-07-24 13:48, Lira, Victor M wrote: On 7/24/2024 12:44 AM, Jan Beulich wrote: Nit: In names of new files we prefer - over _. +script_name=`basename "$0"` I have fixed the above comments in v2. +#!/bin/bash Can we rely on bash to be there and at that location? As you using any bash-is

Re: [RFC PATCH] automation: add linker symbol name script

2024-07-24 Thread Lira, Victor M
On 7/24/2024 12:44 AM, Jan Beulich wrote: Nit: In names of new files we prefer - over _. +script_name=`basename "$0"` I have fixed the above comments in v2. +#!/bin/bash Can we rely on bash to be there and at that location? As you using any bash-isms in the script which cannot be avoided?

Re: [RFC PATCH] automation: add linker symbol name script

2024-07-24 Thread Jan Beulich
On 24.07.2024 02:18, victorm.l...@amd.com wrote: > --- /dev/null > +++ b/automation/eclair_analysis/linker_symbols.sh Nit: In names of new files we prefer - over _. > @@ -0,0 +1,41 @@ > +#!/bin/bash Can we rely on bash to be there and at that location? As you using any bash-isms in the script wh

Re: [RFC PATCH] automation: add linker symbol name script

2024-07-24 Thread Jan Beulich
On 24.07.2024 08:27, Nicola Vetrini wrote: > On 2024-07-24 02:18, victorm.l...@amd.com wrote: >> --- /dev/null >> +++ b/automation/eclair_analysis/stuff.txt > > I wouldn't include the actual output in the patch. It' much better if I > have a script that produces a list of symbols, and then use th

Re: [RFC PATCH] automation: add linker symbol name script

2024-07-23 Thread Nicola Vetrini
On 2024-07-24 02:18, victorm.l...@amd.com wrote: From: Victor Lira Hi, Add a script that extracts the names of symbols in linker scripts. Signed-off-by: Victor Lira --- Note: Not included are the "." location name or symbol names enclosed in quotes since the files dont't use any. --- Cc

[RFC PATCH] automation: add linker symbol name script

2024-07-23 Thread victorm.lira
From: Victor Lira Add a script that extracts the names of symbols in linker scripts. Signed-off-by: Victor Lira --- Note: Not included are the "." location name or symbol names enclosed in quotes since the files dont't use any. --- Cc: Stefano Stabellini Cc: roberto.bagn...@bugseng.com Cc: con