Re: [RESEND] [RFC PATCH] xen/arm: domain_build: Ignore empty memory bank

2021-01-12 Thread Elliott Mitchell
On Mon, Jan 11, 2021 at 04:49:57PM -0800, Stefano Stabellini wrote: > On Mon, 4 Jan 2021, Elliott Mitchell wrote: > > On Mon, Dec 21, 2020 at 06:28:35PM +, Julien Grall wrote: > > > So I think we first need to figure out what is the offending node and > > > why it is dt_device_get_address() is

Re: [RESEND] [RFC PATCH] xen/arm: domain_build: Ignore empty memory bank

2021-01-11 Thread Stefano Stabellini
On Mon, 4 Jan 2021, Elliott Mitchell wrote: > On Mon, Dec 21, 2020 at 06:28:35PM +, Julien Grall wrote: > > On 21/12/2020 17:30, Elliott Mitchell wrote: > > > I doubt this is the only bug exposed by > > > 5a37207df52066efefe419c677b089a654d37afc. > > > > Are you saying that with my patch dropp

Re: [RESEND] [RFC PATCH] xen/arm: domain_build: Ignore empty memory bank

2021-01-04 Thread Elliott Mitchell
On Mon, Dec 21, 2020 at 06:28:35PM +, Julien Grall wrote: > On 21/12/2020 17:30, Elliott Mitchell wrote: > > I doubt this is the only bug exposed by > > 5a37207df52066efefe419c677b089a654d37afc. > > Are you saying that with my patch dropped, Xen will boot but with it > will not? I thought th

Re: [RESEND] [RFC PATCH] xen/arm: domain_build: Ignore empty memory bank

2020-12-21 Thread Elliott Mitchell
On Mon, Dec 21, 2020 at 06:28:35PM +, Julien Grall wrote: > I was planning to review the first version today, but as you sent a new > version I will answer on this one directly. Mostly the commentary has been increasing, not so much the commit. > On 21/12/2020 17:30, Elliott Mitchell wrote:

Re: [RESEND] [RFC PATCH] xen/arm: domain_build: Ignore empty memory bank

2020-12-21 Thread Julien Grall
Hi Elliott, I was planning to review the first version today, but as you sent a new version I will answer on this one directly. On 21/12/2020 17:30, Elliott Mitchell wrote: Previously Xen had stopped processing Device Trees if an empty (size == 0) memory bank was found. Commit 5a37207df52066

[RESEND] [RFC PATCH] xen/arm: domain_build: Ignore empty memory bank

2020-12-21 Thread Elliott Mitchell
Previously Xen had stopped processing Device Trees if an empty (size == 0) memory bank was found. Commit 5a37207df52066efefe419c677b089a654d37afc changed this behavior to ignore such banks. Unfortunately this means these empty nodes are visible to code which accesses the device trees. Have domai