Re: [PULL 22/27] hw/xen: Add emulated implementation of XenStore operations

2023-04-12 Thread Peter Maydell
On Wed, 12 Apr 2023 at 19:22, David Woodhouse wrote: > > On Tue, 2023-04-11 at 19:07 +0100, Peter Maydell wrote: > > > > > > > +static void xs_be_unwatch(struct qemu_xs_handle *h, struct > > > qemu_xs_watch *w) > > > +{ > > > +xs_impl_unwatch(h->impl, DOMID_QEMU, w->path, NULL, > > > xs_be_wat

Re: [PULL 22/27] hw/xen: Add emulated implementation of XenStore operations

2023-04-12 Thread David Woodhouse
On Tue, 2023-04-11 at 19:07 +0100, Peter Maydell wrote: > > > > +static void xs_be_unwatch(struct qemu_xs_handle *h, struct > > qemu_xs_watch *w) > > +{ > > +    xs_impl_unwatch(h->impl, DOMID_QEMU, w->path, NULL, > > xs_be_watch_cb, w); > > Coverity points out that this is the only call to xs_i

Re: [PULL 22/27] hw/xen: Add emulated implementation of XenStore operations

2023-04-11 Thread Peter Maydell
On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > From: David Woodhouse > > Now that we have an internal implementation of XenStore, we can populate > the xenstore_backend_ops to allow PV backends to talk to it. > > Watches can't be processed with immediate callbacks because that would > ca

Re: [PULL 22/27] hw/xen: Add emulated implementation of XenStore operations

2023-04-11 Thread Peter Maydell
On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > From: David Woodhouse > > Now that we have an internal implementation of XenStore, we can populate > the xenstore_backend_ops to allow PV backends to talk to it. > > Watches can't be processed with immediate callbacks because that would > ca

[PULL 22/27] hw/xen: Add emulated implementation of XenStore operations

2023-03-07 Thread David Woodhouse
From: David Woodhouse Now that we have an internal implementation of XenStore, we can populate the xenstore_backend_ops to allow PV backends to talk to it. Watches can't be processed with immediate callbacks because that would call back into XenBus code recursively. Defer them to a QEMUBH to be