Re: [PATCH v8 1/3] xen/events: modify struct evtchn layout

2020-11-27 Thread Jan Beulich
On 27.11.2020 12:57, Julien Grall wrote: > On 27/11/2020 11:42, Jan Beulich wrote: >> I have to admit though that I'm not fully happy with the uses of >> "unsigned char" and "unsigned short". Yes, I did ask for this >> change (based on ./CODING_STYLE), but I did also hint towards the >> use of bitf

Re: [PATCH v8 1/3] xen/events: modify struct evtchn layout

2020-11-27 Thread Julien Grall
Hi Jan, On 27/11/2020 11:42, Jan Beulich wrote: On 25.11.2020 11:51, Juergen Gross wrote: In order to avoid latent races when updating an event channel put xen_consumer and pending fields in different bytes. This is no problem right now, but especially the pending indicator isn't used only when

Re: [PATCH v8 1/3] xen/events: modify struct evtchn layout

2020-11-27 Thread Jan Beulich
On 25.11.2020 11:51, Juergen Gross wrote: > In order to avoid latent races when updating an event channel put > xen_consumer and pending fields in different bytes. This is no problem > right now, but especially the pending indicator isn't used only when > initializing an event channel (unlike xen_c

[PATCH v8 1/3] xen/events: modify struct evtchn layout

2020-11-25 Thread Juergen Gross
In order to avoid latent races when updating an event channel put xen_consumer and pending fields in different bytes. This is no problem right now, but especially the pending indicator isn't used only when initializing an event channel (unlike xen_consumer), so any future addition to this byte woul