Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-11 Thread Roger Pau Monné
On Mon, May 11, 2020 at 09:29:27AM +0200, Jan Beulich wrote: > On 08.05.2020 18:21, Roger Pau Monné wrote: > > On Fri, May 08, 2020 at 05:04:02PM +0200, Jan Beulich wrote: > >> On 08.05.2020 15:37, Roger Pau Monné wrote: > >>> On Tue, May 05, 2020 at 10:16:20AM +0200, Jan Beulich wrote: > ---

Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-11 Thread Roger Pau Monné
On Mon, May 11, 2020 at 09:25:54AM +0200, Jan Beulich wrote: > [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments > unless you have verified the sender and know the content is safe. > > On 08.05.2020 20:29, Andrew Cooper wrote: > > On 08/05/2020 16:04, Jan Beulich wrote: >

Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-11 Thread Jan Beulich
On 08.05.2020 18:21, Roger Pau Monné wrote: > On Fri, May 08, 2020 at 05:04:02PM +0200, Jan Beulich wrote: >> On 08.05.2020 15:37, Roger Pau Monné wrote: >>> On Tue, May 05, 2020 at 10:16:20AM +0200, Jan Beulich wrote: --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x

Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-11 Thread Jan Beulich
On 08.05.2020 20:29, Andrew Cooper wrote: > On 08/05/2020 16:04, Jan Beulich wrote: +} + +if ( bytes == sizeof(fpstate.env) ) +ptr = NULL; +else +ptr += sizeof(fpstate.env); +break; >>

Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-08 Thread Andrew Cooper
On 08/05/2020 16:04, Jan Beulich wrote: >>> +} >>> + >>> +if ( bytes == sizeof(fpstate.env) ) >>> +ptr = NULL; >>> +else >>> +ptr += sizeof(fpstate.env); >>> +break; >>> + >>> +case sizeof(struct x87_env16): >>>

Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-08 Thread Andrew Cooper
On 05/05/2020 09:16, Jan Beulich wrote: > While the Intel SDM claims that FRSTOR itself may raise #MF upon > completion, this was confirmed by Intel to be a doc error which will be > corrected in due course; behavior is like FLDENV, and like old hard copy > manuals describe it. Otherwise we'd have

Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-08 Thread Roger Pau Monné
On Fri, May 08, 2020 at 05:04:02PM +0200, Jan Beulich wrote: > On 08.05.2020 15:37, Roger Pau Monné wrote: > > On Tue, May 05, 2020 at 10:16:20AM +0200, Jan Beulich wrote: > >> --- a/tools/tests/x86_emulator/test_x86_emulator.c > >> +++ b/tools/tests/x86_emulator/test_x86_emulator.c > >> @@ -11648,

Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-08 Thread Jan Beulich
On 08.05.2020 15:37, Roger Pau Monné wrote: > On Tue, May 05, 2020 at 10:16:20AM +0200, Jan Beulich wrote: >> --- a/tools/tests/x86_emulator/test_x86_emulator.c >> +++ b/tools/tests/x86_emulator/test_x86_emulator.c >> @@ -2442,6 +2442,27 @@ int main(int argc, char **argv) >> else >> p

Re: [PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-08 Thread Roger Pau Monné
On Tue, May 05, 2020 at 10:16:20AM +0200, Jan Beulich wrote: > While the Intel SDM claims that FRSTOR itself may raise #MF upon > completion, this was confirmed by Intel to be a doc error which will be > corrected in due course; behavior is like FLDENV, and like old hard copy > manuals describe it.

[PATCH v8 08/12] x86emul: support FLDENV and FRSTOR

2020-05-05 Thread Jan Beulich
While the Intel SDM claims that FRSTOR itself may raise #MF upon completion, this was confirmed by Intel to be a doc error which will be corrected in due course; behavior is like FLDENV, and like old hard copy manuals describe it. Otherwise we'd have to emulate the insn by filling st(N) in suitable