Re: [PATCH v8 07/12] x86emul: support FNSTENV and FNSAVE

2020-05-13 Thread Jan Beulich
On 08.05.2020 19:58, Andrew Cooper wrote: > On 05/05/2020 09:15, Jan Beulich wrote: >> To avoid introducing another boolean into emulator state, the >> rex_prefix field gets (ab)used to convey the real/VM86 vs protected mode >> info (affecting structure layout, albeit not size) to x86_emul_blk(). >

Re: [PATCH v8 07/12] x86emul: support FNSTENV and FNSAVE

2020-05-08 Thread Andrew Cooper
On 05/05/2020 09:15, Jan Beulich wrote: > To avoid introducing another boolean into emulator state, the > rex_prefix field gets (ab)used to convey the real/VM86 vs protected mode > info (affecting structure layout, albeit not size) to x86_emul_blk(). > > Signed-off-by: Jan Beulich > --- > TBD: The

Re: [PATCH v8 07/12] x86emul: support FNSTENV and FNSAVE

2020-05-05 Thread Jan Beulich
On 05.05.2020 10:15, Jan Beulich wrote: > @@ -11542,6 +11611,12 @@ int x86_emul_blk( > switch ( state->blk ) > { > bool zf; > +struct { > +struct x87_env32 env; > +struct { > + uint8_t bytes[10]; > +} freg[8]; > +}

[PATCH v8 07/12] x86emul: support FNSTENV and FNSAVE

2020-05-05 Thread Jan Beulich
To avoid introducing another boolean into emulator state, the rex_prefix field gets (ab)used to convey the real/VM86 vs protected mode info (affecting structure layout, albeit not size) to x86_emul_blk(). Signed-off-by: Jan Beulich --- TBD: The full 16-bit padding fields in the 32-bit structures