Re: [PATCH v7 09/11] Arm32: use new-style entry annotations for entry code

2024-11-26 Thread Jan Beulich
On 25.11.2024 21:25, Julien Grall wrote: > On 01/10/2024 16:17, Jan Beulich wrote: >> Signed-off-by: Jan Beulich >> --- >> Should the GLOBAL()s also be replaced? > > What would you replace them with? LABEL() or, perhaps better, DATA()/END() pairs. >> @@ -362,13 +362,13 @@ trap_irq: >> trap_fi

Re: [PATCH v7 09/11] Arm32: use new-style entry annotations for entry code

2024-11-25 Thread Julien Grall
Hi Jan, On 01/10/2024 16:17, Jan Beulich wrote: Signed-off-by: Jan Beulich --- Should the GLOBAL()s also be replaced? What would you replace them with? --- v7: New. --- a/xen/arch/arm/arm32/entry.S +++ b/xen/arch/arm/arm32/entry.S @@ -31,7 +31,7 @@ * r4: Set to a non-zero value if a pe

[PATCH v7 09/11] Arm32: use new-style entry annotations for entry code

2024-10-01 Thread Jan Beulich
Signed-off-by: Jan Beulich --- Should the GLOBAL()s also be replaced? --- v7: New. --- a/xen/arch/arm/arm32/entry.S +++ b/xen/arch/arm/arm32/entry.S @@ -31,7 +31,7 @@ * r4: Set to a non-zero value if a pending Abort exception took place. * Otherwise, it will be set to zero. */ -prepar