Re: [PATCH v7 02/10] xen/x86: Add initial x2APIC ID to the per-vLAPIC save area

2024-10-30 Thread Andrew Cooper
On 30/10/2024 6:37 am, Jan Beulich wrote: > On 29.10.2024 21:30, Andrew Cooper wrote: >> On 21/10/2024 4:45 pm, Alejandro Vallejo wrote: >>> @@ -310,19 +309,16 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, >>> break; >>> >>> case 0xb: >>> -/* >>> - * In pr

Re: [PATCH v7 02/10] xen/x86: Add initial x2APIC ID to the per-vLAPIC save area

2024-10-30 Thread Jan Beulich
On 30.10.2024 13:03, Alejandro Vallejo wrote: > On Wed Oct 30, 2024 at 6:37 AM GMT, Jan Beulich wrote: >> On 29.10.2024 21:30, Andrew Cooper wrote: >>> On 21/10/2024 4:45 pm, Alejandro Vallejo wrote: @@ -310,19 +309,16 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, brea

Re: [PATCH v7 02/10] xen/x86: Add initial x2APIC ID to the per-vLAPIC save area

2024-10-30 Thread Alejandro Vallejo
I'm fine with all suggestions, with one exception that needs a bit more explanation... On Tue Oct 29, 2024 at 8:30 PM GMT, Andrew Cooper wrote: > On 21/10/2024 4:45 pm, Alejandro Vallejo wrote: > > This allows the initial x2APIC ID to be sent on the migration stream. > > This allows further change

Re: [PATCH v7 02/10] xen/x86: Add initial x2APIC ID to the per-vLAPIC save area

2024-10-30 Thread Alejandro Vallejo
Hi, On Wed Oct 30, 2024 at 6:37 AM GMT, Jan Beulich wrote: > On 29.10.2024 21:30, Andrew Cooper wrote: > > On 21/10/2024 4:45 pm, Alejandro Vallejo wrote: > >> @@ -310,19 +309,16 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, > >> break; > >> > >> case 0xb: > >> -

Re: [PATCH v7 02/10] xen/x86: Add initial x2APIC ID to the per-vLAPIC save area

2024-10-29 Thread Jan Beulich
On 29.10.2024 21:30, Andrew Cooper wrote: > On 21/10/2024 4:45 pm, Alejandro Vallejo wrote: >> @@ -310,19 +309,16 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, >> break; >> >> case 0xb: >> -/* >> - * In principle, this leaf is Intel-only. In practice, it

Re: [PATCH v7 02/10] xen/x86: Add initial x2APIC ID to the per-vLAPIC save area

2024-10-29 Thread Andrew Cooper
On 21/10/2024 4:45 pm, Alejandro Vallejo wrote: > This allows the initial x2APIC ID to be sent on the migration stream. > This allows further changes to topology and APIC ID assignment without > breaking existing hosts. Given the vlapic data is zero-extended on > restore, fix up migrations from hos

[PATCH v7 02/10] xen/x86: Add initial x2APIC ID to the per-vLAPIC save area

2024-10-21 Thread Alejandro Vallejo
This allows the initial x2APIC ID to be sent on the migration stream. This allows further changes to topology and APIC ID assignment without breaking existing hosts. Given the vlapic data is zero-extended on restore, fix up migrations from hosts without the field by setting it to the old convention