Re: [PATCH v6 7/8] vpci/msi: Free MSI resources when init_msi() fails

2025-06-25 Thread Jan Beulich
On 25.06.2025 12:26, Chen, Jiqian wrote: > On 2025/6/25 18:09, Jan Beulich wrote: >> On 25.06.2025 11:47, Chen, Jiqian wrote: >>> On 2025/6/25 17:15, Jan Beulich wrote: On 25.06.2025 09:16, Chen, Jiqian wrote: > On 2025/6/24 18:17, Jan Beulich wrote: >> On 24.06.2025 11:49, Chen, Jiqia

Re: [PATCH v6 7/8] vpci/msi: Free MSI resources when init_msi() fails

2025-06-25 Thread Jan Beulich
On 25.06.2025 12:26, Chen, Jiqian wrote: > On 2025/6/25 18:09, Jan Beulich wrote: >> On 25.06.2025 11:47, Chen, Jiqian wrote: >>> On 2025/6/25 17:15, Jan Beulich wrote: On 25.06.2025 09:16, Chen, Jiqian wrote: > On 2025/6/24 18:17, Jan Beulich wrote: >> On 24.06.2025 11:49, Chen, Jiqia

Re: [PATCH v6 7/8] vpci/msi: Free MSI resources when init_msi() fails

2025-06-25 Thread Jan Beulich
On 25.06.2025 11:47, Chen, Jiqian wrote: > On 2025/6/25 17:15, Jan Beulich wrote: >> On 25.06.2025 09:16, Chen, Jiqian wrote: >>> On 2025/6/24 18:17, Jan Beulich wrote: On 24.06.2025 11:49, Chen, Jiqian wrote: > On 2025/6/18 22:45, Jan Beulich wrote: >> On 12.06.2025 11:29, Jiqian Chen

Re: [PATCH v6 7/8] vpci/msi: Free MSI resources when init_msi() fails

2025-06-25 Thread Chen, Jiqian
On 2025/6/25 18:09, Jan Beulich wrote: > On 25.06.2025 11:47, Chen, Jiqian wrote: >> On 2025/6/25 17:15, Jan Beulich wrote: >>> On 25.06.2025 09:16, Chen, Jiqian wrote: On 2025/6/24 18:17, Jan Beulich wrote: > On 24.06.2025 11:49, Chen, Jiqian wrote: >> On 2025/6/18 22:45, Jan Beulich

Re: [PATCH v6 7/8] vpci/msi: Free MSI resources when init_msi() fails

2025-06-25 Thread Chen, Jiqian
On 2025/6/25 17:15, Jan Beulich wrote: > On 25.06.2025 09:16, Chen, Jiqian wrote: >> On 2025/6/24 18:17, Jan Beulich wrote: >>> On 24.06.2025 11:49, Chen, Jiqian wrote: On 2025/6/18 22:45, Jan Beulich wrote: > On 12.06.2025 11:29, Jiqian Chen wrote: >> --- a/xen/drivers/vpci/msi.c

Re: [PATCH v6 7/8] vpci/msi: Free MSI resources when init_msi() fails

2025-06-25 Thread Jan Beulich
On 25.06.2025 09:16, Chen, Jiqian wrote: > On 2025/6/24 18:17, Jan Beulich wrote: >> On 24.06.2025 11:49, Chen, Jiqian wrote: >>> On 2025/6/18 22:45, Jan Beulich wrote: On 12.06.2025 11:29, Jiqian Chen wrote: > --- a/xen/drivers/vpci/msi.c > +++ b/xen/drivers/vpci/msi.c > @@ -193,6

Re: [PATCH v6 7/8] vpci/msi: Free MSI resources when init_msi() fails

2025-06-25 Thread Chen, Jiqian
On 2025/6/24 18:17, Jan Beulich wrote: > On 24.06.2025 11:49, Chen, Jiqian wrote: >> On 2025/6/18 22:45, Jan Beulich wrote: >>> On 12.06.2025 11:29, Jiqian Chen wrote: --- a/xen/drivers/vpci/msi.c +++ b/xen/drivers/vpci/msi.c @@ -193,6 +193,33 @@ static void cf_check mask_write(

Re: [PATCH v6 7/8] vpci/msi: Free MSI resources when init_msi() fails

2025-06-24 Thread Jan Beulich
On 24.06.2025 11:49, Chen, Jiqian wrote: > On 2025/6/18 22:45, Jan Beulich wrote: >> On 12.06.2025 11:29, Jiqian Chen wrote: >>> --- a/xen/drivers/vpci/msi.c >>> +++ b/xen/drivers/vpci/msi.c >>> @@ -193,6 +193,33 @@ static void cf_check mask_write( >>> msi->mask = val; >>> } >>> >>> +static

Re: [PATCH v6 7/8] vpci/msi: Free MSI resources when init_msi() fails

2025-06-24 Thread Chen, Jiqian
On 2025/6/18 22:45, Jan Beulich wrote: > On 12.06.2025 11:29, Jiqian Chen wrote: >> --- a/xen/drivers/vpci/msi.c >> +++ b/xen/drivers/vpci/msi.c >> @@ -193,6 +193,33 @@ static void cf_check mask_write( >> msi->mask = val; >> } >> >> +static int cf_check cleanup_msi(struct pci_dev *pdev) >>

Re: [PATCH v6 7/8] vpci/msi: Free MSI resources when init_msi() fails

2025-06-19 Thread Chen, Jiqian
On 2025/6/18 22:37, Jan Beulich wrote: > On 12.06.2025 11:29, Jiqian Chen wrote: >> --- a/xen/drivers/vpci/msi.c >> +++ b/xen/drivers/vpci/msi.c >> @@ -193,6 +193,33 @@ static void cf_check mask_write( >> msi->mask = val; >> } >> >> +static int cf_check cleanup_msi(struct pci_dev *pdev) >>

Re: [PATCH v6 7/8] vpci/msi: Free MSI resources when init_msi() fails

2025-06-18 Thread Jan Beulich
On 12.06.2025 11:29, Jiqian Chen wrote: > --- a/xen/drivers/vpci/msi.c > +++ b/xen/drivers/vpci/msi.c > @@ -193,6 +193,33 @@ static void cf_check mask_write( > msi->mask = val; > } > > +static int cf_check cleanup_msi(struct pci_dev *pdev) > +{ > +int rc; > +unsigned int end, size;

Re: [PATCH v6 7/8] vpci/msi: Free MSI resources when init_msi() fails

2025-06-18 Thread Jan Beulich
On 12.06.2025 11:29, Jiqian Chen wrote: > --- a/xen/drivers/vpci/msi.c > +++ b/xen/drivers/vpci/msi.c > @@ -193,6 +193,33 @@ static void cf_check mask_write( > msi->mask = val; > } > > +static int cf_check cleanup_msi(struct pci_dev *pdev) > +{ > +int rc; > +unsigned int end, size;

[PATCH v6 7/8] vpci/msi: Free MSI resources when init_msi() fails

2025-06-12 Thread Jiqian Chen
When init_msi() fails, current logic return fail and free MSI-related resources in vpci_deassign_device(). But the previous new changes will hide MSI capability and return success, it can't reach vpci_deassign_device() to remove resources if hiding success, so those resources must be removed in cle