Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-11 Thread Stefano Stabellini
On Mon, 11 Dec 2023, Roger Pau Monné wrote: > On Tue, Dec 05, 2023 at 06:34:35PM -0800, Stefano Stabellini wrote: > > On Tue, 5 Dec 2023, Roger Pau Monné wrote: > > > > > > I don't think we should enable IOREQ servers to handle PCI > > > > > > passthrough > > > > > > for PVH guests and/or guests w

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-11 Thread Roger Pau Monné
On Tue, Dec 05, 2023 at 06:34:35PM -0800, Stefano Stabellini wrote: > On Tue, 5 Dec 2023, Roger Pau Monné wrote: > > > > > I don't think we should enable IOREQ servers to handle PCI passthrough > > > > > for PVH guests and/or guests with vPCI. If the domain has vPCI, PCI > > > > > Passthrough can b

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-11 Thread Roger Pau Monné
On Tue, Dec 05, 2023 at 02:01:46PM -0500, Stewart Hildebrand wrote: > On 12/5/23 06:08, Roger Pau Monné wrote: > > On Mon, Dec 04, 2023 at 02:07:51PM -0800, Stefano Stabellini wrote: > >> On Mon, 4 Dec 2023, Roger Pau Monné wrote: > >>> On Fri, Dec 01, 2023 at 06:56:32PM -0800, Stefano Stabellini w

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2023, Roger Pau Monné wrote: > > > > I don't think we should enable IOREQ servers to handle PCI passthrough > > > > for PVH guests and/or guests with vPCI. If the domain has vPCI, PCI > > > > Passthrough can be handled by vPCI just fine. I think this should be a > > > > good anti-feat

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2023, Stewart Hildebrand wrote: > On 12/5/23 12:09, Roger Pau Monné wrote: > > On Tue, Dec 05, 2023 at 11:27:03AM -0500, Stewart Hildebrand wrote: > >> On 12/5/23 06:08, Roger Pau Monné wrote: > >>> On Mon, Dec 04, 2023 at 02:07:51PM -0800, Stefano Stabellini wrote: > On Mon, 4 D

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-05 Thread Stewart Hildebrand
On 12/5/23 06:08, Roger Pau Monné wrote: > On Mon, Dec 04, 2023 at 02:07:51PM -0800, Stefano Stabellini wrote: >> On Mon, 4 Dec 2023, Roger Pau Monné wrote: >>> On Fri, Dec 01, 2023 at 06:56:32PM -0800, Stefano Stabellini wrote: On Fri, 1 Dec 2023, Roger Pau Monné wrote: > On Mon, Nov 13,

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-05 Thread Stewart Hildebrand
On 12/5/23 12:09, Roger Pau Monné wrote: > On Tue, Dec 05, 2023 at 11:27:03AM -0500, Stewart Hildebrand wrote: >> On 12/5/23 06:08, Roger Pau Monné wrote: >>> On Mon, Dec 04, 2023 at 02:07:51PM -0800, Stefano Stabellini wrote: On Mon, 4 Dec 2023, Roger Pau Monné wrote: > On Fri, Dec 01, 20

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-05 Thread Roger Pau Monné
On Tue, Dec 05, 2023 at 11:27:03AM -0500, Stewart Hildebrand wrote: > On 12/5/23 06:08, Roger Pau Monné wrote: > > On Mon, Dec 04, 2023 at 02:07:51PM -0800, Stefano Stabellini wrote: > >> On Mon, 4 Dec 2023, Roger Pau Monné wrote: > >>> On Fri, Dec 01, 2023 at 06:56:32PM -0800, Stefano Stabellini w

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-05 Thread Stewart Hildebrand
On 12/5/23 06:08, Roger Pau Monné wrote: > On Mon, Dec 04, 2023 at 02:07:51PM -0800, Stefano Stabellini wrote: >> On Mon, 4 Dec 2023, Roger Pau Monné wrote: >>> On Fri, Dec 01, 2023 at 06:56:32PM -0800, Stefano Stabellini wrote: On Fri, 1 Dec 2023, Roger Pau Monné wrote: > On Mon, Nov 13,

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-05 Thread Roger Pau Monné
On Mon, Dec 04, 2023 at 02:07:51PM -0800, Stefano Stabellini wrote: > On Mon, 4 Dec 2023, Roger Pau Monné wrote: > > On Fri, Dec 01, 2023 at 06:56:32PM -0800, Stefano Stabellini wrote: > > > On Fri, 1 Dec 2023, Roger Pau Monné wrote: > > > > On Mon, Nov 13, 2023 at 05:21:13PM -0500, Stewart Hildebr

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2023, Roger Pau Monné wrote: > On Fri, Dec 01, 2023 at 06:56:32PM -0800, Stefano Stabellini wrote: > > On Fri, 1 Dec 2023, Roger Pau Monné wrote: > > > On Mon, Nov 13, 2023 at 05:21:13PM -0500, Stewart Hildebrand wrote: > > > > @@ -1618,6 +1630,14 @@ int iommu_do_pci_domctl( > > > >

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-04 Thread Stewart Hildebrand
On 12/4/23 05:58, Roger Pau Monné wrote: > On Fri, Dec 01, 2023 at 06:56:32PM -0800, Stefano Stabellini wrote: >> On Fri, 1 Dec 2023, Roger Pau Monné wrote: >>> On Mon, Nov 13, 2023 at 05:21:13PM -0500, Stewart Hildebrand wrote: @@ -1618,6 +1630,14 @@ int iommu_do_pci_domctl( bus

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-04 Thread Roger Pau Monné
On Fri, Dec 01, 2023 at 06:56:32PM -0800, Stefano Stabellini wrote: > On Fri, 1 Dec 2023, Roger Pau Monné wrote: > > On Mon, Nov 13, 2023 at 05:21:13PM -0500, Stewart Hildebrand wrote: > > > @@ -1618,6 +1630,14 @@ int iommu_do_pci_domctl( > > > bus = PCI_BUS(machine_sbdf); > > > d

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-04 Thread Jan Beulich
On 02.12.2023 03:56, Stefano Stabellini wrote: > On Fri, 1 Dec 2023, Roger Pau Monné wrote: >> On Mon, Nov 13, 2023 at 05:21:13PM -0500, Stewart Hildebrand wrote: >>> @@ -1618,6 +1630,14 @@ int iommu_do_pci_domctl( >>> bus = PCI_BUS(machine_sbdf); >>> devfn = PCI_DEVFN(machine_sbd

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-03 Thread Stewart Hildebrand
On 12/1/23 21:56, Stefano Stabellini wrote: > On Fri, 1 Dec 2023, Roger Pau Monné wrote: >> On Mon, Nov 13, 2023 at 05:21:13PM -0500, Stewart Hildebrand wrote: >>> @@ -1618,6 +1630,14 @@ int iommu_do_pci_domctl( >>> bus = PCI_BUS(machine_sbdf); >>> devfn = PCI_DEVFN(machine_sbdf);

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-01 Thread Stefano Stabellini
On Fri, 1 Dec 2023, Roger Pau Monné wrote: > On Mon, Nov 13, 2023 at 05:21:13PM -0500, Stewart Hildebrand wrote: > > @@ -1618,6 +1630,14 @@ int iommu_do_pci_domctl( > > bus = PCI_BUS(machine_sbdf); > > devfn = PCI_DEVFN(machine_sbdf); > > > > +if ( needs_vpci(d) && !has_

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-01 Thread Roger Pau Monné
On Mon, Nov 13, 2023 at 05:21:13PM -0500, Stewart Hildebrand wrote: > @@ -1618,6 +1630,14 @@ int iommu_do_pci_domctl( > bus = PCI_BUS(machine_sbdf); > devfn = PCI_DEVFN(machine_sbdf); > > +if ( needs_vpci(d) && !has_vpci(d) ) > +{ > +printk(XENLOG_G_W

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-11-30 Thread Jan Beulich
On 30.11.2023 18:06, Stewart Hildebrand wrote: > On 11/30/23 03:33, Jan Beulich wrote: >> On 30.11.2023 03:47, Stewart Hildebrand wrote: >>> On 11/14/23 04:13, Jan Beulich wrote: On 13.11.2023 23:21, Stewart Hildebrand wrote: > --- a/xen/arch/x86/include/asm/domain.h > +++ b/xen/arch/x

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-11-30 Thread Stewart Hildebrand
On 11/30/23 03:33, Jan Beulich wrote: > On 30.11.2023 03:47, Stewart Hildebrand wrote: >> On 11/14/23 04:13, Jan Beulich wrote: >>> On 13.11.2023 23:21, Stewart Hildebrand wrote: --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -503,6 +503,8 @@ struc

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-11-30 Thread Jan Beulich
On 30.11.2023 03:47, Stewart Hildebrand wrote: > On 11/14/23 04:13, Jan Beulich wrote: >> On 13.11.2023 23:21, Stewart Hildebrand wrote: >>> --- a/xen/arch/x86/include/asm/domain.h >>> +++ b/xen/arch/x86/include/asm/domain.h >>> @@ -503,6 +503,8 @@ struct arch_domain >>> #define has_vpit(d)

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-11-29 Thread Stewart Hildebrand
On 11/14/23 04:13, Jan Beulich wrote: > On 13.11.2023 23:21, Stewart Hildebrand wrote: >> --- a/xen/arch/x86/include/asm/domain.h >> +++ b/xen/arch/x86/include/asm/domain.h >> @@ -503,6 +503,8 @@ struct arch_domain >> #define has_vpit(d)(!!((d)->arch.emulation_flags & X86_EMU_PIT)) >> #de

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-11-14 Thread Jan Beulich
On 13.11.2023 23:21, Stewart Hildebrand wrote: > --- a/xen/arch/x86/include/asm/domain.h > +++ b/xen/arch/x86/include/asm/domain.h > @@ -503,6 +503,8 @@ struct arch_domain > #define has_vpit(d)(!!((d)->arch.emulation_flags & X86_EMU_PIT)) > #define has_pirq(d)(!!((d)->arch.emulati

[PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-11-13 Thread Stewart Hildebrand
Select HAS_VPCI_GUEST_SUPPORT in Kconfig for enabling vPCI support for domUs. Add checks to fail guest creation if the configuration is invalid. Signed-off-by: Stewart Hildebrand --- As the tag implies, this patch is not intended to be merged (yet). Note that CONFIG_HAS_VPCI_GUEST_SUPPORT is no