Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-22 Thread Luca Fancellu
> On 22 May 2023, at 10:30, Julien Grall wrote: > > Hi, > > On 22/05/2023 09:43, Luca Fancellu wrote: >>> On 22 May 2023, at 08:50, Jan Beulich wrote: >>> >>> On 19.05.2023 16:46, Julien Grall wrote: On 19/05/2023 15:26, Luca Fancellu wrote: >> On 18 May 2023, at 10:35, Julien Grall

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-22 Thread Julien Grall
Hi, On 22/05/2023 09:43, Luca Fancellu wrote: On 22 May 2023, at 08:50, Jan Beulich wrote: On 19.05.2023 16:46, Julien Grall wrote: On 19/05/2023 15:26, Luca Fancellu wrote: On 18 May 2023, at 10:35, Julien Grall wrote: +/* + * Arm SVE feature code + * + * Copyright (C) 2022 ARM Ltd. + */

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-22 Thread Luca Fancellu
> On 22 May 2023, at 08:50, Jan Beulich wrote: > > On 19.05.2023 16:46, Julien Grall wrote: >> On 19/05/2023 15:26, Luca Fancellu wrote: On 18 May 2023, at 10:35, Julien Grall wrote: > +/* > + * Arm SVE feature code > + * > + * Copyright (C) 2022 ARM Ltd. > + */ >

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-22 Thread Jan Beulich
On 19.05.2023 16:46, Julien Grall wrote: > On 19/05/2023 15:26, Luca Fancellu wrote: >>> On 18 May 2023, at 10:35, Julien Grall wrote: +/* + * Arm SVE feature code + * + * Copyright (C) 2022 ARM Ltd. + */ + +#include +#include +#include +#includ

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-19 Thread Julien Grall
Hi, On 19/05/2023 16:13, Luca Fancellu wrote: On 19/05/2023 15:51, Luca Fancellu wrote: /* Control Registers */ /* * CPTR_EL2 needs to be written before calling vfp_restore_state, a * synchronization instruction is expected after the write (isb) */ WRITE_SYSREG(n->arch.cptr_el2, CPTR_EL2); WRIT

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-19 Thread Luca Fancellu
> On 19 May 2023, at 16:00, Julien Grall wrote: > > > > On 19/05/2023 15:51, Luca Fancellu wrote: >> /* Control Registers */ >> /* >> * CPTR_EL2 needs to be written before calling vfp_restore_state, a >> * synchronization instruction is expected after the write (isb) >> */ >> WRITE_SYSREG(n-

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-19 Thread Julien Grall
On 19/05/2023 15:51, Luca Fancellu wrote: /* Control Registers */ /* * CPTR_EL2 needs to be written before calling vfp_restore_state, a * synchronization instruction is expected after the write (isb) */ WRITE_SYSREG(n->arch.cptr_el2, CPTR_EL2); WRITE_SYSREG(n->arch.cpacr, CPACR_EL1); /* * Thi

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-19 Thread Luca Fancellu
> On 19 May 2023, at 15:46, Julien Grall wrote: > > Hi Luca, > > On 19/05/2023 15:26, Luca Fancellu wrote: >>> On 18 May 2023, at 10:35, Julien Grall wrote: /* * Comment from Linux: * Userspace may perform DC ZVA instructions. Mismatched block sizes diff --git a/xe

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-19 Thread Julien Grall
Hi Luca, On 19/05/2023 15:26, Luca Fancellu wrote: On 18 May 2023, at 10:35, Julien Grall wrote: /* * Comment from Linux: * Userspace may perform DC ZVA instructions. Mismatched block sizes diff --git a/xen/arch/arm/arm64/sve-asm.S b/xen/arch/arm/arm64/sve-asm.S new file mode 100644

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-19 Thread Luca Fancellu
> On 18 May 2023, at 10:35, Julien Grall wrote: > > Hi Luca, > > Sorry for jumping late in the review. Hi Julien, Thank you for taking the time to review, >> >> /* >>* Comment from Linux: >>* Userspace may perform DC ZVA instructions. Mismatched block sizes >> diff --git a/xen/ar

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-18 Thread Julien Grall
Hi Luca, Sorry for jumping late in the review. On 24/04/2023 07:02, Luca Fancellu wrote: Enable Xen to handle the SVE extension, add code in cpufeature module to handle ZCR SVE register, disable trapping SVE feature on system boot only when SVE resources are accessed. While there, correct codin

[PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-04-23 Thread Luca Fancellu
Enable Xen to handle the SVE extension, add code in cpufeature module to handle ZCR SVE register, disable trapping SVE feature on system boot only when SVE resources are accessed. While there, correct coding style for the comment on coprocessor trapping. Now cptr_el2 is part of the domain context