Re: [PATCH v6 01/11] memory: batch processing in acquire_resource()

2020-07-17 Thread Julien Grall
Hi, On 15/07/2020 13:28, Jan Beulich wrote: May I ask that you drop the if() around this block of code? Also, looking at this, I wonder whether it's a good idea to use the "start extent" model here anyway: You could as well update the struct (saying that it may be clobbered in the public header

Re: [PATCH v6 01/11] memory: batch processing in acquire_resource()

2020-07-16 Thread Roger Pau Monné
On Wed, Jul 15, 2020 at 02:13:42PM +0200, Jan Beulich wrote: > On 15.07.2020 11:36, Roger Pau Monné wrote: > > On Tue, Jul 07, 2020 at 09:39:40PM +0200, Michał Leszczyński wrote: > >> @@ -1599,8 +1629,17 @@ long do_memory_op(unsigned long cmd, > >> XEN_GUEST_HANDLE_PARAM(void) arg) > >> #endif >

Re: [PATCH v6 01/11] memory: batch processing in acquire_resource()

2020-07-15 Thread Jan Beulich
On 07.07.2020 21:39, Michał Leszczyński wrote: > From: Michal Leszczynski > > Allow to acquire large resources by allowing acquire_resource() > to process items in batches, using hypercall continuation. > > Be aware that this modifies the behavior of acquire_resource > call with frame_list=NULL.

Re: [PATCH v6 01/11] memory: batch processing in acquire_resource()

2020-07-15 Thread Jan Beulich
On 15.07.2020 11:36, Roger Pau Monné wrote: > On Tue, Jul 07, 2020 at 09:39:40PM +0200, Michał Leszczyński wrote: >> @@ -1599,8 +1629,17 @@ long do_memory_op(unsigned long cmd, >> XEN_GUEST_HANDLE_PARAM(void) arg) >> #endif >> >> case XENMEM_acquire_resource: >> -rc = acquire_resou

Re: [PATCH v6 01/11] memory: batch processing in acquire_resource()

2020-07-15 Thread Roger Pau Monné
On Tue, Jul 07, 2020 at 09:39:40PM +0200, Michał Leszczyński wrote: > From: Michal Leszczynski > > Allow to acquire large resources by allowing acquire_resource() > to process items in batches, using hypercall continuation. > > Be aware that this modifies the behavior of acquire_resource > call

[PATCH v6 01/11] memory: batch processing in acquire_resource()

2020-07-07 Thread Michał Leszczyński
From: Michal Leszczynski Allow to acquire large resources by allowing acquire_resource() to process items in batches, using hypercall continuation. Be aware that this modifies the behavior of acquire_resource call with frame_list=NULL. While previously it would return the size of internal array