Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-12 Thread Jan Beulich
On 11.12.2023 20:40, Oleksii wrote: > On Mon, 2023-12-11 at 18:49 +0100, Jan Beulich wrote: >> On 11.12.2023 18:37, Oleksii wrote: >>> On Mon, 2023-12-11 at 17:02 +0100, Jan Beulich wrote:  In which case the approach taken here may be fine, but it still wouldn't be what I suggested. It ma

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-11 Thread Oleksii
On Mon, 2023-12-11 at 18:49 +0100, Jan Beulich wrote: > On 11.12.2023 18:37, Oleksii wrote: > > On Mon, 2023-12-11 at 17:02 +0100, Jan Beulich wrote: > > >  In which case the approach taken here may be fine, but > > > it still wouldn't be what I suggested. It may then be Stefano or > > > Andrew > >

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-11 Thread Jan Beulich
On 11.12.2023 18:37, Oleksii wrote: > On Mon, 2023-12-11 at 17:02 +0100, Jan Beulich wrote: >>  In which case the approach taken here may be fine, but >> it still wouldn't be what I suggested. It may then be Stefano or >> Andrew >> who you could consider for such a tag. > I'm a bit confused again.

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-11 Thread Oleksii
On Mon, 2023-12-11 at 17:02 +0100, Jan Beulich wrote: > On 11.12.2023 15:43, Oleksii wrote: > > On Mon, 2023-12-04 at 11:39 +0100, Jan Beulich wrote: > > > On 04.12.2023 11:34, Oleksii wrote: > > > > If you ( or anyone else ) don't mind, I'll update the patch > > > > with an > > > > introduction of

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-11 Thread Jan Beulich
On 11.12.2023 15:43, Oleksii wrote: > On Mon, 2023-12-04 at 11:39 +0100, Jan Beulich wrote: >> On 04.12.2023 11:34, Oleksii wrote: >>> If you ( or anyone else ) don't mind, I'll update the patch with an >>> introduction of HAS_GRANT_TABLE. >> >> I won't NAK such a patch, but unless convincing argum

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-11 Thread Oleksii
On Mon, 2023-12-04 at 11:39 +0100, Jan Beulich wrote: > On 04.12.2023 11:34, Oleksii wrote: > > If you ( or anyone else ) don't mind, I'll update the patch with an > > introduction of HAS_GRANT_TABLE. > > I won't NAK such a patch, but unless convincing arguments appear I > also > won't ACK it. I a

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-04 Thread Jan Beulich
On 04.12.2023 11:34, Oleksii wrote: > If you ( or anyone else ) don't mind, I'll update the patch with an > introduction of HAS_GRANT_TABLE. I won't NAK such a patch, but unless convincing arguments appear I also won't ACK it. Jan

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-04 Thread Oleksii
On Mon, 2023-12-04 at 10:46 +0100, Jan Beulich wrote: > On 04.12.2023 10:39, Oleksii wrote: > > On Mon, 2023-12-04 at 09:41 +0100, Jan Beulich wrote: > > > On 01.12.2023 21:48, Oleksii Kurochko wrote: > > > > Ifdef-ing inclusion of allows to avoid > > > > generation of empty for cases when > > >

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-04 Thread Jan Beulich
On 04.12.2023 10:39, Oleksii wrote: > On Mon, 2023-12-04 at 09:41 +0100, Jan Beulich wrote: >> On 01.12.2023 21:48, Oleksii Kurochko wrote: >>> Ifdef-ing inclusion of allows to avoid >>> generation of empty for cases when >>> CONFIG_GRANT_TABLE is not enabled. >>> >>> The following changes were d

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-04 Thread Oleksii
On Mon, 2023-12-04 at 09:41 +0100, Jan Beulich wrote: > On 01.12.2023 21:48, Oleksii Kurochko wrote: > > Ifdef-ing inclusion of allows to avoid > > generation of empty for cases when > > CONFIG_GRANT_TABLE is not enabled. > > > > The following changes were done for Arm: > > should be included d

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-04 Thread Jan Beulich
On 01.12.2023 21:48, Oleksii Kurochko wrote: > Ifdef-ing inclusion of allows to avoid > generation of empty for cases when > CONFIG_GRANT_TABLE is not enabled. > > The following changes were done for Arm: > should be included directly because it contains > gnttab_dom0_frames() macros which is u

[PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-01 Thread Oleksii Kurochko
Ifdef-ing inclusion of allows to avoid generation of empty for cases when CONFIG_GRANT_TABLE is not enabled. The following changes were done for Arm: should be included directly because it contains gnttab_dom0_frames() macros which is unique for Arm and is used in arch/arm/domain_build.c. is #