Re: [PATCH v5 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests

2025-07-24 Thread Mykola Kvach
Hi Jürgen, On Mon, Jul 21, 2025 at 11:08 AM Jürgen Groß wrote: > > On 28.06.25 20:17, Julien Grall wrote: > > Hi Mykola, > > > > On 27/06/2025 11:51, Mykola Kvach wrote: > >> diff --git a/xen/arch/arm/include/asm/perfc_defn.h > >> b/xen/arch/arm/include/asm/ > >> perfc_defn.h > >> index effd25b6

Re: [PATCH v5 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests

2025-07-21 Thread Jürgen Groß
On 28.06.25 20:17, Julien Grall wrote: Hi Mykola, On 27/06/2025 11:51, Mykola Kvach wrote: diff --git a/xen/arch/arm/include/asm/perfc_defn.h b/xen/arch/arm/include/asm/ perfc_defn.h index effd25b69e..8dfcac7e3b 100644 --- a/xen/arch/arm/include/asm/perfc_defn.h +++ b/xen/arch/arm/include/asm/

Re: [PATCH v5 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests

2025-07-02 Thread Mykola Kvach
Hi Julien, On Thu, Jul 3, 2025 at 1:57 AM Julien Grall wrote: > > Hi Mykola, > > On 02/07/2025 23:27, Mykola Kvach wrote: > > On Wed, Jul 2, 2025 at 3:28 PM Julien Grall wrote: > >> Why should we return an error? This is valid for a 64-bit domain to use > >> SMC32 convention. > > > > I mean — in

Re: [PATCH v5 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests

2025-07-02 Thread Julien Grall
Hi Mykola, On 02/07/2025 23:27, Mykola Kvach wrote: On Wed, Jul 2, 2025 at 3:28 PM Julien Grall wrote: Why should we return an error? This is valid for a 64-bit domain to use SMC32 convention. I mean — in that case, is it possible that the upper 32 bits are set to non-zero values without it

Re: [PATCH v5 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests

2025-07-02 Thread Mykola Kvach
On Wed, Jul 2, 2025 at 3:28 PM Julien Grall wrote: > > Hi, > > On 02/07/2025 11:01, Mykola Kvach wrote: > > On Sat, Jun 28, 2025 at 9:17 PM Julien Grall wrote: > >> It would be better if we stash the value sand then update the registers. > >> Another possibility would be to entirely skip the save

Re: [PATCH v5 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests

2025-07-02 Thread Julien Grall
Hi, On 02/07/2025 11:01, Mykola Kvach wrote: On Sat, Jun 28, 2025 at 9:17 PM Julien Grall wrote: It would be better if we stash the value sand then update the registers. Another possibility would be to entirely skip the save path for CPUs that are turned off (after all this is a bit useless wo

Re: [PATCH v5 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests

2025-07-02 Thread Mykola Kvach
Hi Julien, On Sat, Jun 28, 2025 at 9:17 PM Julien Grall wrote: > > Hi Mykola, > > On 27/06/2025 11:51, Mykola Kvach wrote: > > diff --git a/xen/arch/arm/include/asm/perfc_defn.h > > b/xen/arch/arm/include/asm/perfc_defn.h > > index effd25b69e..8dfcac7e3b 100644 > > --- a/xen/arch/arm/include/asm

Re: [PATCH v5 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests

2025-06-28 Thread Julien Grall
Hi Mykola, On 27/06/2025 11:51, Mykola Kvach wrote: diff --git a/xen/arch/arm/include/asm/perfc_defn.h b/xen/arch/arm/include/asm/perfc_defn.h index effd25b69e..8dfcac7e3b 100644 --- a/xen/arch/arm/include/asm/perfc_defn.h +++ b/xen/arch/arm/include/asm/perfc_defn.h @@ -33,6 +33,7 @@ PERFCOUNTE

[PATCH v5 1/4] xen/arm: Implement PSCI SYSTEM_SUSPEND call for guests

2025-06-27 Thread Mykola Kvach
From: Mykola Kvach This patch adds support for the PSCI SYSTEM_SUSPEND function in the vPSCI (virtual PSCI) interface, allowing guests to request suspend via the PSCI v1.0 SYSTEM_SUSPEND call (both 32-bit and 64-bit variants). The implementation: - Adds SYSTEM_SUSPEND function IDs to PSCI defini