Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-13 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM."): > IMO it would be good to modify the commit message so it covers the > fact that the emulated host bridge on Arm does not advertise IO port > support, so the

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-13 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM."): > On Tue, Oct 12, 2021 at 01:42:22PM -0700, Stefano Stabellini wrote: > > I don't think it is about performance. From a performance point of view, > > w

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-13 Thread Roger Pau Monné
On Tue, Oct 12, 2021 at 01:42:22PM -0700, Stefano Stabellini wrote: > On Tue, 12 Oct 2021, Ian Jackson wrote: > > Bertrand Marquis writes ("Re: [PATCH v5 01/11] xen/arm: > > xc_domain_ioport_permission(..) not supported on ARM."): > > > I can add something in

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-13 Thread Roger Pau Monné
On Tue, Oct 12, 2021 at 04:15:20PM +, Bertrand Marquis wrote: > Hi Ian, > > > On 12 Oct 2021, at 15:53, Ian Jackson wrote: > > > > Bertrand Marquis writes ("Re: [PATCH v5 01/11] xen/arm: > > xc_domain_ioport_permission(..) not supported on ARM."):

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Stefano Stabellini
On Tue, 12 Oct 2021, Ian Jackson wrote: > Bertrand Marquis writes ("Re: [PATCH v5 01/11] xen/arm: > xc_domain_ioport_permission(..) not supported on ARM."): > > I can add something in the commit message about the fact that we improve > > performance and prevent to do

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Ian Jackson
Bertrand Marquis writes ("Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM."): > I can add something in the commit message about the fact that we improve > performance and prevent to do a call that is and will not be supported in Xen. Thanks

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Bertrand Marquis
Hi Ian, > On 12 Oct 2021, at 15:53, Ian Jackson wrote: > > Bertrand Marquis writes ("Re: [PATCH v5 01/11] xen/arm: > xc_domain_ioport_permission(..) not supported on ARM."): >> So there is no comment remaining on this patch ? > > I have been following this t

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Ian Jackson
Bertrand Marquis writes ("Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM."): > So there is no comment remaining on this patch ? I have been following this thread. I think I have a notion of why this is needed but I'm not 100% clear on it.

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Jan Beulich
On 12.10.2021 12:41, Bertrand Marquis wrote: > So there is no comment remaining on this patch ? No, but the comments weren't on the patch anyway, but on a question raised in the course of the discussion. > Would it possible to get an ack on it ? No, as I can't ack this patch: I'm not a maintaine

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Bertrand Marquis
Hi Jan, > On 12 Oct 2021, at 11:20, Jan Beulich wrote: > > On 12.10.2021 12:06, Oleksandr Andrushchenko wrote: >> On 12.10.21 13:01, Jan Beulich wrote: >>> On 12.10.2021 11:38, Oleksandr Andrushchenko wrote: On 12.10.21 12:32, Jan Beulich wrote: > The minimal thing I'd suggest (or maybe

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Jan Beulich
On 12.10.2021 12:06, Oleksandr Andrushchenko wrote: > On 12.10.21 13:01, Jan Beulich wrote: >> On 12.10.2021 11:38, Oleksandr Andrushchenko wrote: >>> On 12.10.21 12:32, Jan Beulich wrote: The minimal thing I'd suggest (or maybe you're doing this already) would be to expose such BARs to t

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Oleksandr Andrushchenko
On 12.10.21 13:01, Jan Beulich wrote: > On 12.10.2021 11:38, Oleksandr Andrushchenko wrote: >> On 12.10.21 12:32, Jan Beulich wrote: >>> On 12.10.2021 10:41, Bertrand Marquis wrote: > On 12 Oct 2021, at 09:29, Jan Beulich wrote: > On 11.10.2021 19:11, Bertrand Marquis wrote: >>> On 1

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Jan Beulich
On 12.10.2021 11:40, Bertrand Marquis wrote: > Hi Jan, > >> On 12 Oct 2021, at 10:32, Jan Beulich wrote: >> >> On 12.10.2021 10:41, Bertrand Marquis wrote: >>> Hi Jan, >>> On 12 Oct 2021, at 09:29, Jan Beulich wrote: On 11.10.2021 19:11, Bertrand Marquis wrote: >> On 11 Oct 20

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Jan Beulich
On 12.10.2021 11:38, Oleksandr Andrushchenko wrote: > On 12.10.21 12:32, Jan Beulich wrote: >> On 12.10.2021 10:41, Bertrand Marquis wrote: On 12 Oct 2021, at 09:29, Jan Beulich wrote: On 11.10.2021 19:11, Bertrand Marquis wrote: >> On 11 Oct 2021, at 17:32, Roger Pau Monné wrote: >

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Bertrand Marquis
Hi Jan, > On 12 Oct 2021, at 10:32, Jan Beulich wrote: > > On 12.10.2021 10:41, Bertrand Marquis wrote: >> Hi Jan, >> >>> On 12 Oct 2021, at 09:29, Jan Beulich wrote: >>> >>> On 11.10.2021 19:11, Bertrand Marquis wrote: > On 11 Oct 2021, at 17:32, Roger Pau Monné wrote: > On Mon, Oct

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Oleksandr Andrushchenko
On 12.10.21 12:32, Jan Beulich wrote: > On 12.10.2021 10:41, Bertrand Marquis wrote: >> Hi Jan, >> >>> On 12 Oct 2021, at 09:29, Jan Beulich wrote: >>> >>> On 11.10.2021 19:11, Bertrand Marquis wrote: > On 11 Oct 2021, at 17:32, Roger Pau Monné wrote: > On Mon, Oct 11, 2021 at 02:16:19P

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Jan Beulich
On 12.10.2021 10:41, Bertrand Marquis wrote: > Hi Jan, > >> On 12 Oct 2021, at 09:29, Jan Beulich wrote: >> >> On 11.10.2021 19:11, Bertrand Marquis wrote: On 11 Oct 2021, at 17:32, Roger Pau Monné wrote: On Mon, Oct 11, 2021 at 02:16:19PM +, Bertrand Marquis wrote: >> On 11 Oc

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Bertrand Marquis
Hi Jan, > On 12 Oct 2021, at 09:29, Jan Beulich wrote: > > On 11.10.2021 19:11, Bertrand Marquis wrote: >>> On 11 Oct 2021, at 17:32, Roger Pau Monné wrote: >>> On Mon, Oct 11, 2021 at 02:16:19PM +, Bertrand Marquis wrote: > On 11 Oct 2021, at 14:57, Roger Pau Monné wrote: > I thin

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-12 Thread Jan Beulich
On 11.10.2021 19:11, Bertrand Marquis wrote: >> On 11 Oct 2021, at 17:32, Roger Pau Monné wrote: >> On Mon, Oct 11, 2021 at 02:16:19PM +, Bertrand Marquis wrote: On 11 Oct 2021, at 14:57, Roger Pau Monné wrote: I think the commit message needs to at least be expanded in order to >>>

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Bertrand Marquis
Hi Roger, > On 11 Oct 2021, at 17:32, Roger Pau Monné wrote: > > On Mon, Oct 11, 2021 at 02:16:19PM +, Bertrand Marquis wrote: >> Hi Roger, >> >>> On 11 Oct 2021, at 14:57, Roger Pau Monné wrote: >>> >>> On Mon, Oct 11, 2021 at 01:40:30PM +, Bertrand Marquis wrote: Hi Roger,

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Roger Pau Monné
On Mon, Oct 11, 2021 at 02:16:19PM +, Bertrand Marquis wrote: > Hi Roger, > > > On 11 Oct 2021, at 14:57, Roger Pau Monné wrote: > > > > On Mon, Oct 11, 2021 at 01:40:30PM +, Bertrand Marquis wrote: > >> Hi Roger, > >> > >> + Oleksandr to have a better PCI expert then me. > >> > >>> On

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Bertrand Marquis
Hi Roger, > On 11 Oct 2021, at 14:57, Roger Pau Monné wrote: > > On Mon, Oct 11, 2021 at 01:40:30PM +, Bertrand Marquis wrote: >> Hi Roger, >> >> + Oleksandr to have a better PCI expert then me. >> >>> On 11 Oct 2021, at 14:20, Roger Pau Monné wrote: >>> >>> On Mon, Oct 11, 2021 at 12:11

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Oleksandr Andrushchenko
Hi, all On 11.10.21 16:40, Bertrand Marquis wrote: > Hi Roger, > > + Oleksandr to have a better PCI expert then me. > >> On 11 Oct 2021, at 14:20, Roger Pau Monné wrote: >> >> On Mon, Oct 11, 2021 at 12:11:04PM +, Bertrand Marquis wrote: >>> Hi Roger, >>> On 11 Oct 2021, at 12:47, Roger

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Roger Pau Monné
On Mon, Oct 11, 2021 at 01:40:30PM +, Bertrand Marquis wrote: > Hi Roger, > > + Oleksandr to have a better PCI expert then me. > > > On 11 Oct 2021, at 14:20, Roger Pau Monné wrote: > > > > On Mon, Oct 11, 2021 at 12:11:04PM +, Bertrand Marquis wrote: > >> Hi Roger, > >> > >>> On 11 Oc

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Bertrand Marquis
Hi Roger, + Oleksandr to have a better PCI expert then me. > On 11 Oct 2021, at 14:20, Roger Pau Monné wrote: > > On Mon, Oct 11, 2021 at 12:11:04PM +, Bertrand Marquis wrote: >> Hi Roger, >> >>> On 11 Oct 2021, at 12:47, Roger Pau Monné wrote: >>> >>> On Wed, Oct 06, 2021 at 06:40:27PM

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Roger Pau Monné
On Mon, Oct 11, 2021 at 12:11:04PM +, Bertrand Marquis wrote: > Hi Roger, > > > On 11 Oct 2021, at 12:47, Roger Pau Monné wrote: > > > > On Wed, Oct 06, 2021 at 06:40:27PM +0100, Rahul Singh wrote: > >> ARM architecture does not implement I/O ports. Ignore this call on ARM > >> to avoid the

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Bertrand Marquis
Hi Roger, > On 11 Oct 2021, at 12:47, Roger Pau Monné wrote: > > On Wed, Oct 06, 2021 at 06:40:27PM +0100, Rahul Singh wrote: >> ARM architecture does not implement I/O ports. Ignore this call on ARM >> to avoid the overhead of making a hypercall just for Xen to return >> -ENOSYS. > > What is t

Re: [PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-11 Thread Roger Pau Monné
On Wed, Oct 06, 2021 at 06:40:27PM +0100, Rahul Singh wrote: > ARM architecture does not implement I/O ports. Ignore this call on ARM > to avoid the overhead of making a hypercall just for Xen to return > -ENOSYS. What is the cal trace of this function actually on Arm? AFAICT libxl will only call

[PATCH v5 01/11] xen/arm: xc_domain_ioport_permission(..) not supported on ARM.

2021-10-06 Thread Rahul Singh
ARM architecture does not implement I/O ports. Ignore this call on ARM to avoid the overhead of making a hypercall just for Xen to return -ENOSYS. Signed-off-by: Rahul Singh Reviewed-by: Stefano Stabellini Reviewed-by: Bertrand Marquis --- Change in v5: none Change in v4: - Added Reviewed-by: B